From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#28571: 25.3; Compile error on macOS Sierra Date: Sun, 24 Sep 2017 11:23:47 +0000 Message-ID: References: <20170923193130.GB6576@breton.holly.idiocy.org> <20170924110658.GA30865@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113d64128c08870559edad4b" X-Trace: blaine.gmane.org 1506252315 2645 195.159.176.226 (24 Sep 2017 11:25:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 24 Sep 2017 11:25:15 +0000 (UTC) Cc: 28571@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 24 13:25:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dw520-0008QD-St for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Sep 2017 13:25:05 +0200 Original-Received: from localhost ([::1]:37643 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dw528-0008EF-0D for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Sep 2017 07:25:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dw521-0008Du-LM for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2017 07:25:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dw51y-0005oW-HJ for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2017 07:25:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46560) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dw51y-0005oK-CE for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2017 07:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dw51y-0004u5-3P for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2017 07:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Sep 2017 11:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28571 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28571-submit@debbugs.gnu.org id=B28571.150625224618781 (code B ref 28571); Sun, 24 Sep 2017 11:25:02 +0000 Original-Received: (at 28571) by debbugs.gnu.org; 24 Sep 2017 11:24:06 +0000 Original-Received: from localhost ([127.0.0.1]:55241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dw513-0004sr-Po for submit@debbugs.gnu.org; Sun, 24 Sep 2017 07:24:06 -0400 Original-Received: from mail-oi0-f52.google.com ([209.85.218.52]:49868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dw511-0004sG-2E for 28571@debbugs.gnu.org; Sun, 24 Sep 2017 07:24:04 -0400 Original-Received: by mail-oi0-f52.google.com with SMTP id i128so3604596oih.6 for <28571@debbugs.gnu.org>; Sun, 24 Sep 2017 04:24:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qcFg3ZkBRviwIgNPZCh+5n/1mAQVmjbJoDmYJAjDzxc=; b=ApYatIal7T6LpYo2nfAiy8iONcj+cSFx1DNc0xCo5CYxNM/U4Sk+U48r90xioV6YxC 0C6lmXwzJG64Ioyjt6MrW3/JHcZ+dsCsYVfx0CcuCH4elJt364eOLJswGvqDqZwgDmVD O4LCD/g0ONXJ2Rnar0eH3xNzkkQFA/flmRMJi4O2hvoiEbZEk1/ITO3Tg+HJZeVP05r7 m77FOyJegeK3WW8y7Y6lQxbUh0f0cb+ivH5RmTU2x6hpEaeEcnHDhCs67c8u2JQcTVKj +3dZMG8DweGntiIqs/+ppnkNZMGgdjZcqODm67JeeXdc/3tR7yecrj/HlsQDuDuqnOJn mvIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qcFg3ZkBRviwIgNPZCh+5n/1mAQVmjbJoDmYJAjDzxc=; b=XBIjvGiXT0MqgJBPZ//FxJRyre0sHxz8pLPSouwkSpKkLF2ffgnSyMV1DU2edsCBRR AAqZmUuV1RXzZ+favyXLkMmMdLm7eTGdnJFmxXntxp4JOgJWOF2/f8RI4GaNpJF3P8Sh lQmDAQCTC3LqS41xLqGmYD/lRIsLi7VJQAKe0bwuKmHD2QT6nRgIdj6nPDIvnRhWGlFJ D+0ChMFNvWncxEpB+UUBTcrGTnvUlfamTGk2B/KjueTCKimaH7rbBwh58Klv5NXIU8Rl c7OevOp1Db74jGTXmQiiedKvGDdinfeWOM2aVYWa0TDa3P2KNtzSN2hfj7et9RT3/Ma9 QHqg== X-Gm-Message-State: AHPjjUhBAFe0jwCt+1eTpPOufuKIfOZb6OKVgBEKHVJXKqGSZn2iBUHM AXeHZEMshgRMPg36rJXrds00PFosenmHMelVuuBXkefw X-Google-Smtp-Source: AOwi7QDXlyqCVw59SAu2TWgSniSqjURZOdQC97CzRh4kdWL8XQ9q2qvNV+9fzRMgNR54fmK+Ek7NB9UeFC6IUHHhXJw= X-Received: by 10.202.216.198 with SMTP id p189mr4955959oig.32.1506252237308; Sun, 24 Sep 2017 04:23:57 -0700 (PDT) In-Reply-To: <20170924110658.GA30865@breton.holly.idiocy.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137330 Archived-At: --001a113d64128c08870559edad4b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Alan Third schrieb am So., 24. Sep. 2017 um 13:07 Uhr: > On Sun, Sep 24, 2017 at 07:49:55AM +0000, Philipp Stephani wrote: > > Alan Third schrieb am Sa., 23. Sep. 2017 um 21:31 Uhr= : > > > > > > Is there maybe a test in configure that=E2=80=99s incorrectly identif= ying this > > > utimens.c stuff as OK? > > > > > > > > I do have configure output like this: > > > > checking for futimens... yes > > checking for utimensat... yes > > > > So I think the functions are there, but the compilation shouldn't use > them > > since they would make the binary incompatible with old versions of macO= S. > > I agree. I=E2=80=99ve attached a patch that should sort it. > Thanks, the patch works, but you also need to #undef HAVE_UTIMENSAT. However, I'm wondering whether that's the right way to solve it. It means we're making some of the checks manual that have previously been automated, which implies that we need to recheck in the future whether the checks are still appropriate etc. Wouldn't it be better to modify configure.ac so that it doesn't detect these functions as present in the first place if we don't want to use them? --001a113d64128c08870559edad4b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Alan T= hird <alan@idiocy.org> schrieb= am So., 24. Sep. 2017 um 13:07=C2=A0Uhr:
On Sun, Sep 24, 2017 at 07:49:55AM +0000, Philipp Stephani wrote: > Alan Third <al= an@idiocy.org> schrieb am Sa., 23. Sep. 2017 um 21:31 Uhr:
> >
> > Is there maybe a test in configure that=E2=80=99s incorrectly ide= ntifying this
> > utimens.c stuff as OK?
> >
> >
> I do have configure output like this:
>
> checking for futimens... yes
> checking for utimensat... yes
>
> So I think the functions are there, but the compilation shouldn't = use them
> since they would make the binary incompatible with old versions of mac= OS.

I agree. I=E2=80=99ve attached a patch that should sort it.

Thanks, the patch works, but you also need to #undef= =C2=A0HAVE_UTIMENSAT.
However, I'm wondering whether that'= ;s the right way to solve it. It means we're making some of the checks = manual that have previously been automated, which implies that we need to r= echeck in the future whether the checks are still appropriate etc. Wouldn&#= 39;t it be better to modify configure.ac so that it doesn't detect these functions as present in the first pla= ce if we don't want to use them?
--001a113d64128c08870559edad4b--