From: Philipp Stephani <p.stephani2@gmail.com>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 53068@debbugs.gnu.org
Subject: bug#53068: 28.0.90; Emacs 28 regression: Can't edebug inline functions
Date: Thu, 13 Jan 2022 12:57:34 +0100 [thread overview]
Message-ID: <CAArVCkQCOjcNLM8KbhWbBYOb1XpR-mmsJXFjn6RNS61n3FgGaQ@mail.gmail.com> (raw)
In-Reply-To: <CAArVCkS1DP=ntHp_D701Ab_c0_Btedn72sJWsbPry9=r96u-Vw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
Am Mi., 12. Jan. 2022 um 22:16 Uhr schrieb Philipp Stephani
<p.stephani2@gmail.com>:
>
> Am So., 9. Jan. 2022 um 21:49 Uhr schrieb Michael Heerdegen
> <michael_heerdegen@web.de>:
> >
> > Michael Heerdegen <michael_heerdegen@web.de> writes:
> >
> > > Philipp Stephani <p.stephani2@gmail.com> writes:
> > >
> > > > Visit the file lisp/json.el, navigate to the `json-advance' inline
> > > > function, and hit C-u C-M-x. This fails [...]
> > >
> > > The culprit seems to be the edebug spec of `inline-quote' (that macro is
> > > called by `json-advance')
> >
> > Should the edebug-spec of `inline-quote' be (backquote-form) instead of
> > backquote-form?
>
> I guess so.
Any objections to installing the following patch on the emacs-28 branch?
[-- Attachment #2: 0001-Fix-Edebug-specification-for-inline-functions-Bug-53.patch --]
[-- Type: text/x-patch, Size: 1814 bytes --]
From ec1ce1dbddd6196bbffdfb32d63d4bb1a13010ea Mon Sep 17 00:00:00 2001
From: Philipp Stephani <phst@google.com>
Date: Thu, 13 Jan 2022 12:55:06 +0100
Subject: [PATCH] Fix Edebug specification for inline functions (Bug#53068).
* lisp/emacs-lisp/inline.el (inline-quote): Fix Edebug specification.
* test/lisp/emacs-lisp/edebug-tests.el (edebug-tests-inline): New unit
test.
---
lisp/emacs-lisp/inline.el | 2 +-
test/lisp/emacs-lisp/edebug-tests.el | 10 ++++++++++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/inline.el b/lisp/emacs-lisp/inline.el
index 963e117ff3..de0112db63 100644
--- a/lisp/emacs-lisp/inline.el
+++ b/lisp/emacs-lisp/inline.el
@@ -71,7 +71,7 @@
(defmacro inline-quote (_exp)
"Similar to backquote, but quotes code and only accepts , and not ,@."
- (declare (debug backquote-form))
+ (declare (debug (backquote-form)))
(error "inline-quote can only be used within define-inline"))
(defmacro inline-const-p (_exp)
diff --git a/test/lisp/emacs-lisp/edebug-tests.el b/test/lisp/emacs-lisp/edebug-tests.el
index 92f63ec788..4aae2870a3 100644
--- a/test/lisp/emacs-lisp/edebug-tests.el
+++ b/test/lisp/emacs-lisp/edebug-tests.el
@@ -1093,5 +1093,15 @@ edebug-tests-duplicate-&define
(edebug-new-definition name))))
(should-error (eval-buffer) :type 'invalid-read-syntax))))
+(ert-deftest edebug-tests-inline ()
+ "Check that Edebug can instrument inline functions (Bug#53068)."
+ (with-temp-buffer
+ (print '(define-inline edebug-tests-inline (arg)
+ (inline-quote ,arg))
+ (current-buffer))
+ (let ((edebug-all-defs t)
+ (edebug-initial-mode 'Go-nonstop))
+ (eval-buffer))))
+
(provide 'edebug-tests)
;;; edebug-tests.el ends here
--
2.34.1.703.g22d0c6ccf7-goog
next prev parent reply other threads:[~2022-01-13 11:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 8:38 bug#53068: 28.0.90; Emacs 28 regression: Can't edebug inline functions Philipp Stephani
2022-01-09 20:17 ` Michael Heerdegen
2022-01-09 20:49 ` Michael Heerdegen
2022-01-10 6:52 ` Michael Heerdegen
2022-01-12 21:16 ` Philipp Stephani
2022-01-13 11:57 ` Philipp Stephani [this message]
2022-01-13 12:40 ` Eli Zaretskii
2022-01-13 13:31 ` Philipp Stephani
2022-01-14 20:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-11 17:30 ` Philipp Stephani
2022-01-11 18:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkQCOjcNLM8KbhWbBYOb1XpR-mmsJXFjn6RNS61n3FgGaQ@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=53068@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).