From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#24675: 26.0.50; Misleading suggestion in Ediff Info manual Date: Fri, 23 Dec 2016 18:30:06 +0000 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1148d9fedf75af0544579359 X-Trace: blaine.gmane.org 1482517888 29289 195.159.176.226 (23 Dec 2016 18:31:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Dec 2016 18:31:28 +0000 (UTC) To: Glenn Morris , 24675-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 23 19:31:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKUcg-00065M-50 for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Dec 2016 19:31:18 +0100 Original-Received: from localhost ([::1]:40385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKUcj-0004v2-7o for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Dec 2016 13:31:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKUcU-0004s4-R3 for bug-gnu-emacs@gnu.org; Fri, 23 Dec 2016 13:31:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKUcQ-0008Ob-2V for bug-gnu-emacs@gnu.org; Fri, 23 Dec 2016 13:31:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37555) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cKUcP-0008OR-Vx for bug-gnu-emacs@gnu.org; Fri, 23 Dec 2016 13:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cKUcP-0007n6-R0 for bug-gnu-emacs@gnu.org; Fri, 23 Dec 2016 13:31:01 -0500 Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Dec 2016 18:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 24675 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 24675@debbugs.gnu.org, p.stephani2@gmail.com, p.stephani2@gmail.com Original-Received: via spool by 24675-done@debbugs.gnu.org id=D24675.148251782429899 (code D ref 24675); Fri, 23 Dec 2016 18:31:01 +0000 Original-Received: (at 24675-done) by debbugs.gnu.org; 23 Dec 2016 18:30:24 +0000 Original-Received: from localhost ([127.0.0.1]:52952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKUbo-0007mA-04 for submit@debbugs.gnu.org; Fri, 23 Dec 2016 13:30:24 -0500 Original-Received: from mail-wm0-f47.google.com ([74.125.82.47]:38660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKUbn-0007ly-0K for 24675-done@debbugs.gnu.org; Fri, 23 Dec 2016 13:30:23 -0500 Original-Received: by mail-wm0-f47.google.com with SMTP id k184so23069429wme.1 for <24675-done@debbugs.gnu.org>; Fri, 23 Dec 2016 10:30:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=GotiVBhhp9gD0l5ar3CdFcSRh0RW7b6q4DYgooncxsw=; b=i+aoCMfM2FTMyG+VVo/11H4kvopKiIRw7hAaU3GoqJrYTYbp8u/a75kri9UB5nz87W TARY5aZJ5oupYQ4w5h+Yv7xFymnh1jNCHe2LnOwwKeV00xDNS4++vgwohzJQvytYlU3O BnbKXtM+jioQMGScfFrXMB7yr/YX8JieNa/b41VE/tQbtY5OUsmAD/ZWD8I+V0jCV8qt ufSSDoOH4aCpL6cf27G3/ghxe+YSdzKkjdvcz13XGCtORARXtm8kJh71/7eoB8oe7vzG 1PcQD9ISU6cfvzp07Yhiasurx8E2Z0+yeqAwIXqjYVuDH+y7dcYfl5PXwciaFa9hXopq p3Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=GotiVBhhp9gD0l5ar3CdFcSRh0RW7b6q4DYgooncxsw=; b=gfRKPWIoGctfNeDEuQNypDcyHOC8q72ArJqsA04aXoBvzX+X+mo7LVfJigaTrMUUl0 jc/G0sAEom7TiSrMLBPAjBTGGJrijS+9Vu7m2zyRaHAKy9QHJl9a9zbG1QeqDgE9ImB2 /9XnA50trXRgIOQiYR4hKVytXwAqqeqAKQMHhiO2+fAor84yERPfNeLRQ67gjiFt8OAu 3hylFaVksEnOpmgHUDpDXrPj+F8I963JI7Cnr2t+u+UEaHXR8jSGtpi+V6oQZoZu/Oc1 7dmLA0Go4nqEC3q4lo6n1sdx2T85xV+K/VbSHMp+sGh+qU0LZjcwnE+MCrbIoe25NaMV +yLQ== X-Gm-Message-State: AIkVDXKN0zBG9ktBLAdH2NXa6/qD5MXpao7fuHY0ur7pkwENyd54ThTtIlJQXzwcXSPlrvWeBHaYKUFVTIQi6Q== X-Received: by 10.28.195.9 with SMTP id t9mr14069695wmf.92.1482517817290; Fri, 23 Dec 2016 10:30:17 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127375 Archived-At: --001a1148d9fedf75af0544579359 Content-Type: text/plain; charset=UTF-8 Philipp Stephani schrieb am So., 18. Dez. 2016 um 22:25 Uhr: > Glenn Morris schrieb am Di., 13. Dez. 2016 um 19:03 Uhr: > > Philipp Stephani wrote: > > > The Ediff Info manual, in section 7.1 "Hooks", says: > > > > 'ediff-cleanup-hook' > > This hook is run just before 'ediff-quit-hook'. This is a good > > place to do various cleanups, such as deleting the variant buffers. > > Ediff provides a function, 'ediff-janitor', as one such possible > > hook, which you can add to 'ediff-cleanup-hook' with 'add-hook'. > > > > However, ediff-cleanup-hook is a normal hook, and ediff-janitor is a > > function taking two required arguments, so it cannot be added to > > ediff-cleanup-hook. The manual should e.g. state that a lambda wrapping > > ediff-janitor can be added to ediff-cleanup-hook, but not ediff-janitor > > itself. > > It seems the doc hasn't been updated in the past 14 years. > Before 50a07e1, there was a single optional argument. > You might be one of the few users of this functionality, so maybe you > would like to fix the doc yourself? > > > I don't use it myself, but I got a report from a colleague who interpreted > the manual such that you could add ediff-janitor directly to the hook with > add-hook. I've attached a patch to clarify this. I'll push it to emacs-25 > in a few days until there are complaints. > Pushed as f69bd7954f113719bb0e46e143231744c80bef34. --001a1148d9fedf75af0544579359 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Philip= p Stephani <p.stephani2@gmail.c= om> schrieb am So., 18. Dez. 2016 um 22:25=C2=A0Uhr:
Glenn Morris &= lt;rgm= @gnu.org> schrieb am Di., 13. Dez. 2016 um 19:03=C2=A0Uhr:
Philipp Steph= ani wrote:

> The Ediff Info manual, in section 7.1 "Hooks", says:
>
> 'ediff-cleanup-hook'
>=C2=A0 =C2=A0 =C2=A0 This hook is run just before 'ediff-quit-hook&= #39;.=C2=A0 This is a good
>=C2=A0 =C2=A0 =C2=A0 place to do various cleanups, such as deleting the= variant buffers.
>=C2=A0 =C2=A0 =C2=A0 Ediff provides a function, 'ediff-janitor'= , as one such possible
>=C2=A0 =C2=A0 =C2=A0 hook, which you can add to 'ediff-cleanup-hook= ' with 'add-hook'.
>
> However, ediff-cleanup-hook is a normal hook, and ediff-janitor is a > function taking two required arguments, so it cannot be added to
> ediff-cleanup-hook.=C2=A0 The manual should e.g. state that a lambda w= rapping
> ediff-janitor can be added to ediff-cleanup-hook, but not ediff-janito= r
> itself.

It seems the doc hasn't been updated in the past 14 years.
Before 50a07e1, there was a single optional argument.
You might be one of the few users of this functionality, so maybe you
would like to fix the doc yourself?
<= br class=3D"gmail_msg">
I don'= t use it myself, but I got a report from a colleague who interpreted the ma= nual such that you could add ediff-janitor directly to the hook with add-ho= ok. I've attached a patch to clarify this. I'll push it to emacs-25= in a few days until there are complaints.=C2=A0

Pushed as f69bd7954f113719bb0e46e143231744c80bef34.= =C2=A0
--001a1148d9fedf75af0544579359--