From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#45198: 28.0.50; Sandbox mode Date: Tue, 29 Dec 2020 17:05:33 +0100 Message-ID: References: <838s9gk476.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15792"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Bastien , 45198@debbugs.gnu.org, Stefan Monnier , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 29 17:06:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuHVm-000400-Su for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 17:06:14 +0100 Original-Received: from localhost ([::1]:47852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuHVl-0004i9-Sn for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 11:06:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuHVa-0004gf-Vw for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 11:06:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56687) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuHVa-00062Y-Nt for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 11:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kuHVa-0008JE-Hd for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 11:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Dec 2020 16:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45198 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45198-submit@debbugs.gnu.org id=B45198.160925795531922 (code B ref 45198); Tue, 29 Dec 2020 16:06:02 +0000 Original-Received: (at 45198) by debbugs.gnu.org; 29 Dec 2020 16:05:55 +0000 Original-Received: from localhost ([127.0.0.1]:40000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuHVT-0008Io-7w for submit@debbugs.gnu.org; Tue, 29 Dec 2020 11:05:55 -0500 Original-Received: from mail-oi1-f169.google.com ([209.85.167.169]:43702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuHVO-0008IP-QP for 45198@debbugs.gnu.org; Tue, 29 Dec 2020 11:05:54 -0500 Original-Received: by mail-oi1-f169.google.com with SMTP id q25so15015074oij.10 for <45198@debbugs.gnu.org>; Tue, 29 Dec 2020 08:05:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=de0DtHzrl+qsxf9cvWumYZsmBa16mqCF1k3VrVZ12PM=; b=J+OoGylXasoGrmWNav8g/ZJPyTK4aBDD+zPwYa07QV2MglkXMuEjYl/FxA8zefLjDE JkGX4Nmh99yOpSVe3jphoMA8vBo0EPMeqwUrjy/YoCs2mYtJU2ZKNfCG9SjsEKdMueC0 Ny2of40yahMjLuoG4TdOOTBWIXmsVgDj1nyaN9ghrmyKlf6MJphSXTP8n6vKjWKUrun6 k11ukMGLXASnzVanTGfXEHwzhIy98KkWePBiuUk3GBCwMwOVgd8FknsJXP3Lhar+FEif 2iJSk806LOIj43G0olVAKZOXJDaaY0sMOGvVIhTQ18WYEtQxXCcJ1fRXptbhODdfRfdz DzJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=de0DtHzrl+qsxf9cvWumYZsmBa16mqCF1k3VrVZ12PM=; b=OhneUndCEBYKTDeynHizRvhcbtTJ+Pom9PmKJ3gVBzYEMXikgpeyLUGPzFilBnunME A5w8G8TZQedZGJR5uMXW47eRn/2Xlwq93MWiUHocG1SdN9Zp4fhr3JEzN2u6t3hPfitD x//ol+sFYwoNNbA7pZVzuT+S/wC2Idr9DYlQIOyofd+r4zju/88n9pvAf3hOXgyfZ4Iv 0uieo/dYSLjn9AkmDWgD0LeBMpAzj3qnhOK3wD0+2VpvIbNbI7XfXlyCsfHsdL6Omx0h f4HtB6ZNHq8qHQj4iMbWvEkM0fthZ0B2dfjq9Zv5M3GzdaXdSIcEFthJm8/C4VmDvni4 mtxg== X-Gm-Message-State: AOAM532RWmTGtyJCkFKDqt2chRwX4W2XGEEDp6gwLsggP72zOz2bAnQ5 azE94kDG0KOeCPUniAQycf16VMNDy8CPv9e/22Y= X-Google-Smtp-Source: ABdhPJxDEv8cNsTMuHjj4NMY7WDicW8AUHhWFONjPE8R+zxaelp/GN9+Esgps5ZJN0wiW6jmEZC+CfcoA+1KtAIqTyE= X-Received: by 2002:aca:3b03:: with SMTP id i3mr2735536oia.170.1609257944980; Tue, 29 Dec 2020 08:05:44 -0800 (PST) In-Reply-To: <838s9gk476.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196947 Archived-At: Am Di., 29. Dez. 2020 um 16:44 Uhr schrieb Eli Zaretskii : > > > It would be great if someone could test whether the Windows build > > still works after that, thanks! > > I only skimmed the changes, but I'm already quite sure they will break > the Windows build. Why? Everything should be behind ifdefs/conditional compilation, otherwise compilation on macOS would also break. > > This feature is not relevant to the MS-Windows build of Emacs, at > least currently (I don't think Windows implements equivalent features > in a way that is even remotely similar to GNU/Linux). So to make sure > the Windows port doesn't break, we must take every measure to avoid > compiling any of the related code on MS-Windows. In particular: > > . Gnulib modules pulled to support seccomp should be disabled in the > MS-Windows build, by suitable changes to nt/mingw-cfg.site and/or > nt/gnulib-cfg.mk; and This shouldn't be necessary, as Gnulib is compatible with Windows (I guess, since we use it elsewhere), and the MS C library provides an emulation layer for some parts of the POSIX API (e.g. file descriptors). OTOH, conditional compilation incurs a maintenance cost, so we should avoid it if possible. (That's also what gnulib-cfg.mk says: "In general, do NOT omit modules that don't need to be omitted, to minimize the differences from upstream gnulib.mk and thus make the maintenance easier.") > . header files used to support seccomp code should be #ifdef'ed by > HAVE_LINUX_SECCOMP_H or similar, and likewise with any code needed > for seccomp and unnecessary otherwise. That should already be the case. Turning the question around: is building the branch on Windows actually broken? If so, what are the error messages? > > Btw, I wonder why you needed to import the read-file module from > Gnulib -- does it provide any features that we couldn't implement on > our own? I'm asking because that module caused you to pull in quite a > few dependency modules from Gnulib, and I'm asking myself whether that > is really justified. We could implement it ourselves, if we wanted, and in an earlier version of the code I did that. But it's easier and less error-prone to reuse an existing library.