From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#23488: 25.0.93; Modules: inconsistent return types for error reporting Date: Sun, 28 Jul 2019 20:55:02 +0200 Message-ID: References: <87mugyba5n.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="187071"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 23488@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 28 20:56:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hroL3-000mYg-6T for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 20:56:09 +0200 Original-Received: from localhost ([::1]:46396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hroL1-0008Bb-J2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 14:56:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38254) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hroKx-0008BU-JY for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 14:56:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hroKw-0002tw-Lm for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 14:56:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38338) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hroKw-0002tV-FX for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 14:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hroKw-0004S7-CZ for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 14:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jul 2019 18:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23488 X-GNU-PR-Package: emacs Original-Received: via spool by 23488-submit@debbugs.gnu.org id=B23488.156434012217041 (code B ref 23488); Sun, 28 Jul 2019 18:56:02 +0000 Original-Received: (at 23488) by debbugs.gnu.org; 28 Jul 2019 18:55:22 +0000 Original-Received: from localhost ([127.0.0.1]:47159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hroKI-0004Qn-DT for submit@debbugs.gnu.org; Sun, 28 Jul 2019 14:55:22 -0400 Original-Received: from mail-ot1-f43.google.com ([209.85.210.43]:37946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hroKF-0004Qa-Vw for 23488@debbugs.gnu.org; Sun, 28 Jul 2019 14:55:20 -0400 Original-Received: by mail-ot1-f43.google.com with SMTP id d17so60441061oth.5 for <23488@debbugs.gnu.org>; Sun, 28 Jul 2019 11:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2SLG++uYbUe10xzJsHoKhQ6pEqh5daZ/XyWzPVUrcrw=; b=HrTaQLp+lti7RVWhvPHgCrW8ASqINlE9h9QO783vHaNuGib04S8vEO1h9eNOZeOH1V ZqsA669pHgI/wYm5FSjg1o6t8a5SuugsHDUyDe9nyUhQGC+fS2yRZRbALqM8kndonCcW oFFedsQkUp05EHYjgZL/Pwo1MKPxTy86xehs1NBYZHTU3UWBMT5GYFPtxwdWvwRz8Vsz +fvKcmuNU1AQ1CovXI5uEXiJ2GX2kQxUaSfa0yp5u8AhO2DVFMd9qvoWb5qZQAkxs7iw GSyCn/DiMr2sj4XTwH/aOWN8xj2RPtuPvdMgQBSC/ZKkPHJFn5CQ+fHCVzDhPiQne8jB P+PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2SLG++uYbUe10xzJsHoKhQ6pEqh5daZ/XyWzPVUrcrw=; b=HIdttKxh9G/1Bqs31OG3jjv7nNHzaltqEDgng+K+Ji7a3LyYxBeG8eRRKBiBibCwPR ta08wgL84Y0vC6Y2JGNBqjSWZtiRPQcj2D0xUBtcwSiKUuuHKSQ/YpYylo7riF/IfVnC l9SsUF6rNNvOWeFLEJMXI93aRPHXGKFWAJUGR6l+ZYf2BdeRggjVMuShXlMNtAvZ4eWV mM7OoVXSsEuv1LauJbM7e4ofVfyNwPQs05JN9k1o8D6Ts+bx0RRp5AyAE/yY7Foimt8C Ygp0Zr3PsfvjA8bbKn159Uz8KEMB35NREsHUxZ4oT8mKCm1zBU3nwk8tymyFsW5DDmsL 1WCw== X-Gm-Message-State: APjAAAWwFke/CGjfWk+43Aspv89tLVWmtYP+aoHVOvKuHmzyd8lCuskh jXjtLFCl+kwwTSiWT6vR2y7Irb7JQoFAFzxsd/8= X-Google-Smtp-Source: APXvYqwKGoWzFlQnqPUBvj7veVcMODPSGgqU2Yfnl2FZScxOdePYLa/YFbaofoX7E5TmV1+Zwe4pFZSMndGFxupb4cA= X-Received: by 2002:a05:6830:1197:: with SMTP id u23mr17972746otq.36.1564340113961; Sun, 28 Jul 2019 11:55:13 -0700 (PDT) In-Reply-To: <87mugyba5n.fsf@mouse.gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163987 Archived-At: Am So., 28. Juli 2019 um 14:45 Uhr schrieb Lars Ingebrigtsen : > > Philipp Stephani writes: > > > Of the module environment functions, 'copy_string_contents' is > > inconsistent with all the other functions in that it returns a boolean > > to indicate success/failure. All other functions only set the last > > error status, to be checked with non_local_exit_check etc. This should > > be made consistent, e.g. my having copy_string_contents return void. > > Is that possible to do at this late date? It's part of the advertised > API, I think, and changing it sounds like it'd break modules. Yes, it's indeed way too late to change the API now. > > > Furthermore, the comment for copy_string_contents is incorrect. If > > BUFFER is NULL, it returns true, not false. > > I see you've fixed this later... Sounds good, feel free to close this.