From: Geoffrey Ferrari <geoffrey.ferrari@oriel.oxon.org>
To: michael.albinus@gmx.de
Cc: 33394@debbugs.gnu.org
Subject: bug#33394: 27.0.50; trampver cannot determine repository version
Date: Thu, 15 Nov 2018 13:10:53 +0000 [thread overview]
Message-ID: <CAAoeO9j2iTmFq6E0Osdp634HLqArLW25ypM+UVqPiKfpJfFJVQ@mail.gmail.com> (raw)
In-Reply-To: <8736s2fqi2.fsf@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]
Thanks, Michael.
I no longer get an error message with the new version of trampver, so this
seems to have fix it. Of course, the two constants tramp-repository-branch
and tramp-repository-version now both have the value nil on an end user
system, but I assume that's both acceptable and intended.
Kind regards,
Geoff
On Thu, 15 Nov 2018 at 12:57, Michael Albinus <michael.albinus@gmx.de>
wrote:
> Geoffrey Ferrari <geoffrey.ferrari@oriel.oxon.org> writes:
>
> Hi Geoffrey,
>
> > Thanks Michael. On further investigation, I've found that this minimal
> > code (after starting with emacs -Q) produces the same unexpected
> > error:
> >
> > (condition-case nil
> > (emacs-repository-get-branch nil)
> > (error nil))
>
> You're right. After setting `default-directory' and `source-directory'
> to "/not/existing" I see the same error. `call-process' seems to break
> the `condition-case' jail.
>
> > I don't think I can investigate further as condition-case is not a
> > lisp function.
>
> I've hardened trampver.el, committed to the master branch. Could you,
> pls, check?
>
> > Kind regards
> >
> > Geoff
>
> Best regards, Michael.
>
[-- Attachment #2: Type: text/html, Size: 1744 bytes --]
next prev parent reply other threads:[~2018-11-15 13:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 9:45 bug#33394: 27.0.50; trampver cannot determine repository version Geoffrey Ferrari
2018-11-15 11:40 ` Michael Albinus
2018-11-15 11:56 ` Geoffrey Ferrari
2018-11-15 12:56 ` Michael Albinus
2018-11-15 13:10 ` Geoffrey Ferrari [this message]
2018-11-15 13:19 ` Michael Albinus
2020-04-01 4:09 ` Clément Pit-Claudel
2020-04-01 10:13 ` Michael Albinus
2020-04-01 13:03 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAoeO9j2iTmFq6E0Osdp634HLqArLW25ypM+UVqPiKfpJfFJVQ@mail.gmail.com \
--to=geoffrey.ferrari@oriel.oxon.org \
--cc=33394@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).