From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Geoffrey Ferrari Newsgroups: gmane.emacs.bugs Subject: bug#33394: 27.0.50; trampver cannot determine repository version Date: Thu, 15 Nov 2018 11:56:24 +0000 Message-ID: References: <87tvkifu1q.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000001b98a9057ab2be23" X-Trace: blaine.gmane.org 1542282908 20595 195.159.176.226 (15 Nov 2018 11:55:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Nov 2018 11:55:08 +0000 (UTC) Cc: 33394@debbugs.gnu.org To: michael.albinus@gmx.de Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 15 12:55:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNGEh-0005EF-M5 for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Nov 2018 12:55:03 +0100 Original-Received: from localhost ([::1]:38295 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNGGn-0003qI-Nv for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Nov 2018 06:57:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNGGh-0003pj-2u for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2018 06:57:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNGGc-0003DU-KO for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2018 06:57:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48806) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gNGGc-0003DQ-H3 for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2018 06:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gNGGc-0003UT-8z for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2018 06:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Geoffrey Ferrari Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Nov 2018 11:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33394 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33394-submit@debbugs.gnu.org id=B33394.154228300413391 (code B ref 33394); Thu, 15 Nov 2018 11:57:02 +0000 Original-Received: (at 33394) by debbugs.gnu.org; 15 Nov 2018 11:56:44 +0000 Original-Received: from localhost ([127.0.0.1]:53064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNGGJ-0003Tv-Qj for submit@debbugs.gnu.org; Thu, 15 Nov 2018 06:56:44 -0500 Original-Received: from mail-vs1-f41.google.com ([209.85.217.41]:44063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNGGH-0003Td-Ln for 33394@debbugs.gnu.org; Thu, 15 Nov 2018 06:56:42 -0500 Original-Received: by mail-vs1-f41.google.com with SMTP id g68so11491238vsd.11 for <33394@debbugs.gnu.org>; Thu, 15 Nov 2018 03:56:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZHt7315xrMG3MEPGO86VngAJfpAGSlmmQdZIMHJ+x7E=; b=VCLVHTDBKxtQ6jHK/lxB1+ZQXpd5V3Y1rHfaqd0UV2ZwtUSXsydIgdv8VL5UnXAe6M /oqBZSbm/G/h7LROlQooT8ifmawd7lbdIr8JA6HsBgEr8Xaa8ABzFmTFvPQ3ClDZUBrO bYVRdvIo2Arctc/qxZ1OMVN5lYp4KsW+Mg4jK8HQix9Ui7Sas9eAYoBxOosrH76STyX7 8tlb49QLd7B/0Ty/O7vFheCLE4AgLuDx+G2XsLjez/3GZ8MD3KBn5oe6ZBpnKOfB2WHQ LORN+B91DtnJ/Ay95RlbMU8wleV03PfCdlBdcCiWQv6Q87BuU7sY/SBFVcbz/yFZa07N 0hGA== X-Gm-Message-State: AGRZ1gIulEjwU0hXk0p4AiPByr81ZbZqDgNbLWBv4kT2t3FuIVf2zRZn 9G5EhTjp5wqg0H9gFaZ2eb8EyhBlE74uAN8HWn4= X-Google-Smtp-Source: AJdET5f9vuw91SYnBcOrdab0vZzTTtArpSLr68TOXJTDmih0vD9lHBrL4RjBfeTdK4W4QcGFkLF6MG70dj4TM4nVK4w= X-Received: by 2002:a67:4a96:: with SMTP id e22mr2430505vsg.92.1542282995797; Thu, 15 Nov 2018 03:56:35 -0800 (PST) In-Reply-To: <87tvkifu1q.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152412 Archived-At: --0000000000001b98a9057ab2be23 Content-Type: text/plain; charset="UTF-8" Thanks Michael. On further investigation, I've found that this minimal code (after starting with emacs -Q) produces the same unexpected error: (condition-case nil (emacs-repository-get-branch nil) (error nil)) I don't think I can investigate further as condition-case is not a lisp function. Kind regards Geoff On Thu, 15 Nov 2018 at 11:40, Michael Albinus wrote: > Geoffrey Ferrari writes: > > Hi Geoffrey, > > > The issue can be traced to the definition of tramp-repository-branch > > in > > trampver.el. This calls: > > > > (emacs-repository-get-branch > > (locate-dominating-file (locate-library "tramp") ".git")) > > > > However, (locate-dominating-file (locate-library "tramp") ".git") > > evaluates to nil, meaning that above is equivalent to > > (emacs-repository-get-branch nil). > > > > This causes the function emacs-repository-get-branch (in version.el) > > to > > rely on the variable source-directory i.e. which references the source > > directory where the emacs > > binary was built, which of course does not exist on an end user's > > system. > > Yes. However, the initial value of tramp-repository-branch is > > --8<---------------cut here---------------start------------->8--- > (ignore-errors > ;; Suppress message from `emacs-repository-get-branch'. > (let ((inhibit-message t)) > ;; `emacs-repository-get-branch' has been introduced with Emacs 27.1. > (with-no-warnings > (emacs-repository-get-branch > (locate-dominating-file (locate-library "tramp") ".git"))))) > --8<---------------cut here---------------end--------------->8--- > > I'm wondering why you see an error, although the code is wrapped by > `ignore-errors'. > > Best regards, Michael. > --0000000000001b98a9057ab2be23 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks Michael. On further investiga= tion, I've found that this minimal code (after starting with emacs -Q) = produces the same unexpected error:

(condition-case nil
(e= macs-repository-get-branch nil)
=C2=A0 (error nil))
I don't think I can investigate further as condition-case i= s not a lisp function.

Kind regards

=
Geoff

On Thu, 15 Nov 2018 at 11:40, Michael Albinus <michael.albinus@gmx.de> wrote:
Geoffrey Ferrari <geoffrey.ferrari@oriel.oxon.org= > writes:

Hi Geoffrey,

> The issue can be traced to the definition of tramp-repository-branch > in
> trampver.el. This calls:
>
> (emacs-repository-get-branch
> (locate-dominating-file (locate-library "tramp") ".git&= quot;))
>
> However, (locate-dominating-file (locate-library "tramp") &q= uot;.git")
> evaluates to nil, meaning that above is equivalent to
> (emacs-repository-get-branch nil).
>
> This causes the function emacs-repository-get-branch (in version.el) > to
> rely on the variable source-directory i.e. which references the source=
> directory where the emacs
> binary was built, which of course does not exist on an end user's<= br> > system.

Yes. However, the initial value of tramp-repository-branch is

--8<---------------cut here---------------start------------->8---
=C2=A0 (ignore-errors
=C2=A0 =C2=A0 ;; Suppress message from `emacs-repository-get-branch'. =C2=A0 =C2=A0 (let ((inhibit-message t))
=C2=A0 =C2=A0 =C2=A0 ;; `emacs-repository-get-branch' has been introduc= ed with Emacs 27.1.
=C2=A0 =C2=A0 =C2=A0 (with-no-warnings
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (emacs-repository-get-branch
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(locate-dominating-file (locate-library &= quot;tramp") ".git")))))
--8<---------------cut here---------------end--------------->8---

I'm wondering why you see an error, although the code is wrapped by
`ignore-errors'.

Best regards, Michael.
--0000000000001b98a9057ab2be23--