From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Hassard Newsgroups: gmane.emacs.bugs Subject: bug#17971: 24.3.92; Patch to fix el compression on RHEL/CentOS 7 Date: Wed, 9 Jul 2014 06:56:27 -0700 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=089e010d8d301c62d704fdc31337 X-Trace: ger.gmane.org 1404949608 14505 80.91.229.3 (9 Jul 2014 23:46:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Jul 2014 23:46:48 +0000 (UTC) Cc: 17971@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 10 01:46:38 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X51ZN-00058g-Sy for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Jul 2014 01:46:38 +0200 Original-Received: from localhost ([::1]:34528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X51ZN-0004ce-81 for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Jul 2014 19:46:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4sMu-0002mW-IF for bug-gnu-emacs@gnu.org; Wed, 09 Jul 2014 09:57:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4sMo-0004P5-Fi for bug-gnu-emacs@gnu.org; Wed, 09 Jul 2014 09:57:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4sMo-0004On-BL for bug-gnu-emacs@gnu.org; Wed, 09 Jul 2014 09:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X4sMn-0003Nk-SS for bug-gnu-emacs@gnu.org; Wed, 09 Jul 2014 09:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Hassard Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Jul 2014 13:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17971 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17971-submit@debbugs.gnu.org id=B17971.140491419912988 (code B ref 17971); Wed, 09 Jul 2014 13:57:01 +0000 Original-Received: (at 17971) by debbugs.gnu.org; 9 Jul 2014 13:56:39 +0000 Original-Received: from localhost ([127.0.0.1]:47928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4sMP-0003NQ-Og for submit@debbugs.gnu.org; Wed, 09 Jul 2014 09:56:38 -0400 Original-Received: from mail-ob0-f170.google.com ([209.85.214.170]:34232) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4sMM-0003NG-4g for 17971@debbugs.gnu.org; Wed, 09 Jul 2014 09:56:35 -0400 Original-Received: by mail-ob0-f170.google.com with SMTP id uz6so8165117obc.29 for <17971@debbugs.gnu.org>; Wed, 09 Jul 2014 06:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hassard.net; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=lEU8n70gbNU2QjeXWU2A/z5LMKC8T/0MSg3DyeV0G6U=; b=HiOjDPeFx9KuWIvr3ZqWfaHMqwGSDpfYsdPz9QrG8u59sl9Rt8tV75tfTcGFmcrCPP W3rZIyN7vBdOlGqBTCo7CIzuDh7ZdvSYP3Yeghf/rln2IYSzF3/K1KmE1ccWEVnCUeT0 6DaqCnDm1eyqTwglnZulcNrXC8zKEAmq6s/PA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=lEU8n70gbNU2QjeXWU2A/z5LMKC8T/0MSg3DyeV0G6U=; b=OM59ZUMvZ06+UWKOr95CxUui1+h3rFkwVtO7Eg9owsmTpdWfA6qOUIKjb0MGmcVQuk GNXnlZe3VzAI2HwNYXfLDwr8tCUzYIoWkaR3/OWR3gfen2HSeytfzfnscFJSk53n4HmT BC3VQT+BqN/h5M0cC0ig+68aYRTCBw7zT3m+tsmkRoFxaZLrYbKK8ynUOUqpyWR5SWPC z09dqnyV/bBNSWVATu/feUPa9FXJkELB6fSJjK4NJimEzzCvBPVXGzOm7/u8QW+lviHJ wMVkShsHizjhFlJzAf0gkYQ3XNyLef8aXWS262qX+rrAwFZZWTXdP3kE6tK+cZn0QrGi sZxw== X-Gm-Message-State: ALoCoQnaL0C/TQGOJ4mLSNEJbXww7Cpsqo/0lQwLA7zqnOP0t8BLCr7IWyc9lifOxZHjUd8vR1nn X-Received: by 10.60.78.163 with SMTP id c3mr46794680oex.43.1404914187908; Wed, 09 Jul 2014 06:56:27 -0700 (PDT) Original-Received: by 10.76.114.71 with HTTP; Wed, 9 Jul 2014 06:56:27 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91353 Archived-At: --089e010d8d301c62d704fdc31337 Content-Type: multipart/alternative; boundary=089e010d8d301c62d204fdc31335 --089e010d8d301c62d204fdc31335 Content-Type: text/plain; charset=UTF-8 Here's another update to the patch that more closely follows the behaviour of the original Makefile and now works with a prefix that includes a space. This is tested and works with gnu findutils 4.5.11. On Tue, Jul 8, 2014 at 9:16 PM, Stephen Hassard wrote: > For fun I built a copy of findutils-4.5.12 from alpha.gnu.org and found > that it's suffering the same regression as CentOS's bundled find. > > > On Tue, Jul 8, 2014 at 9:07 PM, Stephen Hassard wrote: > >> It's definitely a regression in CentOS7 vs 6.5. I've built a new 6.5 VM >> and have confirmed that it compresses the .el files without problem. >> >> It seems to be a regression in the bundled findutils. I've pulled in the >> find binary from CentOS 6.5 onto my CentOS 7 VM and the 'make install' >> process completed without problems with the old find. >> >> The version are: >> >> CentOS 7: >> findutils-4.5.11-3 >> >> CentOS 6.5: >> findutils-4.4.2-6 >> >> >> >> >> On Tue, Jul 8, 2014 at 6:10 PM, Glenn Morris wrote: >> >>> Stephen Hassard wrote: >>> >>> > Here's the relevant output from the 'make install' on CentOS 7: >>> > >>> > ---- >>> > [ -z "/usr/bin/gzip" ] || { \ >>> > echo "Compressing *.el ..." && \ >>> > cd "/home/shassard/opt/emacs/share/emacs/24.3.92/lisp" && \ >>> > find . -name '*.elc' -exec /bin/sh -c \ >>> > '/usr/bin/gzip -9n `expr "$1" : "\\(.*\\)c"`' dummy '{}' ';'; \ >>> > } >>> > Compressing *.el ... >>> > find: './progmodes/make-mode.el': No such file or directory >>> >>> Do you know why this happens? >>> What has changed since RHEL6, where it works fine? >>> >>> > I've attached a revised patch that adds the -9n flag to the gzip >>> command >>> > and switch back to -exec for find. >>> >>> This fails if DESTDIR contains spaces. >>> >> >> > --089e010d8d301c62d204fdc31335 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Here's another update to the patch that more clos= ely follows the behaviour of the original Makefile and now works with a pre= fix that includes a space.

This is tested and works with gnu f= indutils 4.5.11.


On Tue,= Jul 8, 2014 at 9:16 PM, Stephen Hassard <steve@hassard.net>= wrote:
For fun I built a copy of f= indutils-4.5.12 from alp= ha.gnu.org and found that it's suffering the same regression as Cen= tOS's bundled find.


On Tue, Jul 8, 2014 at 9:07 PM, Stephen = Hassard <steve@hassard.net> wrote:
It's definitely a r= egression in CentOS7 vs 6.5. I've built a new 6.5 VM and have confirmed= that it compresses the .el files without problem.

It see= ms to be a regression in the bundled findutils. I've pulled in the find= binary from CentOS 6.5 onto my CentOS 7 VM and the 'make install' = process completed without problems with the old find.

The version are:

CentOS 7:
findutils-4.5.11= -3

CentOS 6.5:
findutils-4.4.2-6

<= br>


On Tue, Jul 8, 2014 at 6:10 PM, Glenn Mo= rris <rgm@gnu.org> wrote:
Stephen Hassard wrote:

> Here's the relevant output from the 'make install' on Cent= OS 7:
>
> ----
> [ -z "/usr/bin/gzip" ] || { \
> =C2=A0 echo "Compressing *.el ..." && \
> =C2=A0 cd "/home/shassard/opt/emacs/share/emacs/24.3.92/lisp"= ; && \
> =C2=A0 find . -name '*.elc' -exec /bin/sh -c \
> =C2=A0 =C2=A0 '/usr/bin/gzip -9n `expr "$1" : "\\(.= *\\)c"`' dummy '{}' ';'; \
> }
> Compressing *.el ...
> find: './progmodes/make-mode.el': No such file or directory
Do you know why this happens?
What has changed since RHEL6, where it works fine?

> I've attached a revised patch that adds the -9n flag to the gzip c= ommand
> and switch back to -exec for find.

This fails if DESTDIR contains spaces.



--089e010d8d301c62d204fdc31335-- --089e010d8d301c62d704fdc31337 Content-Type: text/x-diff; charset=US-ASCII; name="0001-Fix-regression-in-findutils-4.5.patch" Content-Disposition: attachment; filename="0001-Fix-regression-in-findutils-4.5.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hxepo6qn0 RnJvbSBlNWFiZjNmYzUyOTgwYmM1NDk4NGI4ZTIyOGQ0MWM3MTc3YzZlM2JiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVwaGVuIEhhc3NhcmQgPHN0ZXZlQGhhc3NhcmQubmV0PgpE YXRlOiBXZWQsIDkgSnVsIDIwMTQgMDY6NTQ6NDYgLTA3MDAKU3ViamVjdDogW1BBVENIXSBGaXgg cmVncmVzc2lvbiBpbiBmaW5kdXRpbHMtNC41CgotLS0KIE1ha2VmaWxlLmluIHwgNSArKystLQog MSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9NYWtlZmlsZS5pbiBiL01ha2VmaWxlLmluCmluZGV4IDc2YTAzMDQuLjk3MDAyZTQgMTAw NjQ0Ci0tLSBhL01ha2VmaWxlLmluCisrKyBiL01ha2VmaWxlLmluCkBAIC02MTUsOCArNjE1LDkg QEAgaW5zdGFsbC1hcmNoLWluZGVwOiBsaXNwIGluc3RhbGwtaW5mbyBpbnN0YWxsLW1hbiAke0lO U1RBTExfQVJDSF9JTkRFUF9FWFRSQX0KIAlbIC16ICIke0daSVBfUFJPR30iIF0gfHwgeyBcCiAJ ICBlY2hvICJDb21wcmVzc2luZyAqLmVsIC4uLiIgJiYgXAogCSAgY2QgIiQoREVTVERJUikke2xp c3BkaXJ9IiAmJiBcCi0JICBmaW5kIC4gLW5hbWUgJyouZWxjJyAtZXhlYyAkKFNIRUxMKSAtYyBc Ci0JICAgICcke0daSVBfUFJPR30gLTluIGBleHByICIkJDEiIDogIlxcKC4qXFwpYyJgJyBkdW1t eSAne30nICc7JzsgXAorCSAgZmluZCAuIC1uYW1lICcqLmVsJyBcCisJICAgIC1leGVjICR7U0hF TEx9IC1jICd0ZXN0IC1mIHt9YycgXDsgXAorCSAgICAtZXhlYyAke0daSVBfUFJPR30gLTluIHt9 IFw7IDsgXAogCX0KIAktY2htb2QgLVIgYStyICIkKERFU1RESVIpJHtkYXRhZGlyfS9lbWFjcy8k e3ZlcnNpb259IiAke0NPUFlERVNUU30KIAotLSAKMS44LjMuMQoK --089e010d8d301c62d704fdc31337--