From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Petko Bordjukov Newsgroups: gmane.emacs.bugs Subject: bug#31760: 26.1; ruby-mode enables flymake-rubocop by default if the rubocop executable exists Date: Sat, 16 Jun 2018 22:54:19 +0300 Message-ID: References: <87k1r972fp.wl-bordjukov@gmail.com> <87po11i0he.fsf@gmail.com> <83d8f202-8842-56fe-0350-5f2fa9a01d67@yandex.ru> <87602ihhmi.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1529178787 3351 195.159.176.226 (16 Jun 2018 19:53:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Jun 2018 19:53:07 +0000 (UTC) Cc: Bozhidar Batsov , 31760@debbugs.gnu.org, Dmitry Gutov To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 16 21:53:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUHFu-0000iH-0N for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Jun 2018 21:53:02 +0200 Original-Received: from localhost ([::1]:52676 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUHI1-0007yk-37 for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Jun 2018 15:55:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUHHt-0007yS-Tp for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 15:55:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUHHq-0003R1-K5 for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 15:55:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44216) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fUHHq-0003Qt-Ex for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 15:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fUHHq-0006qW-2N for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 15:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Petko Bordjukov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jun 2018 19:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31760 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31760-submit@debbugs.gnu.org id=B31760.152917886726272 (code B ref 31760); Sat, 16 Jun 2018 19:55:02 +0000 Original-Received: (at 31760) by debbugs.gnu.org; 16 Jun 2018 19:54:27 +0000 Original-Received: from localhost ([127.0.0.1]:52113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUHHH-0006pg-FA for submit@debbugs.gnu.org; Sat, 16 Jun 2018 15:54:27 -0400 Original-Received: from mail-qt0-f176.google.com ([209.85.216.176]:41406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUHHF-0006pS-QV for 31760@debbugs.gnu.org; Sat, 16 Jun 2018 15:54:26 -0400 Original-Received: by mail-qt0-f176.google.com with SMTP id y20-v6so12074230qto.8 for <31760@debbugs.gnu.org>; Sat, 16 Jun 2018 12:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=U9AdSYtDZPFiSj112ZdG0WQha6PJ9nYGZt/8FoaT+0c=; b=E5+Km/7Bw+32UsoAZwwKCbtjN68TuswKSBlvUTzSMx0pHIGzDBj26+1XtO7fPexP+n NNfLDVMN7QphfvsxWis6EMWRfub7Vyh1UM/Ae4bA8kHiP0SpDFd6qQTd/P/WWn+neXCR PTI3cBUVE1qLXX+MnCrppL+fdrZ39l6Ug3TRO3NTVOHSHwuMV6KwEj0vKNvPcq6QB92I kZYhvCmjr65naDzCFnlO1r1Ydtoj/95W5RyXsAKimyJcThOQhtDIz2WVLo8+RBavowNg itKc9KYLgXwwu/vZ+Koy82O0Iw3S2eDHd7KEC+u1NqGld/JazWWa9LBPRlN1zqM8SwWx lXXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=U9AdSYtDZPFiSj112ZdG0WQha6PJ9nYGZt/8FoaT+0c=; b=Yon2/Olz08+fXTApfGUPQhuch6+I1btoSHYoV27pVr5fEasqDsiCe8aCB6t8cXP6nh hm0FgjjUZBB23ibAsl5IHm2kE6INuk1hEscI9pj6zMuifUgjtD5JrSsADhICB7BG49gH I7NyhPiKeFQ3+09e0H2euxiI6QyA7kffC7E7HkUzLEGJBMydANZQWnTC43nc5WNAX1Fn UDJUxsjwURAL2jRm2AM6V/pXg9pjgal8VH+vNTKbemeQdejmCxCsrryIKFqUB2nu2TzC gdaesUu2C54dvBIMlUzv+7sEqp5N4FHMP7wo+8cRTlVkZPCwEcRtXQW2PKeRvMK76FXd jk0g== X-Gm-Message-State: APt69E3QuK7dqW9Vopwozte9ejB+9WeazQJFz/IpKkUs1EvaKXkKWWTr OSgx866K8gAoaHkjj0VqG2xHYSsliZ7sGb5QQao= X-Google-Smtp-Source: ADUXVKIeLiBJZz206u3jIJqGN/C4nrw2xvXGnk2mCxPOKd6m6i+YG0HXYa1FD9Wsj2eKO8eC6hhPDZ8I886UwZXkiTE= X-Received: by 2002:ac8:2c23:: with SMTP id d32-v6mr6032374qta.54.1529178860401; Sat, 16 Jun 2018 12:54:20 -0700 (PDT) Original-Received: by 2002:aed:26a4:0:0:0:0:0 with HTTP; Sat, 16 Jun 2018 12:54:19 -0700 (PDT) In-Reply-To: <87602ihhmi.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147536 Archived-At: > I'd just like to chime in briefly with two points: Thank you for the advice, Jo=C3=A3o. If it's decided on not flipping the default, I will probably implement the change for myself. Considering many projects that have adopted RuboCop specify their own configuration in their roots, I'd probably check and enable in such cases and leave the rest for .dir-locals.el. Cheers, P. On Sat, Jun 16, 2018 at 6:32 PM, Jo=C3=A3o T=C3=A1vora wrote: > Petko Bordjukov writes: > >> Again, I appreciate this feature, but do not leave it on by default -- >> it will be just another bad Emacs default. >> > > I'd just like to chime in briefly with two points: > > * IMO Petko has a point: Emacs is expected to be conservative about > tooling support: unless some optional tool is widely adopted, optional > things are made... err... optional. Of course this is for some value > of "widely adpted"; one that the maintainer of said tool probably has > a particularly generous conception of, ehehe. > > There was little discussion on this before 26.1 because it was all > kinda rushed, because Dmitry is the maintainer of ruby-mode, and most > importantly, nobody objected (much less I, who welcomed the enthusiasm > for using the new API). So even though Emacs 26.1 is a month old, the > conservative stance is now to keep default. > > * On the practical front, I personally dislike defcustom and prefer > having flymake backends separate, so instead of having > ruby-flymake-auto checks the defcustom, I advise Petko to use a > directory-local variable in the project configuring > flymake-diagnostic-functions to either ruby-flymake-simple or > ruby-flymake-rubocop, i.e. some .dir-locals.el containing this > > (... > (ruby-mode . (... > (flymake-diagnostic-functions ruby-flymake-simple) > ...)) > ...) > > Won't this suffice as a per-project (almost zero) configuration? > > Jo=C3=A3o > >