From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#9722: list-colors-duplicates does not exclude enough colors on Windows Date: Tue, 11 Oct 2011 13:24:04 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1318332359 16786 80.91.229.12 (11 Oct 2011 11:25:59 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 11 Oct 2011 11:25:59 +0000 (UTC) Cc: 9722@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 11 13:25:55 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RDaT3-0005Wm-Kk for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Oct 2011 13:25:53 +0200 Original-Received: from localhost ([::1]:54492 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDaT3-0002kL-2R for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Oct 2011 07:25:53 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:54422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDaT0-0002jO-39 for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2011 07:25:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RDaSw-00038j-2b for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2011 07:25:50 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDaSw-00038f-0t for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2011 07:25:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RDaTC-0002d3-Ac for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2011 07:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Oct 2011 11:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9722 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9722-submit@debbugs.gnu.org id=B9722.131833230910041 (code B ref 9722); Tue, 11 Oct 2011 11:26:02 +0000 Original-Received: (at 9722) by debbugs.gnu.org; 11 Oct 2011 11:25:09 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDaSL-0002bu-AF for submit@debbugs.gnu.org; Tue, 11 Oct 2011 07:25:09 -0400 Original-Received: from mail-qw0-f44.google.com ([209.85.216.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDaSI-0002bO-Im for 9722@debbugs.gnu.org; Tue, 11 Oct 2011 07:25:07 -0400 Original-Received: by qadb12 with SMTP id b12so4905251qad.3 for <9722@debbugs.gnu.org>; Tue, 11 Oct 2011 04:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=Nr1I1nIsokPfj+33LSENzHAhzhoOi0s3o8hlp3DVbs0=; b=rYbF75tkzIwH+mC4pW9EtWORVpnDtip90/oyAkCfkFnKUkGJGVhv84oWDirJOLCCxW Bym4gK02iZnQuJAjUXfTY1RZ2pOi6KOV2IrKZr1zLD6beWXmgFlDdivXEIBWmk2pQi2H a/tEgkbXVCItfwxg3CUoEA5zHt24j7mz+qPwY= Original-Received: by 10.68.13.35 with SMTP id e3mr44776385pbc.31.1318332284068; Tue, 11 Oct 2011 04:24:44 -0700 (PDT) Original-Received: by 10.142.194.3 with HTTP; Tue, 11 Oct 2011 04:24:04 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 11 Oct 2011 07:26:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:52514 Archived-At: On Tue, Oct 11, 2011 at 08:01, Eli Zaretskii wrote: > However, there's something I'm missing here: why doesn't > list-colors-duplicates recognize grayNN and greyNN as duplicates? > We don't have them in the list that w32-default-color-map returns. That's why. The System* colors aren't either. What the current code does on Windows is, basically, to detect duplicates when this (and (facemenu-color-equal COLOR1 COLOR2) (assoc COLOR1 (w32-default-color-map))) is true. I.e., COLOR1 is only checked if present in the default color list (which, I'm sure you remember, is the one hardcoded in w32fns.c, not the one from etc/rgb.txt). > As for duplicates such as "Dark Slate Gray" and "Dark Slate Grey", > which are not filtered out because they _are_ in > w32-default-color-map I'm not sure I understand. The dark*slate*gr?y colors are in the list, and so they are detected as duplicates. > would something break if we modify the list > returned by that function to not include any duplicates in the first > place? I don't think any code would break, but you would need to add the missing names at some other point, woudn't you? =C2=A0 =C2=A0 Juanma