From: Juanma Barranquero <lekktu@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 9722@debbugs.gnu.org
Subject: bug#9722: list-colors-duplicates does not exclude enough colors on Windows
Date: Tue, 11 Oct 2011 13:24:04 +0200 [thread overview]
Message-ID: <CAAeL0STySjChtY4Tdt8HJtnMf56WLySdBgnVGzgRWiutT3qc8g@mail.gmail.com> (raw)
In-Reply-To: <E1RDVPB-0000HK-FA@fencepost.gnu.org>
On Tue, Oct 11, 2011 at 08:01, Eli Zaretskii <eliz@gnu.org> wrote:
> However, there's something I'm missing here: why doesn't
> list-colors-duplicates recognize grayNN and greyNN as duplicates?
> We don't have them in the list that w32-default-color-map returns.
That's why. The System* colors aren't either. What the current code
does on Windows is, basically, to detect duplicates when this
(and (facemenu-color-equal COLOR1 COLOR2)
(assoc COLOR1 (w32-default-color-map)))
is true. I.e., COLOR1 is only checked if present in the default color
list (which, I'm sure you remember, is the one hardcoded in w32fns.c,
not the one from etc/rgb.txt).
> As for duplicates such as "Dark Slate Gray" and "Dark Slate Grey",
> which are not filtered out because they _are_ in
> w32-default-color-map
I'm not sure I understand. The dark*slate*gr?y colors are in the list,
and so they are detected as duplicates.
> would something break if we modify the list
> returned by that function to not include any duplicates in the first
> place?
I don't think any code would break, but you would need to add the
missing names at some other point, woudn't you?
Juanma
next prev parent reply other threads:[~2011-10-11 11:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 22:49 bug#9722: list-colors-duplicates does not exclude enough colors on Windows Juanma Barranquero
2011-10-11 6:01 ` Eli Zaretskii
2011-10-11 11:24 ` Juanma Barranquero [this message]
2011-10-11 19:39 ` Eli Zaretskii
2011-10-11 20:54 ` Juanma Barranquero
2011-10-17 12:00 ` Juanma Barranquero
2011-10-17 16:41 ` Eli Zaretskii
2011-10-17 16:55 ` Juanma Barranquero
2011-10-17 17:15 ` Eli Zaretskii
2011-10-18 14:50 ` Juanma Barranquero
[not found] ` <83obxeuwa8.fsf@gnu.org>
[not found] ` <CAAeL0SRRkqY2r6QwASsb1JVdeSfTd9UDz3RY5QTx-PHME2iZsQ@mail.gmail.com>
[not found] ` <83k482ut21.fsf@gnu.org>
2011-10-18 19:25 ` Juanma Barranquero
2011-10-18 21:01 ` Eli Zaretskii
2011-10-24 19:29 ` Juanma Barranquero
2011-10-19 8:20 ` Juri Linkov
2011-10-19 8:36 ` Eli Zaretskii
2011-10-19 8:57 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAeL0STySjChtY4Tdt8HJtnMf56WLySdBgnVGzgRWiutT3qc8g@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=9722@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).