From: Juanma Barranquero <lekktu@gmail.com>
To: Daniel Colascione <dancol@dancol.org>
Cc: 10397@debbugs.gnu.org
Subject: bug#10397: [PATCH] Under Remote Desktop, NUMCOLORS is unreliable; workaround
Date: Thu, 29 Dec 2011 17:13:25 +0100 [thread overview]
Message-ID: <CAAeL0STx_Ayi_GjRtheqbXBrdtBh9-Xa_5JZORxtE-c+KrxzgA@mail.gmail.com> (raw)
In-Reply-To: <69c9ec930ef1d48655624d437aa66d0fce275d3e.1325166766.git.dancol@dancol.org>
On Thu, Dec 29, 2011 at 15:05, Daniel Colascione <dancol@dancol.org> wrote:
> The workaround
> seems harmless: on non-palettized displays, calculating the number of
> display colors based on display bitness should produce good results.
Even so, why fix what is not broken? Why can't you just do
=== modified file 'src/w32fns.c'
--- src/w32fns.c 2011-12-04 08:02:42 +0000
+++ src/w32fns.c 2011-12-29 16:10:33 +0000
@@ -4511,5 +4511,12 @@
cap = GetDeviceCaps (hdc, SIZEPALETTE);
else
- cap = GetDeviceCaps (hdc, NUMCOLORS);
+ {
+ cap = GetDeviceCaps (hdc, NUMCOLORS);
+ /* GetDeviceCaps (NUMCOLORS) is buggy under remote desktop and
+ sometimes returns the number of system reserved colors (20)
+ instead of the actual number of available colors. */
+ if (cap == 20)
+ cap = -1;
+ }
/* We force 24+ bit depths to 24-bit, both to prevent an overflow
> + // GetDeviceCaps (NUMCOLORS) is buggy under remote desktop and sometimes
> + // returns the number of system reserved colors (20) instead of
> + // the actual number of available colors.
Please, don't use "C++ / modern C" style comments; use /* */ instead.
Juanma
next prev parent reply other threads:[~2011-12-29 16:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 14:05 bug#10397: [PATCH] Under Remote Desktop, NUMCOLORS is unreliable; workaround Daniel Colascione
2011-12-29 16:13 ` Juanma Barranquero [this message]
2011-12-29 16:23 ` Daniel Colascione
2011-12-29 16:27 ` Juanma Barranquero
2011-12-29 16:42 ` Daniel Colascione
2011-12-29 16:45 ` Juanma Barranquero
2011-12-29 22:59 ` Daniel Colascione
2011-12-29 23:10 ` Juanma Barranquero
2011-12-29 23:13 ` Daniel Colascione
2011-12-29 23:18 ` Juanma Barranquero
2011-12-30 3:07 ` Juanma Barranquero
2011-12-30 3:18 ` Daniel Colascione
2011-12-30 8:51 ` Eli Zaretskii
2011-12-30 9:00 ` Eli Zaretskii
2011-12-30 12:24 ` Juanma Barranquero
2012-08-07 17:13 ` Eli Zaretskii
2012-08-07 17:33 ` Daniel Colascione
2012-08-07 18:07 ` Eli Zaretskii
2016-02-25 6:25 ` Lars Ingebrigtsen
2016-12-13 0:04 ` Glenn Morris
2011-12-30 1:04 ` Jason Rumney
2011-12-30 1:10 ` Daniel Colascione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAeL0STx_Ayi_GjRtheqbXBrdtBh9-Xa_5JZORxtE-c+KrxzgA@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=10397@debbugs.gnu.org \
--cc=dancol@dancol.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).