unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juanma Barranquero <lekktu@gmail.com>
To: Kevin Ryde <user42@zip.com.au>
Cc: 5327-done@debbugs.gnu.org
Subject: bug#5327: 23.1; unload-feature-special-hooks add fill-nobreak-predicate
Date: Mon, 11 Jul 2011 18:25:01 +0200	[thread overview]
Message-ID: <CAAeL0STik2dwgh64a3Y8GOON+68O9EzQ1enBz8J81AzMPHs1yw@mail.gmail.com> (raw)
In-Reply-To: <87eim4t95o.fsf@blah.blah>

On Wed, Jan 6, 2010 at 00:38, Kevin Ryde <user42@zip.com.au> wrote:

>    M-x sgml-mode
>    M-x unload-feature sgml-mode
>    type in a long line to be filled
>    M-q
>    => Symbol's function definition is void: sgml-fill-nobreak

`fill-nobreak-predicate' was set locally, so it would be removed when
the mode for the buffer was changed. Previously, `unload-feature'
failed to do so unless the mode package's FEATURE-unload-function,
assuming one existed, did by itself. Since revno:104702
`unload-feature' does so automatically, so the above case should work
(i.e, unloading sgml-mode will change the buffer's major mode to
text-mode).

That said, I'll add that variable and some of the others you mentioned
to `unload-feature-special-hooks' because it's better to be safe than
sorry. But, what would be nice is some way to identify hook variables
in a generic way, instead of special-casing still more of them. :-(

>   find-directory-functions
>   auto-coding-functions

OK.

>   compile-command-default-functions

I cannot find that one in the Emacs sources.

    Juanma





  parent reply	other threads:[~2011-07-11 16:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-05 23:38 bug#5327: 23.1; unload-feature-special-hooks add fill-nobreak-predicate Kevin Ryde
2010-01-06  1:30 ` Juanma Barranquero
2010-01-08 21:28   ` Kevin Ryde
2011-07-11 16:25 ` Juanma Barranquero [this message]
2011-07-16  1:52   ` Kevin Ryde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAeL0STik2dwgh64a3Y8GOON+68O9EzQ1enBz8J81AzMPHs1yw@mail.gmail.com \
    --to=lekktu@gmail.com \
    --cc=5327-done@debbugs.gnu.org \
    --cc=user42@zip.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).