From: Juanma Barranquero <lekktu@gmail.com>
To: Stephen Leake <stephen_leake@stephe-leake.org>
Cc: 21930@debbugs.gnu.org
Subject: bug#21930: emacs-repository-get-version fails on linked worktrees
Date: Tue, 17 Nov 2015 01:20:15 +0100 [thread overview]
Message-ID: <CAAeL0STfc5GTZn5PpoBv+kwwBCAaSoyzcCw7erZXNYjBKmH57Q@mail.gmail.com> (raw)
In-Reply-To: <867flha6qv.fsf@stephe-leake.org>
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
On Tue, Nov 17, 2015 at 12:01 AM, Stephen Leake <
stephen_leake@stephe-leake.org> wrote:
> I'm guessing because running any background process doesn't work during
> dumping; they don't work in general in batch mode.
The code refers to bug#20799, which states that git (and other external
processes) cannot be run while dumping because `exec-path' is nil.
So the function, to be usable on a linked worktree while dumping, needs to
directly read the .git file. That's what my patch does. Calls to
`emacs-repository-get-version' with EXTERNAL = t already work (when not
dumping) without my patch, of course.
> Looks good to me.
Great.
[-- Attachment #2: Type: text/html, Size: 851 bytes --]
next prev parent reply other threads:[~2015-11-17 0:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 3:46 bug#21930: emacs-repository-get-version fails on linked worktrees Juanma Barranquero
2015-11-16 23:01 ` Stephen Leake
2015-11-17 0:20 ` Juanma Barranquero [this message]
2015-11-19 18:17 ` Juanma Barranquero
2015-11-19 19:03 ` John Wiegley
2015-11-20 0:40 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAeL0STfc5GTZn5PpoBv+kwwBCAaSoyzcCw7erZXNYjBKmH57Q@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=21930@debbugs.gnu.org \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).