* bug#14639: package-initialize not run
@ 2013-06-17 2:34 Juanma Barranquero
2013-06-17 13:35 ` Juanma Barranquero
2013-06-17 14:45 ` Stefan Monnier
0 siblings, 2 replies; 4+ messages in thread
From: Juanma Barranquero @ 2013-06-17 2:34 UTC (permalink / raw)
To: 14639
Package: emacs
Version: 24.3.50
X-Debbugs-CC: monnier@iro.umontreal.ca
package-initialize is not being run because the code to detect
description files does
(when (let ((subdir (expand-file-name subdir dir)))
(and (file-directory-p subdir)
(file-exists-p
(package--description-file subdir))))
(throw 'package-dir-found t)))))))
but package--description-file does not return an absolute filename, so
file-exists-p fails.
Either this patch is needed,
=== modified file 'lisp/startup.el'
--- lisp/startup.el 2013-06-15 15:36:11 +0000
+++ lisp/startup.el 2013-06-17 02:21:06 +0000
@@ -1204,5 +1204,7 @@
(and (file-directory-p subdir)
(file-exists-p
- (package--description-file subdir))))
+ (expand-file-name
+ (package--description-file subdir)
+ subdir))))
(throw 'package-dir-found t)))))))
(package-initialize))
or modifying package--description-file to return an absolute path.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#14639: package-initialize not run
2013-06-17 2:34 bug#14639: package-initialize not run Juanma Barranquero
@ 2013-06-17 13:35 ` Juanma Barranquero
2013-06-17 14:45 ` Stefan Monnier
1 sibling, 0 replies; 4+ messages in thread
From: Juanma Barranquero @ 2013-06-17 13:35 UTC (permalink / raw)
To: 14639
On Mon, Jun 17, 2013 at 4:34 AM, Juanma Barranquero <lekktu@gmail.com> wrote:
> or modifying package--description-file to return an absolute path.
--- lisp/startup.el 2013-06-15 15:36:11 +0000
+++ lisp/startup.el 2013-06-17 13:34:39 +0000
@@ -423,5 +423,6 @@
(defun package--description-file (dir)
- (concat (let ((subdir (file-name-nondirectory
+ (concat (file-name-as-directory dir)
+ (let ((subdir (file-name-nondirectory
(directory-file-name dir))))
(if (string-match
"\\([^.].*?\\)-\\([0-9]+\\(?:[.][0-9]+\\|\\(?:pre\\|beta\\|alpha\\)[0-9]+\\)*\\)"
subdir)
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#14639: package-initialize not run
2013-06-17 2:34 bug#14639: package-initialize not run Juanma Barranquero
2013-06-17 13:35 ` Juanma Barranquero
@ 2013-06-17 14:45 ` Stefan Monnier
2013-06-17 15:36 ` Juanma Barranquero
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2013-06-17 14:45 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: 14639
> - (package--description-file subdir))))
> + (expand-file-name
> + (package--description-file subdir)
> + subdir))))
Looks good (if you grep a bit, you'll see there are calls to
package--description-file which need a relative file name, because it's
used to find a file in a tar archive rather than in the file-system).
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#14639: package-initialize not run
2013-06-17 14:45 ` Stefan Monnier
@ 2013-06-17 15:36 ` Juanma Barranquero
0 siblings, 0 replies; 4+ messages in thread
From: Juanma Barranquero @ 2013-06-17 15:36 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 14639-done
On Mon, Jun 17, 2013 at 4:45 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
> Looks good (if you grep a bit, you'll see there are calls to
> package--description-file which need a relative file name, because it's
> used to find a file in a tar archive rather than in the file-system).
I see.
Committed in revno:113021
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-17 15:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-17 2:34 bug#14639: package-initialize not run Juanma Barranquero
2013-06-17 13:35 ` Juanma Barranquero
2013-06-17 14:45 ` Stefan Monnier
2013-06-17 15:36 ` Juanma Barranquero
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).