From: Juanma Barranquero <lekktu@gmail.com>
To: Alan Mackenzie <acm@muc.de>
Cc: 2932@debbugs.gnu.org
Subject: bug#2932: call-interactively wrongly calls mouse-leave-buffer-hook
Date: Sun, 10 Jul 2011 02:00:41 +0200 [thread overview]
Message-ID: <CAAeL0STAe16NXdFttUBJ236EjvyaifGuA6nKZSTWywzY7Us_Sg@mail.gmail.com> (raw)
In-Reply-To: <20090408211553.GA2627@muc.de>
On Wed, Apr 8, 2009 at 23:15, Alan Mackenzie <acm@muc.de> wrote:
> In call-interactively (callint.c L~449), whilst processing `@' ("switch
> to the window the mouse was clicked in") in an interactive string, the
> code runs the hook `mouse-leave-buffer-hook'.
>
> The code HASN'T CHECKED that this new window is different from the
> current window, and even if it is, whether the new window is displaying
> a different buffer. Hence the hook is wrongly invoked when the mouse is
> clicked in the current window.
The trunk still behaves as you describe.
As a first pass, we should fix the docstring of
`mouse-leave-buffer-hook'. It seems wrong for the docstring of a hook
with "leave-buffer" in its name to talk about windows and not say a
word about buffers...
Juanma
next prev parent reply other threads:[~2011-07-10 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 21:15 bug#2932: call-interactively wrongly calls mouse-leave-buffer-hook Alan Mackenzie
2011-07-10 0:00 ` Juanma Barranquero [this message]
2011-09-18 8:17 ` Lars Magne Ingebrigtsen
2021-07-19 14:42 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAeL0STAe16NXdFttUBJ236EjvyaifGuA6nKZSTWywzY7Us_Sg@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=2932@debbugs.gnu.org \
--cc=acm@muc.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).