bug#36241: 26.2; documentation error in elisp/Regexp-Functions node

bug#36241: 26.2; documentation error in elisp/Regexp-Functions node

[Mandar Mitra]

The documentation under "Function: regexp-opt" says:


The resulting regexp of regexp-opt is equivalent to but usually more efficient than that of a simplified version: 

 (defun simplified-regexp-opt (strings &optional paren)
           (let ((parens
                  (cond
                   ((stringp paren)       (cons paren "\\)"))
                   ((eq paren 'words)    '("\\<\\(" . "\\)\\>"))
                   ((eq paren 'symbols) '("\\_<\\(" . "\\)\\_>"))
                   ((null paren)          '("\\(?:" . "\\)"))
                   (t                       '("\\(" . "\\)")))))
             (concat (car paren) ;; BUG: should be parens, not paren?
                     (mapconcat 'regexp-quote strings "\\|")
                     (cdr paren)))) ;; BUG: should be parens, not paren?

---------------------------------------------------------------------------

The expressions on the third last line and the last line should be (car parens) and (cdr parens), no?

---------------------------------------------------------------------------

In GNU Emacs 26.2 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.30)
 of 2019-04-13 built on lgw01-amd64-060
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description:	Linux Mint 19 Tara

Recent messages:
Describe-Bindings...
Type M-x delete-other-windows to delete the help window, C-M-v to scroll help.
Quit [2 times]
Describe-Function...
No library info.el in search path
Type M-x delete-other-windows to delete the help window.
Fill column set to 75 (was 70)
Invalid face reference: info-menu-5 [3 times]
Mark set
Invalid face reference: info-menu-5 [14 times]

Configured using:
 'configure --build=x86_64-linux-gnu --prefix=/usr '--includedir=${prefix}/include' '--mandir=${prefix}/share/man' '--infodir=${prefix}/share/info' --sysconfdir=/etc --localstatedir=/var --disable-silent-rules '--libdir=${prefix}/lib/x86_64-linux-gnu' '--libexecdir=${prefix}/lib/x86_64-linux-gnu' --disable-maintainer-mode --disable-dependency-tracking --prefix=/usr --sharedstatedir=/var/lib --program-suffix=26 --with-modules --with-file-notification=inotify --with-mailutils --with-x=yes --with-x-toolkit=gtk3 --with-xwidgets --with-lcms2 'CFLAGS=-g -O2 -fdebug-prefix-map=/build/emacs26-CYbeHB/emacs26-26.2~1.gitfd1b34b=. -fstack-protector-strong -Wformat -Werror=format-security -no-pie' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' 'LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro -no-pie''

bug#36241: 26.2; documentation error in elisp/Regexp-Functions node

[Juanma Barranquero]

On Sun, Jun 16, 2019 at 10:53 AM Mandar Mitra <mandar.mitra@gmail.com> wrote:

> The expressions on the third last line and the last line should be (car parens) and (cdr parens), no?

Yes, thanks.

It was fixed in the sources a while ago and it's already correct in
26.2.90, the current pretest release for 26.3.

You can download a source tarball of 26.2.90 here:
https://alpha.gnu.org/gnu/emacs/pretest/

bug#36241: 26.2; documentation error in elisp/Regexp-Functions node

[Juanma Barranquero]

Sorry, my bad.

You were talking about the info documentation, which is indeed not
fixed, not about the function's docstring (which is).

bug#36241: 26.2; documentation error in elisp/Regexp-Functions node

[Juanma Barranquero]

Ok, I backported the fix already in the master branch, so it should be
fixed now.

Thanks