From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#16993: advice-add hides docstring Date: Thu, 20 Mar 2014 06:18:01 +0100 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1395292751 18498 80.91.229.3 (20 Mar 2014 05:19:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Mar 2014 05:19:11 +0000 (UTC) Cc: 16993@debbugs.gnu.org To: Stefan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 20 06:19:19 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WQVNt-0006vx-Kx for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Mar 2014 06:19:17 +0100 Original-Received: from localhost ([::1]:45245 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQVNt-000579-34 for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Mar 2014 01:19:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQVNm-00055s-0X for bug-gnu-emacs@gnu.org; Thu, 20 Mar 2014 01:19:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQVNe-0007w6-Dt for bug-gnu-emacs@gnu.org; Thu, 20 Mar 2014 01:19:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQVNe-0007w2-9k for bug-gnu-emacs@gnu.org; Thu, 20 Mar 2014 01:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WQVNe-0006rA-2D for bug-gnu-emacs@gnu.org; Thu, 20 Mar 2014 01:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Mar 2014 05:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.139529272426328 (code B ref 16993); Thu, 20 Mar 2014 05:19:02 +0000 Original-Received: (at 16993) by debbugs.gnu.org; 20 Mar 2014 05:18:44 +0000 Original-Received: from localhost ([127.0.0.1]:41801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQVNM-0006qa-4I for submit@debbugs.gnu.org; Thu, 20 Mar 2014 01:18:44 -0400 Original-Received: from mail-yk0-f170.google.com ([209.85.160.170]:53304) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQVNK-0006qQ-HT for 16993@debbugs.gnu.org; Thu, 20 Mar 2014 01:18:43 -0400 Original-Received: by mail-yk0-f170.google.com with SMTP id 9so1004333ykp.1 for <16993@debbugs.gnu.org>; Wed, 19 Mar 2014 22:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=kNeKPWfJSLtGu/77yqoSenKdCUf8VCpJMYBz1pgbKlw=; b=qC059x1TTSi3GvO5rs11QlZzfPUOjjtIYIxMw3Tndb9aL0kpVsao5J41G7oh8Ss2mh 3cmKr8lD5Kyey+dcLTMFJcSZC+8FyC69Y3BpRiy337V+XSXnRSpQ/1Tvol1SyOZfR8kt KkU9lTWgXNENWUGSrv7FM2cLFre85QcFi1GEZ1VcWwYkrmvAT8E7dQxghPvEn9pmqQsN /a2cncQzvdW8nSy57x82YV76XACzz0m2c5Nrskwh9xDuZCLafGVYI0rHWQ4BYZYBrHax 8EIt10O91iBSdbMh2ZJho5dIAUefxDt0F3Y57IbY2/VCmealtTfSP+Jfi5UxXhyuwzfP /Eqw== X-Received: by 10.236.163.73 with SMTP id z49mr24013893yhk.43.1395292721993; Wed, 19 Mar 2014 22:18:41 -0700 (PDT) Original-Received: by 10.170.163.3 with HTTP; Wed, 19 Mar 2014 22:18:01 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87002 Archived-At: On Wed, Mar 19, 2014 at 7:29 PM, Stefan wrote: > We can either fix it by teaching Snarf-documentation about advised > function (yuck!) or by not advising functions that are documented in > DOC. IOW the right fix is to get rid of those advices in uniquify.el. IIUC, you're not proposing to delay the advice-add calls, but remove them altogether. How would you re-implement the current functionality so rename-buffer and create-file-buffer still respect uniquify? Some kind of hook in these functions?