From: Juanma Barranquero <lekktu@gmail.com>
To: Stefan <monnier@iro.umontreal.ca>
Cc: 16993@debbugs.gnu.org
Subject: bug#16993: advice-add hides docstring
Date: Thu, 20 Mar 2014 06:18:01 +0100 [thread overview]
Message-ID: <CAAeL0ST6PHNL-jDhUxpv9vRqw-xoopZ=H9rLUcJ5L5gQfWz7+g@mail.gmail.com> (raw)
In-Reply-To: <jwva9cmyrl4.fsf-monnier+bug#16993@gnu.org>
On Wed, Mar 19, 2014 at 7:29 PM, Stefan <monnier@iro.umontreal.ca> wrote:
> We can either fix it by teaching Snarf-documentation about advised
> function (yuck!) or by not advising functions that are documented in
> DOC. IOW the right fix is to get rid of those advices in uniquify.el.
IIUC, you're not proposing to delay the advice-add calls, but remove
them altogether. How would you re-implement the current functionality
so rename-buffer and create-file-buffer still respect uniquify? Some
kind of hook in these functions?
next prev parent reply other threads:[~2014-03-20 5:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 4:38 bug#16993: advice-add hides docstring Juanma Barranquero
2014-03-12 19:34 ` Glenn Morris
2014-03-12 19:49 ` Juanma Barranquero
2014-03-12 19:55 ` Glenn Morris
2014-03-12 20:15 ` Juanma Barranquero
2014-03-12 20:31 ` Glenn Morris
2014-03-12 20:33 ` Juanma Barranquero
2014-03-19 16:53 ` Juanma Barranquero
2014-03-19 18:29 ` Stefan
2014-03-20 5:18 ` Juanma Barranquero [this message]
2014-03-20 12:56 ` Stefan
2014-03-20 13:56 ` Juanma Barranquero
2014-03-20 15:57 ` Glenn Morris
2014-03-20 16:02 ` Stefan
2014-03-20 16:18 ` Juanma Barranquero
2014-03-20 17:55 ` Stefan
2014-03-20 17:59 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeL0ST6PHNL-jDhUxpv9vRqw-xoopZ=H9rLUcJ5L5gQfWz7+g@mail.gmail.com' \
--to=lekktu@gmail.com \
--cc=16993@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).