unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#14527: 24.3.50; error in window-state-get
@ 2013-06-01  9:59 Constantin Kulikov
  2013-06-01 12:33 ` martin rudalics
  0 siblings, 1 reply; 5+ messages in thread
From: Constantin Kulikov @ 2013-06-01  9:59 UTC (permalink / raw)
  To: 14527

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

emacs-version is "24.3.50.1" (yesterday's trunk) though this error was
introduced in some earlier version.

emacs -Q --debug-init
M-: (window-state-get)
see the error:
```
Debugger entered--Lisp error: (error "Combination limit is meaningful for
internal windows only")
  window-combination-limit(#<window 0x11106b8 on *scratch*>)
  window--state-get-1(#<window 0x11106b8 on *scratch*> nil)
  window-state-get()
  eval((window-state-get) nil)
  eval-expression((window-state-get) nil)
  call-interactively(eval-expression nil nil)
  command-execute(eval-expression)
```

[-- Attachment #2: Type: text/html, Size: 700 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#14527: 24.3.50; error in window-state-get
  2013-06-01  9:59 bug#14527: 24.3.50; error in window-state-get Constantin Kulikov
@ 2013-06-01 12:33 ` martin rudalics
  2013-06-25 15:48   ` Juanma Barranquero
  0 siblings, 1 reply; 5+ messages in thread
From: martin rudalics @ 2013-06-01 12:33 UTC (permalink / raw)
  To: Constantin Kulikov, Dmitry Antipov; +Cc: 14527

 > emacs-version is "24.3.50.1" (yesterday's trunk) though this error was
 > introduced in some earlier version.
 >
 > emacs -Q --debug-init
 > M-: (window-state-get)
 > see the error:
 > ```
 > Debugger entered--Lisp error: (error "Combination limit is meaningful for
 > internal windows only")
 >   window-combination-limit(#<window 0x11106b8 on *scratch*>)
 >   window--state-get-1(#<window 0x11106b8 on *scratch*> nil)
 >   window-state-get()
 >   eval((window-state-get) nil)
 >   eval-expression((window-state-get) nil)
 >   call-interactively(eval-expression nil nil)
 >   command-execute(eval-expression)
 > ```

Thanks.  It's due to that change:

2013-03-19  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.c (Fwindow_combination_limit, Fset_window_combination_limit):
	Signal error if window is not internal.  Adjust docstring.

You could try to work around it by using

             (combination-limit
	     . ,(unless (window-live-p window)
		  (window-combination-limit window)))

in `window-state-get' but I have no idea whether this would break any
things.  In any case it might be simpler to revert the change because
the original behavior was not broken IIUC.

martin





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#14527: 24.3.50; error in window-state-get
  2013-06-01 12:33 ` martin rudalics
@ 2013-06-25 15:48   ` Juanma Barranquero
  2014-01-04 15:42     ` martin rudalics
  0 siblings, 1 reply; 5+ messages in thread
From: Juanma Barranquero @ 2013-06-25 15:48 UTC (permalink / raw)
  To: martin rudalics; +Cc: Dmitry Antipov, 14527, Constantin Kulikov

I've installed Martin's fix** in revno:113172.  I'm leaving this bug
open until someone decides whether that is, indeed, the right fix or
there's something else to be done.

**The slightly different, but essentially identical change suggested
in http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg01050.html





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#14527: 24.3.50; error in window-state-get
  2013-06-25 15:48   ` Juanma Barranquero
@ 2014-01-04 15:42     ` martin rudalics
  2014-01-04 20:28       ` Juanma Barranquero
  0 siblings, 1 reply; 5+ messages in thread
From: martin rudalics @ 2014-01-04 15:42 UTC (permalink / raw)
  To: Juanma Barranquero; +Cc: Dmitry Antipov, 14527, Constantin Kulikov

> I've installed Martin's fix** in revno:113172.  I'm leaving this bug
> open until someone decides whether that is, indeed, the right fix or
> there's something else to be done.

How about closing this now?

martin






^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#14527: 24.3.50; error in window-state-get
  2014-01-04 15:42     ` martin rudalics
@ 2014-01-04 20:28       ` Juanma Barranquero
  0 siblings, 0 replies; 5+ messages in thread
From: Juanma Barranquero @ 2014-01-04 20:28 UTC (permalink / raw)
  To: martin rudalics; +Cc: Dmitry Antipov, 14527-done, Constantin Kulikov

> How about closing this now?

About time.





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-01-04 20:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-01  9:59 bug#14527: 24.3.50; error in window-state-get Constantin Kulikov
2013-06-01 12:33 ` martin rudalics
2013-06-25 15:48   ` Juanma Barranquero
2014-01-04 15:42     ` martin rudalics
2014-01-04 20:28       ` Juanma Barranquero

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).