From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#38384: (next|previous)-buffer silent about not switching Date: Tue, 26 Nov 2019 19:23:55 +0100 Message-ID: References: <83lfs2sky2.fsf@gnu.org> <83a78isee4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c3ff4f059843fda3" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="44844"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38384@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 26 19:32:29 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZfdT-000BWB-Ic for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 19:32:27 +0100 Original-Received: from localhost ([::1]:57862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZfdR-0001Uh-PI for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 13:32:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54974) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZfd3-0000lO-TM for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 13:32:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZfWH-0008Fg-UT for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 13:25:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46943) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZfWH-0008Fb-Rp for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 13:25:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZfWH-00075L-Om for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 13:25:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Nov 2019 18:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38384 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38384-submit@debbugs.gnu.org id=B38384.157479267927201 (code B ref 38384); Tue, 26 Nov 2019 18:25:01 +0000 Original-Received: (at 38384) by debbugs.gnu.org; 26 Nov 2019 18:24:39 +0000 Original-Received: from localhost ([127.0.0.1]:52916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZfVu-00074f-QQ for submit@debbugs.gnu.org; Tue, 26 Nov 2019 13:24:38 -0500 Original-Received: from mail-qk1-f176.google.com ([209.85.222.176]:41557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZfVs-00074T-TV for 38384@debbugs.gnu.org; Tue, 26 Nov 2019 13:24:37 -0500 Original-Received: by mail-qk1-f176.google.com with SMTP id m125so16968806qkd.8 for <38384@debbugs.gnu.org>; Tue, 26 Nov 2019 10:24:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fkVPv17P6PsxNgDMumS3B+1OS9aIF+1qXc/eetAybe0=; b=fpUXXnb6gzPEuqOMPeGu6By3eXWMlKsy4AcCgs6dAT1tJImNsYvvG88OjXV4B+EMJZ CBrCHnV9CrMwYjiG7md/6qAbZVbunWNcufqqEZTkXvrJ1Ynxt0RzjvPePH23xKMH8hY5 WIcg6iC4ZrSFc6VdalhCJu3DfAQn4LLQlLRg5PYNCPcrylEZdugXC37AjjbphkbSjbt0 Lgo7utPzpmOu8/Ld8KXFcTJer9hKUjL0e6tCfQlR52FWW736lQLRG4GIKw1trNbg6cdT cGmoTysoLktfbOrXL28bDqUQQriUG4u6YUzLfYaqZXDH5ktUYrYNTmsZ3tw8h07R4b2b JBYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fkVPv17P6PsxNgDMumS3B+1OS9aIF+1qXc/eetAybe0=; b=aS6bONvKQ/Lq2J6fOGOQgKvFORgokvWFC49UDpf91Hiw5+o3IaClVGqAuXTvTyoJ1O I4pRUpxVTl1xxCd0QuJnQd0yzdZeWBngsenrtVpdCYemGUy4i7X2W7svbzOXusbYxkFL GjvBidpEg9iU5KLTHKdxHwDMWhpUUPRSuNH46gbJwFcxMJQ/N+wvgFe/lsh8L51EW8Yc KlDZneQbSBkDfQ2v9CzLTn1iLlSr1SviBOpAMPK0WTtg3NF6U6VfNxuUWRle/Dhq0TkX VhDjejw4P1rS1BQTGkFuxmgYDEPyeILM96ccuczUv31jGcBnjxRrKj5x5HPE/BZRFdyy A7xA== X-Gm-Message-State: APjAAAW7YkBzNpAJMLf+OgNSlNa4bSHqVxEGYCgHa3CRL4MQ+f+NdUWu CRbq/O43pZ4YA1g3OSeAuC96mgOGyqt/mKsETlY= X-Google-Smtp-Source: APXvYqwRiSkyBSrvMyQA3ZpuK4gjkAPare/9UzdAbxM/+FjTBMJCfOCYmTvClMNlnrPzJSWXrDBa5TtNz0LZTb5Ckyg= X-Received: by 2002:a37:48d2:: with SMTP id v201mr16637103qka.277.1574792671262; Tue, 26 Nov 2019 10:24:31 -0800 (PST) In-Reply-To: <83a78isee4.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172464 Archived-At: --000000000000c3ff4f059843fda3 Content-Type: text/plain; charset="UTF-8" On Tue, Nov 26, 2019 at 7:04 PM Eli Zaretskii wrote: > Granted, I'm worried mainly about code outside of the Emacs tree. Even before my patch, both functions can in some situations signal user-error without checking for interactive use. (cond ((window-minibuffer-p) (user-error "Cannot switch buffers in minibuffer window")) ((eq (window-dedicated-p) t) (user-error "Window is strongly dedicated to its buffer")) --000000000000c3ff4f059843fda3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Nov 26, 2019 at 7:04 PM Eli Zaretskii <= eliz@gnu.org> wrote:

> Gra= nted, I'm worried mainly about code outside of the Emacs tree.

=
Even before my patch, both functions can in some situations sign= al user-error without checking for interactive use.

=C2=A0 (cond
= =C2=A0 =C2=A0((window-minibuffer-p)
=C2=A0 =C2=A0 (user-error "Cann= ot switch buffers in minibuffer window"))
=C2=A0 =C2=A0((eq (window= -dedicated-p) t)
=C2=A0 =C2=A0 (user-error "Window is strongly dedi= cated to its buffer"))


--000000000000c3ff4f059843fda3--