unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juanma Barranquero <lekktu@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 9722-done@debbugs.gnu.org
Subject: bug#9722: list-colors-duplicates does not exclude enough colors on Windows
Date: Tue, 18 Oct 2011 16:50:08 +0200	[thread overview]
Message-ID: <CAAeL0SR_Zu-4mnTV6ACj5y7zmr51jBpGvewp-7ZUm=6-Qadh4A@mail.gmail.com> (raw)
In-Reply-To: <837h43wndh.fsf@gnu.org>

On Mon, Oct 17, 2011 at 19:15, Eli Zaretskii <eliz@gnu.org> wrote:

> Perhaps so, but it's a separate issue.

Obviously, it does not affect this bug. Rather, it depends on this bug
to be fixed.

> Yes, but checking for "^System.*" must be in facemenu.el, while the
> list could be on a w32-only file.  Not a bug deal either way.

You still would need a way to access the list from facemenu.el,
conditional to some f?boundp or system-type check, so no net gain
there.

> If you feel that the cons outweigh the pros, go ahead and commit your
> patch.

Well, I'm not enthralled by the idea of hardcoding "^System", but I
also dislike adding a w32-specific variable that isn't likely to
change or be useful to the user.

    Juanma





  reply	other threads:[~2011-10-18 14:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-10 22:49 bug#9722: list-colors-duplicates does not exclude enough colors on Windows Juanma Barranquero
2011-10-11  6:01 ` Eli Zaretskii
2011-10-11 11:24   ` Juanma Barranquero
2011-10-11 19:39     ` Eli Zaretskii
2011-10-11 20:54       ` Juanma Barranquero
2011-10-17 12:00         ` Juanma Barranquero
2011-10-17 16:41           ` Eli Zaretskii
2011-10-17 16:55             ` Juanma Barranquero
2011-10-17 17:15               ` Eli Zaretskii
2011-10-18 14:50                 ` Juanma Barranquero [this message]
     [not found]                   ` <83obxeuwa8.fsf@gnu.org>
     [not found]                     ` <CAAeL0SRRkqY2r6QwASsb1JVdeSfTd9UDz3RY5QTx-PHME2iZsQ@mail.gmail.com>
     [not found]                       ` <83k482ut21.fsf@gnu.org>
2011-10-18 19:25                         ` Juanma Barranquero
2011-10-18 21:01                           ` Eli Zaretskii
2011-10-24 19:29                             ` Juanma Barranquero
2011-10-19  8:20         ` Juri Linkov
2011-10-19  8:36           ` Eli Zaretskii
2011-10-19  8:57           ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAeL0SR_Zu-4mnTV6ACj5y7zmr51jBpGvewp-7ZUm=6-Qadh4A@mail.gmail.com' \
    --to=lekktu@gmail.com \
    --cc=9722-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).