From: Juanma Barranquero <lekktu@gmail.com>
To: 37556@debbugs.gnu.org
Cc: larsi@gnus.org
Subject: bug#37556: gpg "-unknown" version string
Date: Mon, 30 Sep 2019 00:59:18 +0200 [thread overview]
Message-ID: <CAAeL0SRY5mV6WqheoqYytLRv1=sgSVFaOMgmdS3TO5OGg49G6Q@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]
Package: emacs
Version: 27.0.50
X-Debbugs-Cc: larsi@gnus.org
This is related to bug# 35629.
This commit
commit 42ba6200af10c00c72ac13912d6fb42a7af88058
Author: Lars Ingebrigtsen <larsi@gnus.org>
Date: 2019-08-26 08:02:31 +0200
Allow finding gpg2 binaries when gpg2 has an "unknown" version string
* lisp/epg-config.el (epg-find-configuration): Allow finding a
usable configuration even if the version string looks like "gpg
(GnuPG) 2.2.15-unknown" (bug#35629).
fixes one function, but there are other uses of version-related functions
in epg, for example
(defun epg-required-version-p (protocol required-version)
"Verify a sufficient version of GnuPG for specific protocol.
PROTOCOL is symbol, either `OpenPGP' or `CMS'. REQUIRED-VERSION
is a string containing the required version number. Return
non-nil if that version or higher is installed."
(let ((version (cdr (assq 'version (epg-find-configuration protocol)))))
(and (stringp version)
(version<= required-version version))))
which calls epg-find-configuration (which is protected by the above
change), and then version<= (which fails).
This makes epg-tests.el fail on my gpg, from MSYS2:
$ gpg --version
gpg (GnuPG) 2.2.17-unknown
libgcrypt 1.8.4
Fixing this with another let binding around `version<=' is trivial, but it
is a kludge.
I think it makes more sense just adding "-unknown" to the formats
recognized by default with version-regexp-alist.
(Note: after working around this bug, epg tests still fail for me, but for
unrelated reasons.)
[-- Attachment #2: Type: text/html, Size: 2107 bytes --]
next reply other threads:[~2019-09-29 22:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 22:59 Juanma Barranquero [this message]
2019-09-30 5:34 ` bug#37556: gpg "-unknown" version string Lars Ingebrigtsen
2019-09-30 7:17 ` Eli Zaretskii
2019-09-30 7:49 ` Juanma Barranquero
2019-09-30 8:46 ` Eli Zaretskii
2019-09-30 9:32 ` Juanma Barranquero
2019-09-30 14:04 ` Lars Ingebrigtsen
2019-09-30 14:25 ` Noam Postavsky
2019-09-30 14:42 ` Lars Ingebrigtsen
2019-09-30 14:46 ` Noam Postavsky
2019-10-01 12:09 ` Lars Ingebrigtsen
2019-10-01 14:59 ` Kazuhiro Ito
2019-10-13 3:01 ` Lars Ingebrigtsen
2019-10-13 5:12 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeL0SRY5mV6WqheoqYytLRv1=sgSVFaOMgmdS3TO5OGg49G6Q@mail.gmail.com' \
--to=lekktu@gmail.com \
--cc=37556@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).