From: Juanma Barranquero <lekktu@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: John Wiegley <jwiegley@gmail.com>,
dgutov@yandex.ru, Richard Stallman <rms@gnu.org>,
21953@debbugs.gnu.org
Subject: bug#21953: Eliminate warnings in the emacs-25 release branch
Date: Thu, 19 Nov 2015 19:34:07 +0100 [thread overview]
Message-ID: <CAAeL0SRVpKq9fcLKhzDK_+c6mjd5xRxKQsq0FOAzFvRm+B6hmg@mail.gmail.com> (raw)
In-Reply-To: <83a8q998oe.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 4138 bytes --]
On Thu, Nov 19, 2015 at 6:54 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> We can stop worrying about warnings in C: there are none, and a few
> people regularly compile with pedantic compiler switches and fix
> whatever they flag.
At least on Windows, that's not entirely true. I compile with very pedantic
switches.
I had to add "-Wno-missing-prototypes -Wno-missing-declarations
-Wno-redundant-decls -Wno-pointer-sign" to my CFLAGS because of the sheer
number of warnings.
Even so, I get 322 cases of *"initialization discards 'const' qualifier
from pointer target type*", and leaving these aside, also this (# of warns,
warning message)
14 assignment discards 'const' qualifier from pointer target type [enabled
by default]
14 passing argument 1 of 'w32_getenv' discards 'const' qualifier from
pointer target type [enabled by default]
5 return discards 'const' qualifier from pointer target type [enabled by
default]
5 function might be possible candidate for 'ms_printf' format attribute
[-Wsuggest-attribute=format]
4 pointer of type 'void *' used in arithmetic [-Wpointer-arith]
3 format '%d' expects argument of type 'int', but argument 3 has type
'printmax_t' [-Wformat=]
3 passing argument 1 of 'set_user_model' discards 'const' qualifier from
pointer target type [enabled by default]
2 nested extern declaration of '_execvp' [-Wnested-externs]
2 passing argument 2 of 'CreateProcessA' discards 'const' qualifier from
pointer target type [enabled by default]
2 format '%d' expects argument of type 'int', but argument 2 has type
'DWORD' [-Wformat=]
2 unused variable 'status' [-Wunused-variable]
2 passing argument 2 of 'otf_features' discards 'const' qualifier from
pointer target type [enabled by default]
2 ordered comparison of pointer with integer zero [-Wextra]
2 implicit conversion from 'float' to 'double' when passing argument to
function [-Wdouble-promotion]
1 unused variable 'terminal' [-Wunused-variable]
1 'dummy' defined but not used [-Wunused-variable]
1 macro "g_type_init" is not used [-Wunused-macros]
1 unused variable 'st' [-Wunused-variable]
1 macro "NOMINMAX" is not used [-Wunused-macros]
1 nested extern declaration of 'is_slow_fs' [-Wnested-externs]
1 function might be candidate for attribute 'noreturn'
[-Wsuggest-attribute=noreturn]
1 variable 'face' set but not used [-Wunused-but-set-variable]
1 'timeout' may be used uninitialized in this function
[-Wmaybe-uninitialized]
1 implicit conversion from 'float' to 'double' to match other operand of
binary expression [-Wdouble-promotion]
1 macro "x_display_info" is not used [-Wunused-macros]
1 macro "OFFSET_TO_RVA" is not used [-Wunused-macros]
1 unused variable 'oldset' [-Wunused-variable]
1 macro "DATAGRAM_CHAN_P" is not used [-Wunused-macros]
1 unused variable 'size' [-Wunused-variable]
1 control reaches end of non-void function [-Wreturn-type]
1 macro "_ANONYMOUS_UNION" is not used [-Wunused-macros]
1 unused variable 'address' [-Wunused-variable]
1 unknown conversion type character 'e' in format [-Wformat=]
1 unused variable 'dpyinfo' [-Wunused-variable]
1 nested extern declaration of 'g_b_init_compare_string_w'
[-Wnested-externs]
1 nested extern declaration of '_resetstkoflw' [-Wnested-externs]
1 passing argument 1 of 'find_section' discards 'const' qualifier from
pointer target type [enabled by default]
1 passing argument 1 of 'w32_get_rdb_resource' discards 'const' qualifier
from pointer target type [enabled by default]
1 unused variable 'n_to_read' [-Wunused-variable]
1 macro "WTMP_FILE" is not used [-Wunused-macros]
1 nested extern declaration of 'mainCRTStartup' [-Wnested-externs]
1 variable 'f' set but not used [-Wunused-but-set-variable]
1 macro "DefaultDepthOfScreen" is not used [-Wunused-macros]
1 macro "RVA_TO_PTR" is not used [-Wunused-macros]
1 macro "gnutls_x509_crt_get_signature" is not used [-Wunused-macros]
1 variable 'ctty' set but not used [-Wunused-but-set-variable]
1 nested extern declaration of 'menubar_selection_callback'
[-Wnested-externs]
1 macro "MAX_ENCODED_BYTES" is not used [-Wunused-macros]
[-- Attachment #2: Type: text/html, Size: 7412 bytes --]
next prev parent reply other threads:[~2015-11-19 18:34 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 17:44 bug#21953: Eliminate warnings in the emacs-25 release branch John Wiegley
2015-11-18 17:58 ` Eli Zaretskii
2015-11-18 18:04 ` Dmitry Gutov
2015-11-18 18:17 ` Glenn Morris
2015-11-18 18:44 ` Eli Zaretskii
2015-11-23 19:10 ` Glenn Morris
2015-11-23 22:04 ` John Wiegley
2015-11-23 22:47 ` Drew Adams
2015-11-24 3:30 ` Eli Zaretskii
2015-11-24 3:40 ` John Wiegley
2015-11-24 17:40 ` Glenn Morris
2015-11-25 1:03 ` John Wiegley
2015-11-18 19:09 ` Artur Malabarba
2015-11-18 20:36 ` Eli Zaretskii
2015-11-18 20:57 ` Artur Malabarba
2015-11-19 2:06 ` John Wiegley
2015-11-19 17:20 ` Stephen Leake
2015-11-19 17:29 ` Dmitry Gutov
2015-11-19 17:37 ` John Wiegley
2015-11-19 17:46 ` Dmitry Gutov
2015-11-19 17:54 ` Eli Zaretskii
2015-11-19 18:18 ` John Wiegley
2015-11-19 18:34 ` Juanma Barranquero [this message]
2015-11-19 19:05 ` John Wiegley
2015-11-19 20:29 ` Eli Zaretskii
2015-11-19 20:25 ` Eli Zaretskii
2015-11-19 20:31 ` Juanma Barranquero
2015-11-19 20:51 ` Eli Zaretskii
2015-11-20 0:26 ` Juanma Barranquero
2015-11-25 20:58 ` Andy Moreton
2015-11-26 17:55 ` Eli Zaretskii
2015-11-19 20:01 ` David Engster
2015-11-19 20:26 ` John Wiegley
2015-11-19 20:32 ` Eli Zaretskii
2015-11-20 10:41 ` Stephen Leake
2015-11-19 17:45 ` Eli Zaretskii
2015-11-18 18:39 ` Ken Brown
2015-11-18 18:52 ` Eli Zaretskii
2015-11-18 19:19 ` Ken Brown
2015-11-18 20:38 ` Eli Zaretskii
2015-11-18 20:57 ` Stephen Berman
[not found] ` <mailman.233.1447954214.31583.bug-gnu-emacs@gnu.org>
2015-11-24 19:55 ` Alan Mackenzie
2015-11-25 0:28 ` Dmitry Gutov
2015-11-25 9:31 ` Alan Mackenzie
2015-11-25 14:36 ` Dmitry Gutov
2015-11-25 15:50 ` Alan Mackenzie
2015-11-25 18:54 ` Glenn Morris
2015-11-26 8:33 ` Andreas Röhler
2015-11-26 15:51 ` Eli Zaretskii
2015-11-28 18:44 ` John Wiegley
2015-11-29 9:13 ` Andreas Röhler
2015-11-30 0:38 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAeL0SRVpKq9fcLKhzDK_+c6mjd5xRxKQsq0FOAzFvRm+B6hmg@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=21953@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=jwiegley@gmail.com \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).