From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#16733: messed up unicode chars in package description Date: Tue, 25 Mar 2014 10:54:29 +0100 Message-ID: References: <7tfvnn7phj.fsf@fencepost.gnu.org> <83zjkm865z.fsf@gnu.org> <838us496xy.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1395741367 12936 80.91.229.3 (25 Mar 2014 09:56:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Mar 2014 09:56:07 +0000 (UTC) Cc: 16733@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 25 10:56:15 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSO5f-0000Rf-2H for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Mar 2014 10:56:15 +0100 Original-Received: from localhost ([::1]:40413 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSO5e-0006Fk-PH for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Mar 2014 05:56:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSO5X-0006FM-5K for bug-gnu-emacs@gnu.org; Tue, 25 Mar 2014 05:56:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSO5S-0002gT-DP for bug-gnu-emacs@gnu.org; Tue, 25 Mar 2014 05:56:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSO5S-0002gL-Ao for bug-gnu-emacs@gnu.org; Tue, 25 Mar 2014 05:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WSO5R-0000Cw-QJ for bug-gnu-emacs@gnu.org; Tue, 25 Mar 2014 05:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Mar 2014 09:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16733 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16733-submit@debbugs.gnu.org id=B16733.1395741314731 (code B ref 16733); Tue, 25 Mar 2014 09:56:01 +0000 Original-Received: (at 16733) by debbugs.gnu.org; 25 Mar 2014 09:55:14 +0000 Original-Received: from localhost ([127.0.0.1]:48489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSO4f-0000Bh-3n for submit@debbugs.gnu.org; Tue, 25 Mar 2014 05:55:13 -0400 Original-Received: from mail-yk0-f175.google.com ([209.85.160.175]:34566) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WSO4c-0000BX-G0 for 16733@debbugs.gnu.org; Tue, 25 Mar 2014 05:55:11 -0400 Original-Received: by mail-yk0-f175.google.com with SMTP id 131so505097ykp.6 for <16733@debbugs.gnu.org>; Tue, 25 Mar 2014 02:55:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=5Y5/0qx+Pw3uUFU4EUWfz2CsTirB/7msrFFKn0am7qM=; b=Sk3EN4wRdepCD7IKpbREnrgfnXwLr4gRXnwho1bZ5XTRYb1FD9BRxkfzwfm6/osbB9 cE5YIVxFMWzS40XdbASiA7h5M1lzjMp0ZCDOgAVi9xqBpW3irnPpqcnl6e+i8caVVMDm b90IFBtGJPNC3+Ls1GT7wcBWmSZQC75t3mTsD/4DlCk4/cAXNekKGELcV6Caem3r0WiU iKducHFrG8YX3QoeLjsKK/HZNQNg0VbqIq+Smh/DmDk65seYWIvOPeAdwBfEV++rASmD k3p51ZQ2mqKhgf9aX0bwMINzMwjtbzTEmxnhun9u7pj3nHVaikVn9JbEgHcTx6p+9LJ3 psOg== X-Received: by 10.236.166.39 with SMTP id f27mr1042148yhl.116.1395741309707; Tue, 25 Mar 2014 02:55:09 -0700 (PDT) Original-Received: by 10.170.163.3 with HTTP; Tue, 25 Mar 2014 02:54:29 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87351 Archived-At: On Tue, Mar 25, 2014 at 4:35 AM, Stefan Monnier wrote: > The old package.el code included (buffer-substring-no-properties (point) > (line-end-position)) in the message. Would it make sense to put it here > as well? It's the HTTP error description. As the "no buffer" case doesn't have such a description, I've modified url-insert-file-contents so in tha case it returns "No Data", to match "Not Found" and other HTTP errors. That's the resulting url-i-f-c: (defun url-insert-file-contents (url &optional visit beg end replace) (let ((buffer (url-retrieve-synchronously url))) (unless buffer (signal 'file-error (list url "No Data"))) (with-current-buffer buffer (let ((response (url-http-parse-response))) (if (and (>= response 200) (< response 300)) (goto-char (point-min)) (let ((desc (buffer-substring-no-properties (1+ (point)) (line-end-position)))) (kill-buffer buffer) (signal 'file-error (list url desc)))))) (if visit (setq buffer-file-name url)) (save-excursion (let* ((start (point)) (size-and-charset (url-insert buffer beg end))) (kill-buffer buffer) (when replace (delete-region (point-min) start) (delete-region (point) (point-max))) (unless (cadr size-and-charset) ;; If the headers don't specify any particular charset, use the ;; usual heuristic/rules that we apply to files. (decode-coding-inserted-region start (point) url visit beg end replace)) (list url (car size-and-charset))))))