From: Juanma Barranquero <lekktu@gmail.com>
To: Juri Linkov <juri@jurta.org>
Cc: 10857@debbugs.gnu.org
Subject: bug#10857: ucs-insert deals inconsistently with errors
Date: Tue, 21 Feb 2012 02:25:47 +0100 [thread overview]
Message-ID: <CAAeL0SREwH7rDyt3MEKLh6iBUA7MGQvRN=JvX_hz_J_ot6bQfw@mail.gmail.com> (raw)
In-Reply-To: <87obstt2n9.fsf@mail.jurta.org>
On Tue, Feb 21, 2012 at 01:37, Juri Linkov <juri@jurta.org> wrote:
> Wouldn't it be too weird for `read-char-by-name' to return "zzz"
> when the purpose of this function is to return a character,
> not a string the user typed.
Yes. I don't think `read-char-by-name' should return "zzz", I think
`ucs-insert' should not say the "nil" part. Perhaps just "Not a
Unicode character".
>> The second problem can be trivially fixed with
>> (not (string-match-p "[^[:xdigit:]]" character)),
>
> In `read-char-by-name', the condition for this purpose is:
>
> (string-match-p "^[0-9a-fA-F]+$" input)
They are equivalent, aren't they? But my point was that the docstring
does not say what to expect in CHARACTER.
Juanma
next prev parent reply other threads:[~2012-02-21 1:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 15:53 bug#10857: ucs-insert deals inconsistently with errors Juanma Barranquero
2012-02-21 0:37 ` Juri Linkov
2012-02-21 1:25 ` Juanma Barranquero [this message]
2012-02-21 9:16 ` Andreas Schwab
2012-02-21 10:39 ` Juanma Barranquero
2012-02-22 0:09 ` Juri Linkov
2012-02-22 9:03 ` Andreas Schwab
2012-02-22 23:35 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeL0SREwH7rDyt3MEKLh6iBUA7MGQvRN=JvX_hz_J_ot6bQfw@mail.gmail.com' \
--to=lekktu@gmail.com \
--cc=10857@debbugs.gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).