bug#14841: Frames created invisible have their visibility parameter set to t

[Juanma Barranquero <lekktu@gmail.com>]

On Sat, Jul 20, 2013 at 2:53 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> I'm out of my depth here, as I know close to nothing about the details
> of these messages, and why are they sent to us, even though the frame
> is created invisible.  But try the changes below for a few days, and
> if they don't have any adverse effects, I will install them.

> -                 DebPrint (("frame %p (%s) reexposed by WM_PAINT\n", f,
> -                            SDATA (f->name)));
> +                 if (!f->output_data.w32->asked_for_visible)
> +                   DebPrint (("frame %p (%s) reexposed by WM_PAINT\n", f,
> +                              SDATA (f->name)));

> -                   SET_FRAME_VISIBLE (f, 1);
> +                   if (iconified)
> +                     SET_FRAME_VISIBLE (f, 1);

An easy to reproduce bug caused by this change:

 ;;; .emacs
 (let ((f (selected-frame)))
   (make-frame)
   (delete-frame f))
;;; .emacs ends here

 emacs

 =>

 Warning (initialization): An error occurred while loading
`c:/Devel/emacs/test/.emacs':

 error: Attempt to delete the sole visible or iconified frame