From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Tue, 26 Nov 2019 00:45:56 +0100 Message-ID: References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <87imna18nc.fsf@mail.linkov.net> <83y2w5s14l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000095d8de0598345f46" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="173479"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org, Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 26 00:47:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZO4W-000j0V-RD for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 00:47:12 +0100 Original-Received: from localhost ([::1]:49184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZO4V-0001H8-37 for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Nov 2019 18:47:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49305) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZO4N-0001Gz-Iz for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 18:47:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZO4M-0004eB-Bt for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 18:47:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43980) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZO4M-0004e4-8q for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 18:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZO4M-0007fi-6c for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 18:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Nov 2019 23:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157472560129462 (code B ref 37774); Mon, 25 Nov 2019 23:47:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 25 Nov 2019 23:46:41 +0000 Original-Received: from localhost ([127.0.0.1]:49953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZO40-0007f8-L9 for submit@debbugs.gnu.org; Mon, 25 Nov 2019 18:46:40 -0500 Original-Received: from mail-qk1-f179.google.com ([209.85.222.179]:37562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZO3y-0007eu-Kq for 37774@debbugs.gnu.org; Mon, 25 Nov 2019 18:46:39 -0500 Original-Received: by mail-qk1-f179.google.com with SMTP id e187so14547901qkf.4 for <37774@debbugs.gnu.org>; Mon, 25 Nov 2019 15:46:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9P0wmJqDR/N1vYYc2aiDu+Y+jbzeaupE6oBIVFr6YPI=; b=Fe/FI5CsqYRJVeh5ZOmbM22GaaLU8z1WMuIR1t1Oc6pb352m//scoaBYDSayyC3Unj mpbzzp+Fn1+LZ2s4aGFJzlRqtEjCkSRGN5G64L90t5F6pri0ktZmCRDmJvn2l8lih9Nw XpALdRatQE6E3By51vICgi0ILZoG33Lrq3VuO4vtE7ANza221qDT0cJ0njIJ5W35jScF c5YXDmQr/M080jr5sXPLmiuqOyMzcbGkyEdDl7uPHFo6um1ZssHZJ0LKg/J6EXoJphit 3Mvwm1ywy0fC63uo7OrrV82ovedkXwyJ0gfKxkCxLUOj4teBO2aRfrVtw/WjoFGAuw0u doFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9P0wmJqDR/N1vYYc2aiDu+Y+jbzeaupE6oBIVFr6YPI=; b=W2D58LavVno9igGzv1pHB19t++lEYKFmLAdRZfrtrlSGmZzSWlgWQdXorOGWJPRL9X 5Dl9bz/kcd4GlfwfBaCcMmIjDaJ6SUtiGIFIhFCN4f+avyOVZ9b38zHSMFvn+g2l8d9Q KKmh4JJwA3A1hkPW6JqkI96Lf4/TXnzn491UN8iYUaUpVwU6stBzlFWuIUhifxjdH1nc u+U1HlgRE2ewZVWGWDUQT3OuBHgSNcgNzsboU6Iz7JskD2ASdpRBrbt1gLCTGKXPRWpg olMAdFAXV8+4fD80RYA2oDH/jWH3QWzoctktLCHD4gRskoOiEAAHMfkLbtrUobd9hm8T oFGQ== X-Gm-Message-State: APjAAAXROOvIeElcDKvHdh+u9M5UMDgM3i5nNvY+keJefxoRoNdi+cUM 1Oc8r940mJU8tekdLfAtJ2aaRHi+SP4bPeRTC6s= X-Google-Smtp-Source: APXvYqz2eZpC9W6j8KWmasmtxnLy1qq0EnnTDaoI1taS5zwMOcUp/caU+9mh2Qlyl5W4L89efSKFSczdlb/OTzaV5Co= X-Received: by 2002:a37:48d2:: with SMTP id v201mr12507956qka.277.1574725592928; Mon, 25 Nov 2019 15:46:32 -0800 (PST) In-Reply-To: <83y2w5s14l.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172400 Archived-At: --00000000000095d8de0598345f46 Content-Type: text/plain; charset="UTF-8" On Mon, Nov 25, 2019 at 4:30 PM Eli Zaretskii wrote: > Is there something else to be developed? I wasn't aware of anything > that didn't get implemented already. Near the end of this thread https://lists.gnu.org/archive/html/emacs-devel/2019-10/msg00590.html Ergus said: Somehow this is related with something we discussed some time ago, about the fact that we should call extend_face_to_end_of_line in the last line of the buffer if not empty in some conditions (dfci is active for example.) Maybe you remember that we don't have the indicator for the last line, which somehow we agreed must be corrected. In this case the problem is the same: the extend_face... function is not called for the latest line in the buffer but I didn't find a better condition to fix this (I didn't try very hard either) But probably it just requires to extend a condition in an if and part of this problem will be fixed (the case for the last line at least) There are some conditions in the display_line function to not call extend_face_to... when the line ends at ZV, fixing this condition we should be done right? Was this resolved / fixed? --00000000000095d8de0598345f46 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Mon, Nov 25, 2019 at 4:30 PM Eli Zaretskii <eliz@gnu.org> wrote:
> Is there something else to be developed?=C2=A0 I wasn't= aware of anything
> that didn't get implemented already.

= Near the end of this thread


Ergus said:

Somehow this is related with something we discuss=
ed some time ago, about
the fact that we should call extend_face_to_end_of_line in the last=
 line
of the buf=
fer if not empty in some conditions (dfci is active for
example.)
Maybe you remember that we don't have the indicator =
for the last line,
which somehow we agreed must be corrected. In this case the problem is
the same: the ext=
end_face... function is not called for the latest line
in the buffer but I didn't find =
a better condition to fix this (I didn't
try very hard either) But probably it just req=
uires to extend a
condition in an if and part of this problem will be fixed (the case for
the last line at =
least)
There are some condition=
s in the display_line function to not call
extend_face_to... when the line ends at ZV, fixi=
ng this condition we
should be done right?

Was this resolved / fixed?



--00000000000095d8de0598345f46--