From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 19390@debbugs.gnu.org
Subject: bug#19390: 25.0.50; `package-activate' is too slow
Date: Thu, 18 Dec 2014 15:50:28 -0200 [thread overview]
Message-ID: <CAAdUY-LcVH7bNKiWZeXAJ3d4tUD1+FY3g3KXxFYeUTQDOcGJRQ@mail.gmail.com> (raw)
In-Reply-To: <5492FDBD.1040704@yandex.ru>
[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]
On 18 Dec 2014 14:15, "Dmitry Gutov" <dgutov@yandex.ru> wrote:
>
> On 12/18/2014 05:47 PM, Artur Malabarba wrote:
>>
>> In retrospect, the cleanest way to do do all this would have been to
>> build this reloading into `require' and `provide' (something would
>
>
> I dunno, seems like if `require' has to consult `find-library-name' each
time, it would lower its performance.
>
> Maybe even perceptibly, since it's called a lot.
There's a way we can implement this so that find library and file-truename
have to be called exactly once per require (and file-truename is called
once per provide).
Yes, there will be a performance hit, but one could argue that is the way
require should have been done from the start (the "right way").
I don't think this performance hit will be noticeable during regular
package loading. How expensive is it to call find-library and file-truename
once per require, compared to the time it takes to actually load (possibly
byte-compile) the entire library that's calling these requires?
The performance difference will certainly be noticeable during
package-initialize. Like I mentioned above, that's an important issue.
[-- Attachment #2: Type: text/html, Size: 1420 bytes --]
next prev parent reply other threads:[~2014-12-18 17:50 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 17:34 bug#19390: 25.0.50; `package-activate' is too slow Dmitry Gutov
[not found] ` <handler.19390.B.14186649209005.ack@debbugs.gnu.org>
2014-12-16 0:41 ` bug#19390: Acknowledgement (25.0.50; `package-activate' is too slow) Dmitry Gutov
2014-12-16 12:32 ` bug#19390: 25.0.50; `package-activate' is too slow Dmitry Gutov
2014-12-16 13:26 ` Artur Malabarba
2014-12-16 13:42 ` Artur Malabarba
2014-12-16 14:31 ` Dmitry Gutov
2014-12-16 21:35 ` Artur Malabarba
2014-12-16 23:16 ` Stefan Monnier
2014-12-16 23:27 ` Dmitry Gutov
2014-12-16 23:55 ` Stefan Monnier
2014-12-17 0:40 ` Artur Malabarba
2014-12-17 1:17 ` Dmitry Gutov
2014-12-17 14:33 ` Artur Malabarba
2014-12-17 2:41 ` Dmitry Gutov
2014-12-17 10:47 ` Artur Malabarba
2014-12-18 0:14 ` Dmitry Gutov
2014-12-18 1:38 ` Stefan Monnier
2014-12-18 2:11 ` Artur Malabarba
2014-12-18 10:37 ` Dmitry Gutov
2014-12-18 14:30 ` Stefan Monnier
2014-12-18 14:47 ` Dmitry Gutov
2014-12-18 15:39 ` Artur Malabarba
2014-12-18 15:47 ` Artur Malabarba
2014-12-18 16:15 ` Dmitry Gutov
2014-12-18 17:50 ` Artur Malabarba [this message]
2014-12-18 17:54 ` Dmitry Gutov
2014-12-18 18:40 ` Stefan Monnier
2014-12-18 19:13 ` Artur Malabarba
2014-12-19 4:31 ` Stefan Monnier
2014-12-19 12:08 ` Artur Malabarba
2014-12-18 18:37 ` Stefan Monnier
2014-12-18 15:49 ` Dmitry Gutov
2014-12-18 16:45 ` Dmitry Gutov
2014-12-18 16:14 ` Artur Malabarba
2014-12-18 15:15 ` Artur Malabarba
2014-12-18 15:45 ` Dmitry Gutov
2014-12-18 17:39 ` Artur Malabarba
2014-12-18 17:52 ` Dmitry Gutov
2014-12-18 19:01 ` Artur Malabarba
2014-12-18 19:49 ` Dmitry Gutov
2014-12-18 18:42 ` Stefan Monnier
2014-12-18 18:45 ` Dmitry Gutov
2014-12-16 16:53 ` Dmitry Gutov
2014-12-16 22:00 ` Artur Malabarba
2014-12-17 1:05 ` Dmitry Gutov
2014-12-16 23:19 ` Stefan Monnier
2014-12-16 23:40 ` Dmitry Gutov
2014-12-16 23:56 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAdUY-LcVH7bNKiWZeXAJ3d4tUD1+FY3g3KXxFYeUTQDOcGJRQ@mail.gmail.com \
--to=bruce.connor.am@gmail.com \
--cc=19390@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).