unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Rasmus <rasmus@gmx.us>
Cc: 21921@debbugs.gnu.org
Subject: bug#21921: New function comment-line also comments first line after region
Date: Mon, 16 Nov 2015 09:02:12 +0000	[thread overview]
Message-ID: <CAAdUY-LH35R-7=6vnPBFVYNMkg0=mEZTVKrROesm4wahG4PfwA@mail.gmail.com> (raw)
In-Reply-To: <87a8qffpvl.fsf@gmx.us>

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

On 15 Nov 2015 11:45 am, "Rasmus" <rasmus@gmx.us> wrote:
> >
> > Yet pressing C-x C-; comments out all three lines. I find this second
example especially confusing.
> >
> > Is this behaviour only surprising to me?
>
> Perhaps the confusion is caused by region not being displayed at column
> zero.
>
> The behavior is correct IMO.
>
> For your particular examples, comment-dwim does what you want, it seems.
>
> Hope it helps,
> Rasmus

Indeed. When I was deciding how comment-line should work on a region, I
specifically chose to not make it identical to comment-dwim.

Maybe it should still treat the "region ends at a newline" case specially.
Some emacs commands do that already.
Not sure though, since that would be slightly redundant with comment-dwim.

[-- Attachment #2: Type: text/html, Size: 989 bytes --]

  reply	other threads:[~2015-11-16  9:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-14 18:24 bug#21921: New function comment-line also comments first line after region Clément Pit--Claudel
2015-11-15 11:45 ` Rasmus
2015-11-16  9:02   ` Artur Malabarba [this message]
2015-11-16 17:59     ` Rasmus
2015-11-17 20:47       ` Andreas Röhler
2017-06-04 13:24   ` npostavs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAdUY-LH35R-7=6vnPBFVYNMkg0=mEZTVKrROesm4wahG4PfwA@mail.gmail.com' \
    --to=bruce.connor.am@gmail.com \
    --cc=21921@debbugs.gnu.org \
    --cc=rasmus@gmx.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).