From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 19390@debbugs.gnu.org
Subject: bug#19390: 25.0.50; `package-activate' is too slow
Date: Tue, 16 Dec 2014 11:42:09 -0200 [thread overview]
Message-ID: <CAAdUY-LCeF2HMn1mJAzy38RAZCBm=1TEdXQ8E06Bbpp2Yja8hw@mail.gmail.com> (raw)
In-Reply-To: <CAAdUY-JZ_n9h1b2AmdAXYSf3+f8GwoD3dEejqHu4VnQMS52Zmg@mail.gmail.com>
As for low-hanging fruits in `package--list-loaded-files', there are
two I can think of.
1. If `load-history' stored `file-truename's (relative to "/"),
instead of just absolute file names, then that would avoid a lot of
calls to `file-truename'. This, I suspect, is the bigger performance
issue.
2. Creating the `history' variable as below is a problem.
(mapcar (lambda (x) (file-name-sans-extension
(file-truename (car x))))
load-history)
This lambda is called a lot more times than necessary, because most
entries in load-history are useless here. But we need to do this to be
able to reliably compare file names. Ideally, there would be another
variable, like `load-history-truename', which is modified in parellel
with `load-history' and *only* stores the truename of files listed in
`load-history' (no need to store all that extra information). Then we
could just use this variable unmodified.
Implementing 2. would also fix 1.
2014-12-16 11:26 GMT-02:00 Artur Malabarba <bruce.connor.am@gmail.com>:
> I didn't notice anything as aggravating as the report, but I agree my
> latest patch is a performance concern.
>
> The proposed patch looks good, just a couple of notes:
>
> 1. I'd use RELOAD for the name of the optional argument.
> 2. Since this function now takes a second (somewhat non-trivial
> argument), we should add a docstring to it:
>
> "Activate package given by PKG-DESC, even if it was already active.
> If RELOAD is non-nil, also `load' any files inside the package which
> correspond to previously loaded files (those returned by
> `package--list-loaded-files').
>
> This is called internally by `package-activate'."
next prev parent reply other threads:[~2014-12-16 13:42 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 17:34 bug#19390: 25.0.50; `package-activate' is too slow Dmitry Gutov
[not found] ` <handler.19390.B.14186649209005.ack@debbugs.gnu.org>
2014-12-16 0:41 ` bug#19390: Acknowledgement (25.0.50; `package-activate' is too slow) Dmitry Gutov
2014-12-16 12:32 ` bug#19390: 25.0.50; `package-activate' is too slow Dmitry Gutov
2014-12-16 13:26 ` Artur Malabarba
2014-12-16 13:42 ` Artur Malabarba [this message]
2014-12-16 14:31 ` Dmitry Gutov
2014-12-16 21:35 ` Artur Malabarba
2014-12-16 23:16 ` Stefan Monnier
2014-12-16 23:27 ` Dmitry Gutov
2014-12-16 23:55 ` Stefan Monnier
2014-12-17 0:40 ` Artur Malabarba
2014-12-17 1:17 ` Dmitry Gutov
2014-12-17 14:33 ` Artur Malabarba
2014-12-17 2:41 ` Dmitry Gutov
2014-12-17 10:47 ` Artur Malabarba
2014-12-18 0:14 ` Dmitry Gutov
2014-12-18 1:38 ` Stefan Monnier
2014-12-18 2:11 ` Artur Malabarba
2014-12-18 10:37 ` Dmitry Gutov
2014-12-18 14:30 ` Stefan Monnier
2014-12-18 14:47 ` Dmitry Gutov
2014-12-18 15:39 ` Artur Malabarba
2014-12-18 15:47 ` Artur Malabarba
2014-12-18 16:15 ` Dmitry Gutov
2014-12-18 17:50 ` Artur Malabarba
2014-12-18 17:54 ` Dmitry Gutov
2014-12-18 18:40 ` Stefan Monnier
2014-12-18 19:13 ` Artur Malabarba
2014-12-19 4:31 ` Stefan Monnier
2014-12-19 12:08 ` Artur Malabarba
2014-12-18 18:37 ` Stefan Monnier
2014-12-18 15:49 ` Dmitry Gutov
2014-12-18 16:45 ` Dmitry Gutov
2014-12-18 16:14 ` Artur Malabarba
2014-12-18 15:15 ` Artur Malabarba
2014-12-18 15:45 ` Dmitry Gutov
2014-12-18 17:39 ` Artur Malabarba
2014-12-18 17:52 ` Dmitry Gutov
2014-12-18 19:01 ` Artur Malabarba
2014-12-18 19:49 ` Dmitry Gutov
2014-12-18 18:42 ` Stefan Monnier
2014-12-18 18:45 ` Dmitry Gutov
2014-12-16 16:53 ` Dmitry Gutov
2014-12-16 22:00 ` Artur Malabarba
2014-12-17 1:05 ` Dmitry Gutov
2014-12-16 23:19 ` Stefan Monnier
2014-12-16 23:40 ` Dmitry Gutov
2014-12-16 23:56 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAdUY-LCeF2HMn1mJAzy38RAZCBm=1TEdXQ8E06Bbpp2Yja8hw@mail.gmail.com' \
--to=bruce.connor.am@gmail.com \
--cc=19390@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).