* bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords
@ 2015-10-05 14:24 Artur Malabarba
2015-10-05 16:28 ` Kaushal Modi
0 siblings, 1 reply; 5+ messages in thread
From: Artur Malabarba @ 2015-10-05 14:24 UTC (permalink / raw)
To: 21619
The docstring for this function (when displayed in a help buffer) has
the following code-snippet, which clearly has the wrong type of
quotes.
(font-lock-add-keywords ’c-mode
’(("\\<\\(FIXME\\):" 1 ’font-lock-warning-face prepend)
("\\<\\(and\\|or\\|not\\)\\>" . ’font-lock-keyword-face)))
Instead of fixing this by manually escaping them, how about we change
the algorithm to only convert `...' quotes if the ... is a single
symbol?
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords
2015-10-05 14:24 bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords Artur Malabarba
@ 2015-10-05 16:28 ` Kaushal Modi
2015-10-06 9:15 ` Artur Malabarba
0 siblings, 1 reply; 5+ messages in thread
From: Kaushal Modi @ 2015-10-05 16:28 UTC (permalink / raw)
To: 21619
Artur Malabarba <bruce.connor.am <at> gmail.com> writes:
>
> The docstring for this function (when displayed in a help buffer) has
> the following code-snippet, which clearly has the wrong type of
> quotes.
>
> (font-lock-add-keywords ’c-mode
> ’(("\\<\\(FIXME\\):" 1 ’font-lock-warning-face prepend)
> ("\\<\\(and\\|or\\|not\\)\\>" . ’font-lock-keyword-face)))
>
> Instead of fixing this by manually escaping them, how about we change
> the algorithm to only convert `...' quotes if the ... is a single
> symbol?
>
>
Looks like it got fixed in this commit:
http://git.savannah.gnu.org/cgit/emacs.git/commit/?
id=47e9556c70a7009d7c750fd7bf10a0e6cf41cdce
- (sql-add-product-keywords 'ms
- '((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)))
+ (sql-add-product-keywords \\='ms
+ \\='((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)))
But while grepping for "’\([a-z(]+" in the emacs repo base dir, I found
just this one case that yet needs to be fixed:
Line 1013 of htmlfontify.info
’((class color grayscale) (type tty)) would match any of:
'((class color))
'((class grayscale))
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords
2015-10-05 16:28 ` Kaushal Modi
@ 2015-10-06 9:15 ` Artur Malabarba
2015-10-06 10:20 ` Kaushal Modi
0 siblings, 1 reply; 5+ messages in thread
From: Artur Malabarba @ 2015-10-06 9:15 UTC (permalink / raw)
To: Kaushal Modi; +Cc: 21619
2015-10-05 17:28 GMT+01:00 Kaushal Modi <kaushal.modi@gmail.com>:
> Artur Malabarba <bruce.connor.am <at> gmail.com> writes:
>
>>
>> The docstring for this function (when displayed in a help buffer) has
>> the following code-snippet, which clearly has the wrong type of
>> quotes.
>>
>> (font-lock-add-keywords ’c-mode
>> ’(("\\<\\(FIXME\\):" 1 ’font-lock-warning-face prepend)
>> ("\\<\\(and\\|or\\|not\\)\\>" . ’font-lock-keyword-face)))
>>
>> Instead of fixing this by manually escaping them, how about we change
>> the algorithm to only convert `...' quotes if the ... is a single
>> symbol?
>>
>>
>
>
> Looks like it got fixed in this commit:
>
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?
> id=47e9556c70a7009d7c750fd7bf10a0e6cf41cdce
>
>
> - (sql-add-product-keywords 'ms
> - '((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)))
> + (sql-add-product-keywords \\='ms
> + \\='((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)))
I'm confused. That link appears to be a merge commit, and the snippet
you quote doesn't apply to the snippet I had quotedl.
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords
2015-10-06 9:15 ` Artur Malabarba
@ 2015-10-06 10:20 ` Kaushal Modi
2015-10-06 10:41 ` Artur Malabarba
0 siblings, 1 reply; 5+ messages in thread
From: Kaushal Modi @ 2015-10-06 10:20 UTC (permalink / raw)
To: Bruce Connor; +Cc: 21619
[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]
I copied the wrong snippet.. But in general I saw many instances of quote
fixes in doc strings in that merge commit.
Also I do not see curvy quotes in the Help buffer that opens when I do C-h
f font-lock-add-keywords. I am on emacs built on that big merge commit
yesterday.
On Oct 6, 2015 5:15 AM, "Artur Malabarba" <bruce.connor.am@gmail.com> wrote:
> 2015-10-05 17:28 GMT+01:00 Kaushal Modi <kaushal.modi@gmail.com>:
> > Artur Malabarba <bruce.connor.am <at> gmail.com> writes:
> >
> >>
> >> The docstring for this function (when displayed in a help buffer) has
> >> the following code-snippet, which clearly has the wrong type of
> >> quotes.
> >>
> >> (font-lock-add-keywords ’c-mode
> >> ’(("\\<\\(FIXME\\):" 1 ’font-lock-warning-face prepend)
> >> ("\\<\\(and\\|or\\|not\\)\\>" . ’font-lock-keyword-face)))
> >>
> >> Instead of fixing this by manually escaping them, how about we change
> >> the algorithm to only convert `...' quotes if the ... is a single
> >> symbol?
> >>
> >>
> >
> >
> > Looks like it got fixed in this commit:
> >
> > http://git.savannah.gnu.org/cgit/emacs.git/commit/?
> > id=47e9556c70a7009d7c750fd7bf10a0e6cf41cdce
> >
> >
> > - (sql-add-product-keywords 'ms
> > - '((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)))
> > + (sql-add-product-keywords \\='ms
> > + \\='((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)))
>
> I'm confused. That link appears to be a merge commit, and the snippet
> you quote doesn't apply to the snippet I had quotedl.
>
[-- Attachment #2: Type: text/html, Size: 2365 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords
2015-10-06 10:20 ` Kaushal Modi
@ 2015-10-06 10:41 ` Artur Malabarba
0 siblings, 0 replies; 5+ messages in thread
From: Artur Malabarba @ 2015-10-06 10:41 UTC (permalink / raw)
To: Kaushal Modi; +Cc: 21619-done
Indeed. I built again today and don't see it anymore. Thanks for the pointer.
2015-10-06 11:20 GMT+01:00 Kaushal Modi <kaushal.modi@gmail.com>:
> I copied the wrong snippet.. But in general I saw many instances of quote
> fixes in doc strings in that merge commit.
>
> Also I do not see curvy quotes in the Help buffer that opens when I do C-h f
> font-lock-add-keywords. I am on emacs built on that big merge commit
> yesterday.
>
> On Oct 6, 2015 5:15 AM, "Artur Malabarba" <bruce.connor.am@gmail.com> wrote:
>>
>> 2015-10-05 17:28 GMT+01:00 Kaushal Modi <kaushal.modi@gmail.com>:
>> > Artur Malabarba <bruce.connor.am <at> gmail.com> writes:
>> >
>> >>
>> >> The docstring for this function (when displayed in a help buffer) has
>> >> the following code-snippet, which clearly has the wrong type of
>> >> quotes.
>> >>
>> >> (font-lock-add-keywords ’c-mode
>> >> ’(("\\<\\(FIXME\\):" 1 ’font-lock-warning-face prepend)
>> >> ("\\<\\(and\\|or\\|not\\)\\>" . ’font-lock-keyword-face)))
>> >>
>> >> Instead of fixing this by manually escaping them, how about we change
>> >> the algorithm to only convert `...' quotes if the ... is a single
>> >> symbol?
>> >>
>> >>
>> >
>> >
>> > Looks like it got fixed in this commit:
>> >
>> > http://git.savannah.gnu.org/cgit/emacs.git/commit/?
>> > id=47e9556c70a7009d7c750fd7bf10a0e6cf41cdce
>> >
>> >
>> > - (sql-add-product-keywords 'ms
>> > - '((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)))
>> > + (sql-add-product-keywords \\='ms
>> > + \\='((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)))
>>
>> I'm confused. That link appears to be a merge commit, and the snippet
>> you quote doesn't apply to the snippet I had quotedl.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-10-06 10:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-05 14:24 bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords Artur Malabarba
2015-10-05 16:28 ` Kaushal Modi
2015-10-06 9:15 ` Artur Malabarba
2015-10-06 10:20 ` Kaushal Modi
2015-10-06 10:41 ` Artur Malabarba
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).