From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.bugs Subject: bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords Date: Tue, 6 Oct 2015 11:41:26 +0100 Message-ID: References: Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1444128347 732 80.91.229.3 (6 Oct 2015 10:45:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 Oct 2015 10:45:47 +0000 (UTC) Cc: 21619-done@debbugs.gnu.org To: Kaushal Modi Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 06 12:45:36 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZjPkU-0002oU-7e for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Oct 2015 12:45:34 +0200 Original-Received: from localhost ([::1]:50146 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjPkT-0006uK-KX for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Oct 2015 06:45:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjPh9-0002Py-Md for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 06:42:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjPh5-00062L-3H for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 06:42:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjPh5-000628-1C for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 06:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZjPh4-0007hX-UW for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 06:42:02 -0400 Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Oct 2015 10:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 21619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 21619@debbugs.gnu.org, bruce.connor.am@gmail.com, bruce.connor.am@gmail.com Original-Received: via spool by 21619-done@debbugs.gnu.org id=D21619.144412808929560 (code D ref 21619); Tue, 06 Oct 2015 10:42:02 +0000 Original-Received: (at 21619-done) by debbugs.gnu.org; 6 Oct 2015 10:41:29 +0000 Original-Received: from localhost ([127.0.0.1]:56011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjPgX-0007gh-85 for submit@debbugs.gnu.org; Tue, 06 Oct 2015 06:41:29 -0400 Original-Received: from mail-lb0-f176.google.com ([209.85.217.176]:35174) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjPgV-0007ga-EL for 21619-done@debbugs.gnu.org; Tue, 06 Oct 2015 06:41:28 -0400 Original-Received: by lbwr8 with SMTP id r8so73477820lbw.2 for <21619-done@debbugs.gnu.org>; Tue, 06 Oct 2015 03:41:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding; bh=DVQzFpBCK+NRCZNMtH0EDMqh1Vnz7oaa3WcjCfQ0Bss=; b=ew2eE9leemRayIJn95LrVvkdTek39KDKDbUW7a5tkOyttFh+yDr/8VfbLXRa80jTUc HAaJqDzoEmQmuQeoLXBl414JNqzETKztPV+wN4IWv1a/h3+2FRkEsLbzenZ/ZId4Jfpd r2S4BAB5oWradgfDIHkQRVIlyUiU+DruKKPU3bqGWBSlBPdcsLUzgGxXl4GylFFSkoO9 h8kw73coQdqIm77fcJnYzxj0gn7iWIwroybpLjSVYL2jMAlHIGlyaU5QjnM2980Tu07D uNZ20TnUcDqzVAKaJk2B1qAueMW7qwjPXyq71X8yeTIsbSbEq0hvwk2elz/Tuq6RDWAp x7gQ== X-Received: by 10.112.54.169 with SMTP id k9mr13955839lbp.95.1444128086539; Tue, 06 Oct 2015 03:41:26 -0700 (PDT) Original-Received: by 10.25.27.78 with HTTP; Tue, 6 Oct 2015 03:41:26 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: JiWzWZkH1w8MtMQCBw2Ofj9Aq2U X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107365 Archived-At: Indeed. I built again today and don't see it anymore. Thanks for the pointe= r. 2015-10-06 11:20 GMT+01:00 Kaushal Modi : > I copied the wrong snippet.. But in general I saw many instances of quote > fixes in doc strings in that merge commit. > > Also I do not see curvy quotes in the Help buffer that opens when I do C-= h f > font-lock-add-keywords. I am on emacs built on that big merge commit > yesterday. > > On Oct 6, 2015 5:15 AM, "Artur Malabarba" wro= te: >> >> 2015-10-05 17:28 GMT+01:00 Kaushal Modi : >> > Artur Malabarba gmail.com> writes: >> > >> >> >> >> The docstring for this function (when displayed in a help buffer) has >> >> the following code-snippet, which clearly has the wrong type of >> >> quotes. >> >> >> >> (font-lock-add-keywords =E2=80=99c-mode >> >> =E2=80=99(("\\<\\(FIXME\\):" 1 =E2=80=99font-lock-warning-face prep= end) >> >> ("\\<\\(and\\|or\\|not\\)\\>" . =E2=80=99font-lock-keyword-face))= ) >> >> >> >> Instead of fixing this by manually escaping them, how about we change >> >> the algorithm to only convert `...' quotes if the ... is a single >> >> symbol? >> >> >> >> >> > >> > >> > Looks like it got fixed in this commit: >> > >> > http://git.savannah.gnu.org/cgit/emacs.git/commit/? >> > id=3D47e9556c70a7009d7c750fd7bf10a0e6cf41cdce >> > >> > >> > - (sql-add-product-keywords 'ms >> > - '((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face))) >> > + (sql-add-product-keywords \\=3D'ms >> > + \\=3D'((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face))) >> >> I'm confused. That link appears to be a merge commit, and the snippet >> you quote doesn't apply to the snippet I had quotedl.