unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: 21619-done@debbugs.gnu.org
Subject: bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords
Date: Tue, 6 Oct 2015 11:41:26 +0100	[thread overview]
Message-ID: <CAAdUY-L31Woek0i8+Om8W2tZyXSAHxm=A1JURwjH0jYV2qUdWA@mail.gmail.com> (raw)
In-Reply-To: <CAFyQvY3SH7+QQcb8K7wzkQ+Rb_KzgzoZD4ONUNumjPP3oRR4OQ@mail.gmail.com>

Indeed. I built again today and don't see it anymore. Thanks for the pointer.

2015-10-06 11:20 GMT+01:00 Kaushal Modi <kaushal.modi@gmail.com>:
> I copied the wrong snippet.. But in general I saw many instances of quote
> fixes in doc strings in that merge commit.
>
> Also I do not see curvy quotes in the Help buffer that opens when I do C-h f
> font-lock-add-keywords. I am on emacs built on that big merge commit
> yesterday.
>
> On Oct 6, 2015 5:15 AM, "Artur Malabarba" <bruce.connor.am@gmail.com> wrote:
>>
>> 2015-10-05 17:28 GMT+01:00 Kaushal Modi <kaushal.modi@gmail.com>:
>> > Artur Malabarba <bruce.connor.am <at> gmail.com> writes:
>> >
>> >>
>> >> The docstring for this function (when displayed in a help buffer) has
>> >> the following code-snippet, which clearly has the wrong type of
>> >> quotes.
>> >>
>> >> (font-lock-add-keywords ’c-mode
>> >>   ’(("\\<\\(FIXME\\):" 1 ’font-lock-warning-face prepend)
>> >>     ("\\<\\(and\\|or\\|not\\)\\>" . ’font-lock-keyword-face)))
>> >>
>> >> Instead of fixing this by manually escaping them, how about we change
>> >> the algorithm to only convert `...' quotes if the ... is a single
>> >> symbol?
>> >>
>> >>
>> >
>> >
>> > Looks like it got fixed in this commit:
>> >
>> > http://git.savannah.gnu.org/cgit/emacs.git/commit/?
>> > id=47e9556c70a7009d7c750fd7bf10a0e6cf41cdce
>> >
>> >
>> > - (sql-add-product-keywords 'ms
>> > -  '((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)))
>> > + (sql-add-product-keywords \\='ms
>> > +  \\='((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)))
>>
>> I'm confused. That link appears to be a merge commit, and the snippet
>> you quote doesn't apply to the snippet I had quotedl.





      reply	other threads:[~2015-10-06 10:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05 14:24 bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords Artur Malabarba
2015-10-05 16:28 ` Kaushal Modi
2015-10-06  9:15   ` Artur Malabarba
2015-10-06 10:20     ` Kaushal Modi
2015-10-06 10:41       ` Artur Malabarba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAdUY-L31Woek0i8+Om8W2tZyXSAHxm=A1JURwjH0jYV2qUdWA@mail.gmail.com' \
    --to=bruce.connor.am@gmail.com \
    --cc=21619-done@debbugs.gnu.org \
    --cc=kaushal.modi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).