From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.bugs Subject: bug#22616: 25.0.50; Change to lm-header breaks lm-header-multiline Date: Mon, 09 May 2016 02:13:24 +0000 Message-ID: References: <87ziv8o7zo.fsf@bernoul.li> <40c67906-d293-4af8-e3be-652fb6bf67d1@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c0b897410773c05325f5bbc X-Trace: ger.gmane.org 1462760071 9601 80.91.229.3 (9 May 2016 02:14:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 May 2016 02:14:31 +0000 (UTC) To: Dmitry Gutov , Jonas Bernoulli , 22616@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 09 04:14:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1azai4-0000VF-2A for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 May 2016 04:14:12 +0200 Original-Received: from localhost ([::1]:38871 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azai3-0002v6-Ay for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 May 2016 22:14:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azahy-0002n0-Ql for bug-gnu-emacs@gnu.org; Sun, 08 May 2016 22:14:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azahu-00038S-Bp for bug-gnu-emacs@gnu.org; Sun, 08 May 2016 22:14:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azahu-00038I-6d for bug-gnu-emacs@gnu.org; Sun, 08 May 2016 22:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1azaht-0007A8-Rz for bug-gnu-emacs@gnu.org; Sun, 08 May 2016 22:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 May 2016 02:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22616 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22616-submit@debbugs.gnu.org id=B22616.146276002327499 (code B ref 22616); Mon, 09 May 2016 02:14:01 +0000 Original-Received: (at 22616) by debbugs.gnu.org; 9 May 2016 02:13:43 +0000 Original-Received: from localhost ([127.0.0.1]:43611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azaha-00079T-Nu for submit@debbugs.gnu.org; Sun, 08 May 2016 22:13:42 -0400 Original-Received: from mail-yw0-f169.google.com ([209.85.161.169]:32792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azahY-00079D-IN for 22616@debbugs.gnu.org; Sun, 08 May 2016 22:13:41 -0400 Original-Received: by mail-yw0-f169.google.com with SMTP id t10so272824580ywa.0 for <22616@debbugs.gnu.org>; Sun, 08 May 2016 19:13:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=hbscEyShBs5+DfkmUOKAf9ZoHfLRP5DISb1SEOHGJgA=; b=j6n4kFbrETw+W6fzyFt1qOS0vnJDq4NZfzwZsU/hMSc1rIzqBtlKLwC+j8ZDT6K9Lc xErRufISPp2BDUO3anYzmB4qOZAVXHYJ9/Y0gxaTV5qCGvGkh9BXgaVP7RVwfCAaFSsf 13lUZB7aGoGG4nqhHNvzmelFbA3afj6DiUT6dKiFAvEJUlsKfpTjfL9IocSA/YxftHM5 O/u3rRvU5G918HZkKVZhhuZYoLpuoCCURXD5TJg5O6/ltJBb3rocrfHnrj1tnIMimTga tM2DIh3F5tKlJCDaO02R3A9TuDe1qOOmQcgnT6+60kZL3PfRWjGCoj3x+lux295twN6l hb/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=hbscEyShBs5+DfkmUOKAf9ZoHfLRP5DISb1SEOHGJgA=; b=dQn5soYOH4SdWJ/qb3KfZM+fDLwBLuGMw6/ifDU3EtBtT6cQNYXpGWG1z7hvl7HXPe R8iop+92v6BJScDNemMQ3vpvqFfwjKCDBhnTV9hT+xNAUFyMoKsBk5qVBpd0C+69rakN kp82AGI0NUapTiBbd/gWjiWooKc/9Vx6UE4uuwCH+JfmiwRw+POvN3EcSNlllVdQco3z w6v+B73PoxNmpHojqe9soOusTg9r+8Q1vA9sqWnuyko2/hcabxd+ZarmIe+K9nndFWs1 +EnOAU3KKFFZ1yLOj1+p6HAMdH6+HGJUO/65tJHBQREQFz+LCM1f7rKp5ylAhcaD4IkR Gg+Q== X-Gm-Message-State: AOPr4FVvMM/L6DIrRC8svizuoiz1A1uVzVFWiZU6w1JWaFEw9SWTDcq09CCO26qr+BYYHRZbvLkq5fqZrNi3aQ== X-Received: by 10.129.155.5 with SMTP id s5mr17892869ywg.43.1462760014638; Sun, 08 May 2016 19:13:34 -0700 (PDT) In-Reply-To: <40c67906-d293-4af8-e3be-652fb6bf67d1@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118013 Archived-At: --94eb2c0b897410773c05325f5bbc Content-Type: text/plain; charset=UTF-8 IIRC, I made this change because the previous behaviour caused `package-install-from-buffer' to move point. Since I saw no reason for lm-header to move point, I fixed the issue at its roots. Clearly, we've found a reason now. So the save excursion should be removed from the latter function to the former. On Sun, 8 May 2016 8:52 pm Dmitry Gutov, wrote: > Arthur, > > could you look into this one? And at the bug#22510 merged with it. > > Do you remember why you made this change? > > On 02/10/2016 06:17 PM, Jonas Bernoulli wrote: > > Starting with bf3f6a961f378f35a292c41c0bfbdae88ee1b1b9 `lm-header's body > > is wrapped with `save-excursion', but `lm-header-multiline' only works > > properly if `lm-header' doesn't do that. > > > > In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.25) > > of 2016-01-28 built on hal > > Repository revision: 9be8a2fb41043b4d4734a67f155d6923df10671b > --94eb2c0b897410773c05325f5bbc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

IIRC, I made this change because the previous behaviour caus= ed `package-install-from-buffer' to move point. Since I saw no reason f= or lm-header to move point, I fixed the issue at its roots.
Clearly, we've found a reason now. So the save excursion should be remo= ved from the latter function to the former.


On Sun, 8 May 2016 8:52 pm = Dmitry Gutov, <dgutov@yandex.ru&= gt; wrote:
Arthur,

could you look into this one? And at the bug#22510 merged with it.

Do you remember why you made this change?

On 02/10/2016 06:17 PM, Jonas Bernoulli wrote:
> Starting with bf3f6a961f378f35a292c41c0bfbdae88ee1b1b9 `lm-header'= s body
> is wrapped with `save-excursion', but `lm-header-multiline' on= ly works
> properly if `lm-header' doesn't do that.
>
> In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.25= )
>=C2=A0 of 2016-01-28 built on hal
> Repository revision: 9be8a2fb41043b4d4734a67f155d6923df10671b
--94eb2c0b897410773c05325f5bbc--