From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.bugs Subject: bug#17453: Isearch doesn't work properly with Follow Mode. Date: Mon, 2 Nov 2015 16:26:23 +0000 Message-ID: References: <20151029232302.GB3812@acm.fritz.box> <87h9l6627a.fsf@mail.linkov.net> <20151031235651.GE1853@acm.fritz.box> <87bnbddzpk.fsf@mail.linkov.net> <20151102092853.GA11804@acm.fritz.box> <20151102123512.GB11804@acm.fritz.box> <20151102154445.GD11804@acm.fritz.box> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1446481643 31425 80.91.229.3 (2 Nov 2015 16:27:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Nov 2015 16:27:23 +0000 (UTC) Cc: 17453@debbugs.gnu.org, Juri Linkov To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 02 17:27:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZtHws-0005ZO-K9 for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Nov 2015 17:27:10 +0100 Original-Received: from localhost ([::1]:43153 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtHwr-0003dV-Ju for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Nov 2015 11:27:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtHwn-0003dP-8A for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2015 11:27:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtHwk-00038y-J2 for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2015 11:27:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtHwk-00038u-FS for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2015 11:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZtHwk-0007xu-9g for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2015 11:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Nov 2015 16:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17453 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17453-submit@debbugs.gnu.org id=B17453.144648158730580 (code B ref 17453); Mon, 02 Nov 2015 16:27:02 +0000 Original-Received: (at 17453) by debbugs.gnu.org; 2 Nov 2015 16:26:27 +0000 Original-Received: from localhost ([127.0.0.1]:49898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZtHwA-0007xA-Nx for submit@debbugs.gnu.org; Mon, 02 Nov 2015 11:26:27 -0500 Original-Received: from mail-lb0-f174.google.com ([209.85.217.174]:36168) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZtHw8-0007wz-La for 17453@debbugs.gnu.org; Mon, 02 Nov 2015 11:26:25 -0500 Original-Received: by lbjm5 with SMTP id m5so91776465lbj.3 for <17453@debbugs.gnu.org>; Mon, 02 Nov 2015 08:26:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=W7ae/B+SJtOKhJClD4RyMu3rv9UMOdAkNsDEOJnAjZU=; b=NB90gVLvUd8vxPp4WIzx87ghSWkOy7EwLt3xMVSixVRPCMFzxFPFknlTT6fhndWxYT mjJus2wWi66pCm237FztPN0U8wbmIDbwaQhUIe3Zq90KVCS6+Zy9jNAsBdaA7LWLPW/0 sOUl+ToogcDdfJ+Sf5pnR5XXtLwBZEOVnaVMAQfdScZB9Bc+JtLlOTAE+qCYm+h2iOqZ d/V3buTsOVa67PCDGfgoPfoIJaSjTuD2gDkXzlp/zhMx5ESEuHl0Z00dsEdqID01Rxdq 7wjgodgZo3d/yn8tEvQTkxJp7LQ7q5C5d4wuXM5az6w5VixnoJC3Y8tygBHyk5E+jBPg 6lsQ== X-Received: by 10.112.35.196 with SMTP id k4mr10478436lbj.3.1446481583683; Mon, 02 Nov 2015 08:26:23 -0800 (PST) Original-Received: by 10.112.63.71 with HTTP; Mon, 2 Nov 2015 08:26:23 -0800 (PST) In-Reply-To: <20151102154445.GD11804@acm.fritz.box> X-Google-Sender-Auth: fWgv0Dc0xqFj-4TVNTzo_NCRg4Q X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108306 Archived-At: Hi Alan, 2015-11-02 15:44 GMT+00:00 Alan Mackenzie : > So how about us just moving all these checks to where they really > belong, in isearch-lazy-highlight-update? I've a feeling that if we do > this, then your function follow--search-function becomes unneeded. Yes, I think this might work too. And I like the idea of eliminating a redisplay inside the command-loop. Could you test it? You'll probably still need a simpler version of that follow--search-function to ensure that lazy-highlighting extends to all windows (instead of stopping inside the selected-window), but at least it won't need that `select-window' part that you said is bad. :-) >> Matches are highlighted on all windows > > Here, the matches should be highlighted on all the windows in the FM > group without exception. I think a new option you're providing allows > lazy highlighting to happen only in the current window. This is a bad > idea when FM is active. No, currently lazy highlighting to happens only in the current window (with or without follow-mode). This happens for 2 reasons. (1) Isearch only highlights between window-start and window-end, and (2) isearch limits the highlithing overlays to only be displayed on the selected window. The new option I introduced to isearch allows the highlighting overlays to be displayed on all windows (solving (2)). Furthermore, one of features of that follow--search-function function is to make sure that highlighting doesn't stop `window-end' (solving (1)).