From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.bugs Subject: bug#17453: Isearch doesn't work properly with Follow Mode. Date: Tue, 3 Nov 2015 16:18:45 +0000 Message-ID: References: <87h9l6627a.fsf@mail.linkov.net> <20151031235651.GE1853@acm.fritz.box> <87bnbddzpk.fsf@mail.linkov.net> <20151102092853.GA11804@acm.fritz.box> <20151102123512.GB11804@acm.fritz.box> <20151102154445.GD11804@acm.fritz.box> <87h9l46l7o.fsf@mail.linkov.net> <20151103123116.GD2258@acm.fritz.box> <83a8qvw0aq.fsf@gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1446567563 1143 80.91.229.3 (3 Nov 2015 16:19:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Nov 2015 16:19:23 +0000 (UTC) Cc: Alan Mackenzie , 17453@debbugs.gnu.org, Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 03 17:19:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZteIi-0003WI-2C for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Nov 2015 17:19:12 +0100 Original-Received: from localhost ([::1]:49621 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZteIh-0000VI-E4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Nov 2015 11:19:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZteId-0000Un-5C for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 11:19:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZteIZ-0005sa-5h for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 11:19:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60943) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZteIZ-0005sP-25 for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 11:19:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZteIY-0003C9-Fn for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 11:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Nov 2015 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17453 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17453-submit@debbugs.gnu.org id=B17453.144656752812257 (code B ref 17453); Tue, 03 Nov 2015 16:19:02 +0000 Original-Received: (at 17453) by debbugs.gnu.org; 3 Nov 2015 16:18:48 +0000 Original-Received: from localhost ([127.0.0.1]:51651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZteIJ-0003Bc-Lw for submit@debbugs.gnu.org; Tue, 03 Nov 2015 11:18:47 -0500 Original-Received: from mail-lf0-f43.google.com ([209.85.215.43]:35096) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZteII-0003BU-0f for 17453@debbugs.gnu.org; Tue, 03 Nov 2015 11:18:46 -0500 Original-Received: by lfbn126 with SMTP id n126so23872667lfb.2 for <17453@debbugs.gnu.org>; Tue, 03 Nov 2015 08:18:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=X74ji3eULI+iTNkUi6x7w5Ay19diL8CUOXccsrwPkfQ=; b=J5ET9hPFNe2Ktxzrikm/EQBDzOIwC0MBLCx4jzjz3G1mNTLOKyz93hxZl3qrA7JUAM Pp7iEpdDwYOSDjA9oddqR1jxvtQH2Oa9aUIFIo40Noh6YZSB1uQDyMFCahojMBFcqqqt wfGLHMsRGhHc/9HBTeufdQGC+b74nnS9rmZdnLespD8gfz8RIx184+lYeEhuv0DD+djp +wAHtLhkuVdIF3SXtvvDOweVkwJbUAC0BFk9jfgsUzln5Kn5rpwEcO6snsCI3MMucO5M EwfU1VwKfJzmrwgsIcMdZ0XKlvLYfjnuDoNgnLgiCgoOzRho6KWMhZf672EQwg5LBTd0 mABg== X-Received: by 10.112.157.105 with SMTP id wl9mr7366446lbb.2.1446567525217; Tue, 03 Nov 2015 08:18:45 -0800 (PST) Original-Received: by 10.112.63.71 with HTTP; Tue, 3 Nov 2015 08:18:45 -0800 (PST) In-Reply-To: <83a8qvw0aq.fsf@gnu.org> X-Google-Sender-Auth: IvGSbv-wLaeC4E30FoM2l8-GwKA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108358 Archived-At: 2015-11-03 15:49 GMT+00:00 Eli Zaretskii : >> This is complicated. Ideally, the Follow Mode windows should be >> synchronised in FM's post-command-hook, not isearch's. It is not >> isearch's job to realign windows. follow-post-command-hook both realigns >> windows and choses an appropriate window to put point in. We should let >> it. > > Once again, if some code in Isearch calls the same function that is > used in follow-post-command-hook, the above is not an issue. > Moreover, saving some calls to the hook will make Emacs more > responsive. I agree with Eli and Juri on this. If there's a solution as simple as calling a follow-mode function in isearch-post-update-hook, then this sounds like a no-downside solution. Of course it's not isearch's job to realign windows, but that's why the hook exists: so that other packages can run their own functions and do their own jobs at that point in time.