From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.bugs Subject: bug#22019: 25.0.50; Bad comment in `character-fold-to-regexp' Date: Thu, 26 Nov 2015 23:40:01 +0000 Message-ID: References: <3a754c45-2dc0-403f-9396-cefca118454d@default> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c34874f1563905257a178d X-Trace: ger.gmane.org 1448581277 30804 80.91.229.3 (26 Nov 2015 23:41:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 26 Nov 2015 23:41:17 +0000 (UTC) Cc: 22019@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 27 00:41:07 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a269z-0001zE-Ae for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Nov 2015 00:41:07 +0100 Original-Received: from localhost ([::1]:53573 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a26A1-0000dV-MY for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Nov 2015 18:41:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a269x-0000dB-Ls for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2015 18:41:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a269u-0003II-ET for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2015 18:41:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a269u-0003I0-A4 for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2015 18:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a269t-0001dE-TS for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2015 18:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Nov 2015 23:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22019 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22019-submit@debbugs.gnu.org id=B22019.14485812246220 (code B ref 22019); Thu, 26 Nov 2015 23:41:01 +0000 Original-Received: (at 22019) by debbugs.gnu.org; 26 Nov 2015 23:40:24 +0000 Original-Received: from localhost ([127.0.0.1]:54745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a269H-0001cG-OW for submit@debbugs.gnu.org; Thu, 26 Nov 2015 18:40:24 -0500 Original-Received: from mail-lf0-f51.google.com ([209.85.215.51]:35882) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a268w-0001bY-HM for 22019@debbugs.gnu.org; Thu, 26 Nov 2015 18:40:21 -0500 Original-Received: by lfs39 with SMTP id 39so108805900lfs.3 for <22019@debbugs.gnu.org>; Thu, 26 Nov 2015 15:40:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=MbQ+RAe9sLobmyrDuHFrta0XJTnN8+dXBlxKu+jGzqU=; b=eSGYnfXq6i+jWfo6T43sw7RptLTbkRUs9NCHlhXY3GWQ4b9AjHD4uR4oL+eDohGHtD QnMymAWm8KhhY9XIyhwdHG3GehPQwLe46lWv/RPhq+YRkP5QhSZm8Ws1P/y3yOLcCrd3 jA8p4DasLOP5PzuCW9PNWHdsplZpyaZDzilgj5QSZRLwZOd7PgA6Qv2dlILSDG9D1F+z 4ssG3dVRuNd8CWa295/aTs6Re3ta8qpUa/bS6nwlKlquD+BfbPj2pc7DfP7EmSrCoLC2 jhaTbK7HVoz8d0luXa6uslvp8yOAQ1j1COjpy20uPFqTll7P7w3dPHBiAHVt76LyvtS+ 2Nrw== X-Received: by 10.112.161.33 with SMTP id xp1mr17350866lbb.141.1448581201481; Thu, 26 Nov 2015 15:40:01 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Thu, 26 Nov 2015 15:40:01 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Thu, 26 Nov 2015 15:40:01 -0800 (PST) In-Reply-To: <3a754c45-2dc0-403f-9396-cefca118454d@default> X-Google-Sender-Auth: Au4T3QZU5ZOZHtd7B4BnYEPr-ag X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109314 Archived-At: --001a11c34874f1563905257a178d Content-Type: text/plain; charset=UTF-8 On 26 Nov 2015 11:03 pm, "Drew Adams" wrote: > > This part of an explanatory comment is inadequate and inappropriate: > > ;; See commit message for a longer description. > > What commit message? The source code should contain the description. > If a VC commit message happens to also contain the description, so > much the better for it. But that doesn't help a reader of the code. Maybe I'm just a little too acostumed to the convenience of magit-blame. Commit messages are the first place I look when I don't understand the code. But I understand that doesn't help readers who are not reading directly from the repo, so a better comment would be nice. --001a11c34874f1563905257a178d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 26 Nov 2015 11:03 pm, "Drew Adams" <drew.adams@oracle.com> wrote:
>
> This part of an explanatory comment is inadequate and inappropriate: >
> =C2=A0;; See commit message for a longer description.
>
> What commit message?=C2=A0 The source code should contain the descript= ion.
> If a VC commit message happens to also contain the description, so
> much the better for it.=C2=A0 But that doesn't help a reader of th= e code.

Maybe I'm just a little too acostumed to the convenience= of magit-blame. Commit messages are the first place I look when I don'= t understand the code. But I understand that doesn't help readers who a= re not reading directly from the repo, so a better comment would be nice. <= /p> --001a11c34874f1563905257a178d--