bug#21192: 25.0.50; search-replace of spaces erroneously touches newlines

[Artur Malabarba <bruce.connor.am@gmail.com>]

2015-08-05 16:15 GMT+01:00 Eli Zaretskii <eliz@gnu.org>:
>> From: Dima Kogan <dima@secretsauce.net>
>> Date: Wed, 05 Aug 2015 03:10:27 -0700
>> Cc: 21192@debbugs.gnu.org
>>
>> Artur Malabarba <bruce.connor.am@gmail.com> writes:
>>
>> > Is your replace-regexp-lax-whitespace variable non-nil, by any chance?
>>
>> It is nil. This issue is from 'emacs -Q'

Yes, of course, you said that. :-) Sorry

>                     (?\s "\t" "\r" "\n")))  <<<<<<<<<<<<<<<<<<<<<<<<<
>
> I think we should remove this, since replace-regexp-lax-whitespace
> already provides the same feature, and it's confusing to have that
> variable set to nil and still see such "lax" matches.

Yes. That line is from when `character-fold-to-regexp' didn't do lax
matching. Now it's definitely unnecessary.

> Regardless, I think replace commands should start with character
> folding off, as I don't think most users will want that by default,
> especially since we don't perform the reverse transformation when
> replacing, and so, say, ² is replaced with 3, not with ³.

Sure, I can move it to a variable.