From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jacob Leeming Newsgroups: gmane.emacs.bugs Subject: bug#67709: 29.1.50; [patch] missing indent rule for parameter list in csharp-ts-mode Date: Fri, 8 Dec 2023 13:44:14 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12400"; mail-complaints-to="usenet@ciao.gmane.io" To: 67709@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 08 15:19:33 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBbhV-0002yz-Gg for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Dec 2023 15:19:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rBbh2-0007Ux-TZ; Fri, 08 Dec 2023 09:19:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBbgo-0006xu-6W for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2023 09:18:52 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rBbgn-0000AV-Ta for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2023 09:18:49 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rBbh0-0004cv-LK for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2023 09:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jacob Leeming Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Dec 2023 14:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67709 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.170204509317662 (code B ref -1); Fri, 08 Dec 2023 14:19:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 8 Dec 2023 14:18:13 +0000 Original-Received: from localhost ([127.0.0.1]:44203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBbgC-0004aj-5m for submit@debbugs.gnu.org; Fri, 08 Dec 2023 09:18:12 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:46642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBb9y-00038m-V3 for submit@debbugs.gnu.org; Fri, 08 Dec 2023 08:44:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBb9b-0003eW-E1 for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2023 08:44:32 -0500 Original-Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rBb9Y-0004kE-5m for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2023 08:44:30 -0500 Original-Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-2866fe08b32so1715667a91.2 for ; Fri, 08 Dec 2023 05:44:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702043065; x=1702647865; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=DeIgLaXc7vXCrDIByfPKpFPSWQFT5bqZZGf70ARg3KM=; b=B5GwdS2w8G7TLoI6AyIzLoxB7ToayuHcs5BwkqxZZxtCW2Qrcslfx89FTNEpjuVhZy W9/JsnB+fvpCKmsussU/mHaaI+pYVPwOnWk6xS1LTwvvpNikwBavgOGIoNYLexzCZL5X qyFIO9nC4SQD/oz8XpwGd0+CF06pZsy3ckZEhgY7SJ3uHVFIIs5dimNXRxwxwXqFbQ4J 6n9OPHhdKnyZUD0b6lpbjxnwNKpB+8gYoRnMN2SaNDfqzEweEL6ZXtU98lEYi0lrtQJi tVLwJM2cMilIZ5h471qFj5qjHLKyb8Q7rnIDQ9you1Vn8qaYvhPii4+OyW0OSStiBwAN TCmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702043065; x=1702647865; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DeIgLaXc7vXCrDIByfPKpFPSWQFT5bqZZGf70ARg3KM=; b=HmfbQP1TzBRkxhI3nqVxMaqEZwllsocR6govR5zYsz/hgcgOUHmMLzzfyVCDN1XGGn GfVKN1hnt6rRc5EYC66SvNNQgnZgJ6vL2EQYaHQRD7DivPizqcB5ZST3ZwsD+bRknH4U hd50FEh8dsoNHFLL1KaOHOOrm8Abpfe/RIBi8Jck+0nEMwGGrSrV+n8DPnWbzkXG5tBe lwMkN5+rrUi53f1vj2N9ufOKUQ/MfIHQJ6qSi24Yvz9wQrhJTpjIMIl9TDxuAYFyAMj4 m1Tat8i8I9WrfHJhdCYCTiY96mQ8TZPiIlEb9E3Z28ky8N/1GgNmgGhbW79aQQjHuS4V Dxsg== X-Gm-Message-State: AOJu0Yy3kil7YAaLh6R5WwgBBzv+xBSf5NtAZDMAaamLzjZKQ7Ckbd43 cMMmNx0gGvhWdoOliBGPaP56pt9TqlavI1xyt3aaOF+Zdms= X-Google-Smtp-Source: AGHT+IGXVWYhtettYVaehvAN7J7jmIgQs05Zy1l7zDBfic3K4mAImAhZB/pQByDQB6sMldX/OdvnFvsJRQJAwsUrmBc= X-Received: by 2002:a17:90b:43:b0:288:7113:db with SMTP id d3-20020a17090b004300b00288711300dbmr56007pjt.68.1702043065218; Fri, 08 Dec 2023 05:44:25 -0800 (PST) Received-SPF: pass client-ip=2607:f8b0:4864:20::1036; envelope-from=jacobtophatleeming@gmail.com; helo=mail-pj1-x1036.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 08 Dec 2023 09:18:11 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275774 Archived-At: >From emacs -Q: Evaluate this elisp to set up treesitter for csharp: (setq treesit-language-source-alist '((c-sharp "https://github.com/tree-sitter/tree-sitter-c-sharp" "master" "src")) treesit-load-name-override-list '((c-sharp "libtree-sitter-csharp" "tree_sitter_c_sharp")) major-mode-remap-alist '((csharp-mode . csharp-ts-mode))) Insert the following text into a csharp-ts-mode buffer: void ExampleFunction( int arg1, int arg2, int arg3, int arg4, int arg5 ) { Console.WriteLine(arg1); } Try to indent the parameters of the function with indent-for-tab-command. Nothing will happen. This issue can be fixed with the following patch: diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el index 53c52e6..8cc4e95 100644 --- a/lisp/progmodes/csharp-mode.el +++ b/lisp/progmodes/csharp-mode.el @@ -704,7 +704,8 @@ csharp-ts-mode--indent-rules ((parent-is "object_type") parent-bol csharp-ts-mode-indent-offset) ((parent-is "enum_body") parent-bol csharp-ts-mode-indent-offset) ((parent-is "arrow_function") parent-bol csharp-ts-mode-indent-offset) - ((parent-is "parenthesized_expression") parent-bol csharp-ts-mode-indent-offset)))) + ((parent-is "parenthesized_expression") parent-bol csharp-ts-mode-indent-offset) + ((parent-is "parameter_list") parent-bol csharp-ts-mode-indent-offset)))) (defvar csharp-ts-mode--keywords '("using" "namespace" "class" "if" "else" "throw" "new" "for"