From: Nikolaos Chatzikonstantinou <nchatz314@gmail.com>
To: 74133@debbugs.gnu.org
Subject: bug#74133: Some minor patches for the python script
Date: Thu, 31 Oct 2024 07:02:21 -0400 [thread overview]
Message-ID: <CAAQmekf6LwRKvrNN6FVOSQYTiBBEF=yBMomOyKMwER=VX0d-nA@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 286 bytes --]
Hello,
From a quick discussion on IRC I've decided to contribute the
following two patches. The first is stylistic but the second is
something that was requested. Note that I've already assigned
copyright to the FSF for my contributions to Emacs.
Regards,
Nikolaos Chatzikonstantinou
[-- Attachment #2: 0002-download-zst-msys2-sources-before-gzip.patch.asc.asc --]
[-- Type: text/plain, Size: 228 bytes --]
-----BEGIN PGP SIGNATURE-----
iHUEABYKAB0WIQT+qiF+WQ7fQkkAb/UJFDAFinzxjQUCZyNjjQAKCRAJFDAFinzx
jdQKAQCKXqJFxzoPveIrln/stYDBT5jBHTIXqj9QUtQcqWT/dwEA6Xr0/yOuqTou
7tes6FR5eMuanAqiRZ8ajRhyJzA0eA4=
=cWPQ
-----END PGP SIGNATURE-----
[-- Attachment #3: 0002-download-zst-msys2-sources-before-gzip.patch.asc --]
[-- Type: text/plain, Size: 1426 bytes --]
-----BEGIN PGP MESSAGE-----
owJ4nI1Vz28bRRR2Q4rUkUAgaA5ISK+OEDbxrNdrx04sQpyatLQoP4gLCCJkze7O
boZ4d1Y7s3Htthw4ISQQPSGuCAmpCIkDHIAbEhK9wIFbL/0DEAckClIPEW9tbxOo
UL2ydj1v3/ve9715b/ajRx7KkblTT5on37/6xwcnvnz4ol0xTdOiruyHPclcOlSa
BmqgLKpkEjtcUZt7MubUH4rIiJh29vx5+/BcLAPwLJNXa+6SV1/yrGXOmWWzBjNt
r97wzJrFuF1vuFbNgQ0ZQodHUGmAaTZHP7BMs0JSmCZsin3ZY1JBe4/pIS5CpVmo
RSgTeD50UmO1Umv5ARM9w5HBC+RFpnkTLu0lJahWYMvRCGfVwKw3a4vNxSpQs2aa
pJPYb3NHN2F3e+1S+yWwytZbkCkFVAojpTBRCmOlkColhLmBCMuhLrsCS2InoueW
R3fq8oiiizKiARR8pvd43B1DFFNOHKKYHwiZKHLAYyVQO1MqCbgLGqUA6/UmGUGz
2Malgj6f5AWUh+FKcddALKFAKBLKNKrPBgoRODhM8RJiIkrAgWGkDHsDYAdYHmb3
OIgwFWfA6ykVIWOhxZCTVG+GPiIVuuNA4cEow734PqJqzYNIjzgZhFJKYLqCXIUl
WBhdaUwFPIGAuIWhz90S1JGb4rHG/KqwUCyBBS7v8fGaFglxhecBpb5APuXpMtrT
+RERuvwy2LbpeQ1etWzPMEzLcrjNucs8wDloLC6mUqfNTFDk1NlbLaBWtdSAhdG9
1SIggkjGGrwkdLSUPXXPIiMeMy1jAoR66aCpxI5iiS2qMhdnjzv7XZnoKNFkYQqn
ErSx07i7PXZZj+MRPszPQ3syb0hgfWOt3elurF3c2um+tr7TubC1uZK3lvJj+ma9
tIz88VGpogLcOg/+1f8FVKyKTQLZheidvsAzA0IW4ISlrcbT/CweHHlF+343fQ8r
sPHq5vn1bmen3d1++XzH8LkuZG9L2Z8i8l7IYnGE0sZegfyVa/TKNUPFjoE2A415
A8c5YP9BmMxk8Sj9ZArvx/CHD4IgNAPJjpWsEhPQ4jGm8aB5tPqfGKR9LIRfdjgO
4f0792CgcXIYq8RTINSF/JsiikTo5yfaj7dHN2ADmxfy6RFEl8EwyjxgjqKjgqS7
SrHJ/T7t12s0LU/q91wepwWIZVSXjUVC3ktmc3Mk9/TcmdnDG2feeePR22cv5OSd
7GNzcib9buTIqccyy+43J3J3bt69SWdeeWrz9BfP/vXt4x/++PEPzZ8+/X72979X
V7/68yzJHRa7d3+9/l3xl91nbv28Gnx++rPfSteXzt2Y+XruXcP45ImZfwADiz7i
=WHoO
-----END PGP MESSAGE-----
[-- Attachment #4: 0001-add-docstrings.patch.asc --]
[-- Type: text/plain, Size: 228 bytes --]
-----BEGIN PGP SIGNATURE-----
iHUEABYKAB0WIQT+qiF+WQ7fQkkAb/UJFDAFinzxjQUCZyNjiQAKCRAJFDAFinzx
jcNLAP9DtWVlcVWKjTMvhRZcXrvowjLOz3RloUHR7ELTNDhgngEA58GWtwFxwOCj
T1FD+wKU0gqk/SAAZbeO39whYY3uogY=
=dGP+
-----END PGP SIGNATURE-----
[-- Attachment #5: 0001-add-docstrings.patch --]
[-- Type: text/x-patch, Size: 1998 bytes --]
From 62a534d527b79a5ff62b73940e8f604f8db1f325 Mon Sep 17 00:00:00 2001
From: Nikolaos Chatzikonstantinou <nchatz314@gmail.com>
Date: Thu, 31 Oct 2024 06:37:31 -0400
Subject: [PATCH 1/2] add docstrings
* admin/nt/dist-build/build-dep-zips.py: Change some top-level comments
to docstrings.
---
admin/nt/dist-build/build-dep-zips.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/admin/nt/dist-build/build-dep-zips.py b/admin/nt/dist-build/build-dep-zips.py
index 0b1cc4d8695..bb0ff7e32bf 100755
--- a/admin/nt/dist-build/build-dep-zips.py
+++ b/admin/nt/dist-build/build-dep-zips.py
@@ -62,8 +62,8 @@ def check_output_maybe(*args,**kwargs):
else:
return check_output(*args,**kwargs)
-## DLL Capture
def gather_deps():
+ """DLL Capture"""
os.mkdir("x86_64")
os.chdir("x86_64")
@@ -78,13 +78,13 @@ def gather_deps():
shell=True)
os.chdir("../")
-## Return all Emacs dependencies
def full_dll_dependency():
+ """Return all Emacs dependencies"""
deps = [dll_dependency(dep) for dep in DLL_REQ]
return set(sum(deps, []) + DLL_REQ)
-## Dependencies for a given DLL
def dll_dependency(dll):
+ """Dependencies for a given DLL"""
output = check_output(["/mingw64/bin/ntldd", "--recursive",
"/mingw64/bin/{}*.dll".format(dll)]).decode("utf-8")
## munge output
@@ -141,8 +141,8 @@ def immediate_deps(pkgs):
return dependencies
-## Extract all the msys2 packages that are dependencies of our direct dependencies
def extract_deps():
+ """Extract all the msys2 packages that are dependencies of our direct dependencies"""
print( "Extracting deps" )
@@ -178,8 +178,8 @@ def download_source(tarball):
"{}".format(tarball))
-## Fetch all the source code
def gather_source(deps):
+ """Fetch all the source code"""
if not os.path.exists("emacs-src-cache"):
os.mkdir("emacs-src-cache")
--
2.39.5
next reply other threads:[~2024-10-31 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 11:02 Nikolaos Chatzikonstantinou [this message]
2024-10-31 11:06 ` bug#74133: Wrong files attached Nikolaos Chatzikonstantinou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAQmekf6LwRKvrNN6FVOSQYTiBBEF=yBMomOyKMwER=VX0d-nA@mail.gmail.com' \
--to=nchatz314@gmail.com \
--cc=74133@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).