* bug#55007: Minibuffer prompt is incorrect in Viper mode since commit 50512e3 @ 2022-04-18 19:12 atheik 2022-04-19 11:48 ` Lars Ingebrigtsen 0 siblings, 1 reply; 4+ messages in thread From: atheik @ 2022-04-18 19:12 UTC (permalink / raw) To: 55007 The use of 'format-prompt' in 'lisp/emulation/viper-cmd.el' results in incorrect minibuffer prompts in Viper mode. It does not make sense to append ": " to the minibuffer prompt when entering commands in command mode. Commit 50512e3 also changed the behavior such that the default prompt does not disappear when a character is entered into the minibuffer when entering a command in command mode. Please consider reverting the changes done in commit 50512e3 for 'lisp/emulation/viper-cmd.el'. ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#55007: Minibuffer prompt is incorrect in Viper mode since commit 50512e3 2022-04-18 19:12 bug#55007: Minibuffer prompt is incorrect in Viper mode since commit 50512e3 atheik @ 2022-04-19 11:48 ` Lars Ingebrigtsen 2022-04-19 12:54 ` Eli Zaretskii 0 siblings, 1 reply; 4+ messages in thread From: Lars Ingebrigtsen @ 2022-04-19 11:48 UTC (permalink / raw) To: atheik; +Cc: 55007 atheik <atteh.mailbox@gmail.com> writes: > Please consider reverting the changes done in commit 50512e3 for > 'lisp/emulation/viper-cmd.el'. I've now done so in Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#55007: Minibuffer prompt is incorrect in Viper mode since commit 50512e3 2022-04-19 11:48 ` Lars Ingebrigtsen @ 2022-04-19 12:54 ` Eli Zaretskii 2022-04-20 10:37 ` Lars Ingebrigtsen 0 siblings, 1 reply; 4+ messages in thread From: Eli Zaretskii @ 2022-04-19 12:54 UTC (permalink / raw) To: Lars Ingebrigtsen; +Cc: atteh.mailbox, 55007 > From: Lars Ingebrigtsen <larsi@gnus.org> > Date: Tue, 19 Apr 2022 13:48:16 +0200 > Cc: 55007@debbugs.gnu.org > > atheik <atteh.mailbox@gmail.com> writes: > > > Please consider reverting the changes done in commit 50512e3 for > > 'lisp/emulation/viper-cmd.el'. > > I've now done so in Emacs 29. Shouldn't we do this on the release branch instead? I thought this was a regression in Emacs 28.1? ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#55007: Minibuffer prompt is incorrect in Viper mode since commit 50512e3 2022-04-19 12:54 ` Eli Zaretskii @ 2022-04-20 10:37 ` Lars Ingebrigtsen 0 siblings, 0 replies; 4+ messages in thread From: Lars Ingebrigtsen @ 2022-04-20 10:37 UTC (permalink / raw) To: Eli Zaretskii; +Cc: atteh.mailbox, 55007 Eli Zaretskii <eliz@gnu.org> writes: > Shouldn't we do this on the release branch instead? I thought this > was a regression in Emacs 28.1? The bug report didn't mention an Emacs version. But I see you're right, so I've cherry-picked this for emacs-28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-20 10:37 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-04-18 19:12 bug#55007: Minibuffer prompt is incorrect in Viper mode since commit 50512e3 atheik 2022-04-19 11:48 ` Lars Ingebrigtsen 2022-04-19 12:54 ` Eli Zaretskii 2022-04-20 10:37 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).