From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andrey Orst Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 16 Oct 2019 14:17:27 +0300 Message-ID: References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a505bf05950540ab" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="191698"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org To: Ergus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 15:48:51 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKjfW-000neq-2F for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 15:48:50 +0200 Original-Received: from localhost ([::1]:42908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKjfT-0003vF-Pc for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 09:48:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59701) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKjdo-0002s2-M4 for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 09:47:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKjdn-0002oj-4n for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 09:47:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36627) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKjdm-0002oX-Vo for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 09:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKjdm-0000VU-Sg for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 09:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrey Orst Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 13:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.15712335871878 (code B ref 37774); Wed, 16 Oct 2019 13:47:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 16 Oct 2019 13:46:27 +0000 Original-Received: from localhost ([127.0.0.1]:45442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKjdB-0000U6-7l for submit@debbugs.gnu.org; Wed, 16 Oct 2019 09:46:25 -0400 Original-Received: from mail-yb1-f174.google.com ([209.85.219.174]:46912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKhJZ-0003Iu-Bo for 37774@debbugs.gnu.org; Wed, 16 Oct 2019 07:18:01 -0400 Original-Received: by mail-yb1-f174.google.com with SMTP id h202so7647520ybg.13 for <37774@debbugs.gnu.org>; Wed, 16 Oct 2019 04:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VY0NvRvjaZ1lnHL+vZd5piCeAsRpCGji5xAz7aNqmPI=; b=jpIjU2Gd+vb5mLNovVrJbkwZEUh4xoDaiRJ2XslhP58xya+r2j2aHCHaf3XczpXDsL 3xcg8KROuDj6A9kkMqEyxeirDMNnitmPdlscgJSDOK0AlHS1G6mbwpYW++8jt64dAtTt 6LzNEDsqBpFaqoJA41VEam3XlMS9/PcZP0J/COATHi/voAHnkqn4JKl6fl46NB62L2bD BSUMfMAu2NZ6X6c+1omgrPox29dmaAeM3ZRLn8pWAPjXd2PPZnuVwfRCZUlN0jZ/2g6z VdKA5wGuPZwYemGyQkLret3zMgfjFCL0zP9if4uVzzfp6ytQXrgcYXLFxnzZnh4fmwVv pt5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VY0NvRvjaZ1lnHL+vZd5piCeAsRpCGji5xAz7aNqmPI=; b=I1zdEmymrMmQsf6O1pY1dryso2zfo6h9MemXuYZQSMcp9kO3pX6S5I1vUTn4Zq09bc qChknml2IMhbXa914AGMkuYrhZS7ORRiNpsl2NT39qoPg/77z56jMyuDPVfYMBh3pOZY FsU7Qls3EYHGAS4NiVdSDjLj8nS9f5MoYnIKJci7HhgsrKu9YX1sJEwUbeSuIqHhOtIP wLjn16JgYvf3EKSrzbpDeg/HOv5BCpbB3hKlQsUTKzKZYt8jOTRbNI02Brst7x1h7yTY Uuhs0vuJjCLr9n2vOrZXDOUGBKQE15Y2GGx2rN9LpVh3bNAd+gecPuo0BYFc4W5B+ltC wJBw== X-Gm-Message-State: APjAAAUdajqOj6UmofVnJ+se0gLrIg7N3PUXZpcWwmAPz1F3fe5aTEwC cHo0WuR6oxbEwOvOlFMcPYlLbJjr5QPrBCNOgho= X-Google-Smtp-Source: APXvYqwgTKJtU9TdOtIT6yfj1sQBwULUMlo0lifIsm8j0o2vZMJixRQ8suvMLyYz4eqAwB25lWJWIS7/mlrL6S5A1aI= X-Received: by 2002:a5b:582:: with SMTP id l2mr27514768ybp.72.1571224675483; Wed, 16 Oct 2019 04:17:55 -0700 (PDT) In-Reply-To: <20191016111004.oialbyleokafpccz@Ergus> X-Mailman-Approved-At: Wed, 16 Oct 2019 09:46:22 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169453 Archived-At: --000000000000a505bf05950540ab Content-Type: text/plain; charset="UTF-8" > So you are saying that you don't like the new appearance? The Subject > says "broke visuals", which sounds like a much more serious problem. Well, "broke" may be wrong term, here, but lot of themes and packages crafted in a way to display things like that, and now all of those things displayed accordingly to a new setting, which in turn means that: a) package maintainers should update *all* their packages to look like before the change, and b) maybe Emacs could treat `nil` here as "do not affect", and specify symbols to set this to different settings, like `:extend t` or `:extend 'EOL`, and `:extend 'noextend` to disable. Though, I do not know how code was changed, so maybe there's no way to treat `nil` as "do not affect". On Wed, Oct 16, 2019 at 2:10 PM Ergus wrote: > Hi Eli and Martin: > > I have seen these reports and also the ones in reddit. Do you think that > we should/must/can do anything about? > > > > On Wed, Oct 16, 2019 at 10:53:21AM +0300, Eli Zaretskii wrote: > >> From: Andrey Orst > >> Date: Wed, 16 Oct 2019 10:00:38 +0300 > >> > >> Somewhat last checkout from master brought the change of face > >> attributes, adding new `:extend` attribute, which make all themes, and > >> packages like Magit display weirdly. By this I mean that before the > >> change, some faces were set up to extend highlighting beyond EOL, but > >> now all of those faces are not doing this. I've first reported this to > >> the theme package I'm using: > >> https://github.com/hlissner/emacs-doom-themes/issues/342 but I think > >> that this should be handled by emacs itself, because if not it will > >> result in the duplicated or extra code in themes fro different Emacs > >> versions. This reddit post has some screenshots of what I mean: > >> > https://www.reddit.com/r/emacs/comments/diahh1/emacs_27_update_changed_how_highlighted_lines/ > > > >The screenshots you posted don't clearly explain the problem. Some of > >them seem actually identical before and after the change, and with > >others I don't think I see the problem. > > > >So please explain what exactly is incorrect or "weird" in the visual > >appearance after the change. Specifically, why the faces in question > >need to be extended past EOL? > > > >Thanks. > -- Best regards, Andrey Listopadov --000000000000a505bf05950540ab Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> So you are saying that you don't= like the new appearance?=C2=A0 The Subject
> says "broke visual= s", which sounds like a much more serious problem.

Well,= "broke" may be wrong term, here, but lot of themes and packages = crafted
in a way to display things like that, and now all of thos= e things displayed accordingly
to a new setting, which in turn me= ans that:

a) package maintainers should update *al= l* their packages to look like before the change, and
b) maybe Em= acs could treat `nil` here as "do not affect", and specify symbol= s to set this to different
=C2=A0 =C2=A0settings, like `:extend t= ` or `:extend 'EOL`, and `:extend 'noextend` to disable. Though, I = do not
=C2=A0 =C2=A0know how code was changed, so maybe there'= ;s no way to treat `nil` as "do not affect".

On Wed, Oct 16, 2019= at 2:10 PM Ergus <spacibba@aol.com<= /a>> wrote:
H= i Eli and Martin:

I have seen these reports and also the ones in reddit. Do you think that we should/must/can do anything about?



On Wed, Oct 16, 2019 at 10:53:21AM +0300, Eli Zaretskii wrote:
>> From: Andrey Orst <andreyorst@gmail.com>
>> Date: Wed, 16 Oct 2019 10:00:38 +0300
>>
>> Somewhat last checkout from master brought the change of face
>> attributes, adding new `:extend` attribute, which make all themes,= and
>> packages like Magit display weirdly.=C2=A0 By this I mean that bef= ore the
>> change, some faces were set up to extend highlighting beyond EOL, = but
>> now all of those faces are not doing this.=C2=A0 I've first re= ported this to
>> the theme package I'm using:
>> https://github.com/hlissner/emacs-d= oom-themes/issues/342 but I think
>> that this should be handled by emacs itself, because if not it wil= l
>> result in the duplicated or extra code in themes fro different Ema= cs
>> versions.=C2=A0 This reddit post has some screenshots of what I me= an:
>> https://www.reddit.com/r/emacs/comments/diahh1/emacs_27_update_changed_ho= w_highlighted_lines/
>
>The screenshots you posted don't clearly explain the problem.=C2=A0= Some of
>them seem actually identical before and after the change, and with
>others I don't think I see the problem.
>
>So please explain what exactly is incorrect or "weird" in the= visual
>appearance after the change.=C2=A0 Specifically, why the faces in quest= ion
>need to be extended past EOL?
>
>Thanks.


--
Best regards,
Andrey Listopadov
<= /div>
--000000000000a505bf05950540ab--