From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andrey Orst Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 16 Oct 2019 21:07:53 +0300 Message-ID: References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005968ab05950afb36" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="21357"; mail-complaints-to="usenet@blaine.gmane.org" To: 37774@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 20:09:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKnjZ-0005Pr-1g for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 20:09:17 +0200 Original-Received: from localhost ([::1]:46728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKnjX-0001Zo-Dh for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 14:09:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50431) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKnjL-0001YK-Nf for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 14:09:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKnjK-0006ZU-Az for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 14:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37675) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKnjK-0006ZF-4L for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 14:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKnjJ-0007FM-T2 for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 14:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrey Orst Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 18:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157124929127795 (code B ref 37774); Wed, 16 Oct 2019 18:09:01 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 16 Oct 2019 18:08:11 +0000 Original-Received: from localhost ([127.0.0.1]:46496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKniV-0007ED-1N for submit@debbugs.gnu.org; Wed, 16 Oct 2019 14:08:11 -0400 Original-Received: from mail-yw1-f42.google.com ([209.85.161.42]:37314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKniS-0007Dw-I7 for 37774@debbugs.gnu.org; Wed, 16 Oct 2019 14:08:09 -0400 Original-Received: by mail-yw1-f42.google.com with SMTP id m7so8970630ywe.4 for <37774@debbugs.gnu.org>; Wed, 16 Oct 2019 11:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=KIUEo7gN+zYb2yjK70nFoApfCYBgaaF+MdM7FGmLT5Q=; b=f+qWvW3Hi0sw6mYWpaF6lvQ0IwB6ujj35NGhjjfxnHlGBvP8t49zEof1sX32+5U3gG OkVDlCSa+/S1p0Qn0AobuF4LkDV5n7TJjctjGRWGF6NAMXptvsV3F5pe1KRNlw0ElR2v c9iY9Jr6HR4mVOFQ8zHfk5Ar4zCCEUyQF8kcBSM5j4V3socBIdJNWTQIgt5e9xFVBvVz Ckkir6H87F/Ot9kdjwaCeBtr6O0NKLiGu1e3oCxS7IJ1W5cOIBeTmMODugsn7ynjUKCL IH2gvdr9a9d1zb167vc8ptXh2q+JK6xBBxSxtpUyqYSHNb5CGvpkBJNyNDI9+eqG6Aks atSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=KIUEo7gN+zYb2yjK70nFoApfCYBgaaF+MdM7FGmLT5Q=; b=XGZ2dPIHBCgxOk8xIlpYOciXQQn8W1p0n0PN5b5MBkYeVZ+Rwbiu/M5TXBAnBC56Bt W1Q4z2jyCRjbPBgfDaBxdcDwvfPJBQUfSsWKxhTPUs2pDNxVD9RhWi2B4AAIUOjeWScS bxotzGdCwzmlOi1UDRmjwShqYu5TlzGT4SaCOdm4Bk85LSw3Wr2MKIIsO5tyEyPreuBf LS/dY01kMCfWX08v2VyJxY15PXnRx6HTJunhlbEW+XsQg+sXPvqUrolHzUOzqvGmC7LF AzeljZ079gyzvS5xijvsyhqkHxs1uvtJIr42KVd1xRa9kIrJT/Kc+mQ8/LQ12Zom4hwi qaIQ== X-Gm-Message-State: APjAAAV6eKFeviUMSAUgCKY5oLqk6v8gx8o1NEq3QVL9gElhtn9W3BhR AbhJW1yT5RpYUREyyTYkTbquLAkjjStgs/URL0umbdSj X-Google-Smtp-Source: APXvYqwzk4NQjUgehgdybQ+7UTgRNR6omFPkFnDCXPT/t+lKgfecibaVYsszV7vws6A7pq/CQ0biMsJH0x61FuODURQ= X-Received: by 2002:a81:70d6:: with SMTP id l205mr22679041ywc.297.1571249282704; Wed, 16 Oct 2019 11:08:02 -0700 (PDT) In-Reply-To: <87k194fvn7.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169472 Archived-At: --0000000000005968ab05950afb36 Content-Type: text/plain; charset="UTF-8" > Here's an edited image to demonstrate an ideal look of such background faces > (note how the mode-line is wider, and blocks are narrower than window width): I like the unedited example a bit more, especially if we're talking about side by side diffs, like ediff. I think that this may be controlled by a variable named something like `trim-eol-face-at-fill-column' On Wed, Oct 16, 2019 at 8:36 PM Juri Linkov wrote: > > > I have seen these reports and also the ones in reddit. Do you think that > > we should/must/can do anything about? > > Two major problems: > > 1. Backward-compatibility problem: > > I had to spend significant time investigating why the region face broke > recently, and discovered that customized faces in custom-set-faces need > to be updated. Soon I tired fixing their customizations one by one manually, > so I wrote a function that automatically fixes all faces. I wonder > how all other users are supposed to get out of a similar situation. > > Moreover, the problem is wider than personal customization > and affects hundreds of existing themes. > > 2. Conceptual problem: > > We need to think again what this change was intended to fix? > > All faces could be divided into two more-less equally large groups: > > a. faces with distinct foreground that highlight text properties, > they include mostly font-lock faces, underline faces, and so on; > > b. faces with distinct background that highlight blocks of text, > such as the region face, diff hunk faces, etc. > > As I see the change was meant to fix only the problem that relates to > faces with distinct foreground, because indeed underlines extended > to the window edge look very ugly. So the change should affect > only faces with distinct foreground. > > But faces for multi-line regions with a distinct background color > require to look like rectangular blocks. > > This screenshot demonstrates how badly broken these blocks are now > in diff-mode that it makes harder to read diffs: > > > And this shows how they looked like rectangular blocks before the change: > > > Frankly speaking, this is not great too because long stretches are ugly. > Ideally to be more nice-looking, background colors in such faces should be > extended to the column defined e.g. by display-fill-column-indicator-column. > > Here's an edited image to demonstrate an ideal look of such background faces > (note how the mode-line is wider, and blocks are narrower than window width): > > > So what would pacify the current situation is to extend to eol > only foreground colors. But background colors should be extended to > some predefined fixed column such as fill-column to have a look of blocks. -- Best regards, Andrey Orst --0000000000005968ab05950afb36 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Here's an edited image to demonstrate an ideal lo= ok of such background faces
> (note how the mode-line is wider, and b= locks are narrower than window width):

I like the unedited example a= bit more, especially if we're talking about side by side diffs, like e= diff.
I think that this may be controlled by a variable named something = like `trim-eol-face-at-fill-column'

On Wed, Oct 16, 2019 at 8:36= PM Juri Linkov <juri@linkov.net&= gt; wrote:
>
> > I have seen these reports and also the ones= in reddit. Do you think that
> > we should/must/can do anything a= bout?
>
> Two major problems:
>
> 1. Backward-compa= tibility problem:
>
> I had to spend significant time investiga= ting why the region face broke
> recently, and discovered that custom= ized faces in custom-set-faces need
> to be updated.=C2=A0 Soon I tir= ed fixing their customizations one by one manually,
> so I wrote a fu= nction that automatically fixes all faces.=C2=A0 I wonder
> how all o= ther users are supposed to get out of a similar situation.
>
> = Moreover, the problem is wider than personal customization
> and affe= cts hundreds of existing themes.
>
> 2. Conceptual problem:
= >
> We need to think again what this change was intended to fix?>
> All faces could be divided into two more-less equally large = groups:
>
> a. faces with distinct foreground that highlight te= xt properties,
> they include mostly font-lock faces, underline faces= , and so on;
>
> b. faces with distinct background that highlig= ht blocks of text,
> such as the region face, diff hunk faces, etc.>
> As I see the change was meant to fix only the problem that r= elates to
> faces with distinct foreground, because indeed underlines= extended
> to the window edge look very ugly.=C2=A0 So the change sh= ould affect
> only faces with distinct foreground.
>
> Bu= t faces for multi-line regions with a distinct background color
> req= uire to look like rectangular blocks.
>
> This screenshot demon= strates how badly broken these blocks are now
> in diff-mode that it = makes harder to read diffs:
>
>
> And this shows how they= looked like rectangular blocks before the change:
>
>
> = Frankly speaking, this is not great too because long stretches are ugly.> Ideally to be more nice-looking, background colors in such faces shou= ld be
> extended to the column defined e.g. by display-fill-column-in= dicator-column.
>
> Here's an edited image to demonstrate a= n ideal look of such background faces
> (note how the mode-line is wi= der, and blocks are narrower than window width):
>
>
> So= what would pacify the current situation is to extend to eol
> only f= oreground colors.=C2=A0 But background colors should be extended to
>= some predefined fixed column such as fill-column to have a look of blocks.=



--
Best regards,
Andrey Orst
--0000000000005968ab05950afb36--