From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andrey Orst Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 16 Oct 2019 15:08:53 +0300 Message-ID: References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <8336fsgbof.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000008e39c3059505f8ba" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="189005"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 15:48:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKjez-000n03-4Q for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 15:48:17 +0200 Original-Received: from localhost ([::1]:42902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKjex-0003Zu-SV for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 09:48:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59716) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKjdp-0002st-Hm for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 09:47:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKjdo-0002pb-2q for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 09:47:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36630) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKjdn-0002pT-WD for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 09:47:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKjdn-0000Vk-TG for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 09:47:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrey Orst Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 13:47:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.15712335891893 (code B ref 37774); Wed, 16 Oct 2019 13:47:03 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 16 Oct 2019 13:46:29 +0000 Original-Received: from localhost ([127.0.0.1]:45446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKjdE-0000UN-A8 for submit@debbugs.gnu.org; Wed, 16 Oct 2019 09:46:28 -0400 Original-Received: from mail-yw1-f47.google.com ([209.85.161.47]:39254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKi7K-0006bm-O1 for 37774@debbugs.gnu.org; Wed, 16 Oct 2019 08:09:27 -0400 Original-Received: by mail-yw1-f47.google.com with SMTP id n11so8545019ywn.6 for <37774@debbugs.gnu.org>; Wed, 16 Oct 2019 05:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=28uJ1p8BRLFzKj1SW4M+DiOPE2N6ER5EGq7AQaaQCXA=; b=aM8CRZYhAsMclzI6h8Mqbm+Bvr70w8ngb1vgHcb8TsLJiqp0up3F2DuDoQ7FPaPDB8 lOHqZLvL4+W7YEZbT9N6zY6nEwjyfLFjc1V0ndKTqQzMVrYsbPYelx5feDxz7smspc3V 6vB4ZOGkekDAqNungtW2kbznKPrJDQFbU/UNTr8U84/N/RM55JcVnNuWIJ/nCLU30KlU So/lK+eFGcOW/EGZqaVG4xBCwtwUysUwTTfXgGo6aHasntiIZl2b4fRhzJrJVd+kVzQi 9C4auCX+qKMvm7sykt7BDSXawmmHbzoxZ7Ndrl293jZB+cq+vHfWWA2S1N2Ab687numP Cuyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=28uJ1p8BRLFzKj1SW4M+DiOPE2N6ER5EGq7AQaaQCXA=; b=iQzy6vBBIbku33eSsdGO1tGRXjYcZIDJkCJu5Emn/PqbGzhK/PudyzUuEveoRN1DrE 86PEnMjUW/4DRzSB2lF8s3edN8+GPxTJ8KqPPUOhHDTuhroJTHP6AcWz3fjC3gzQ3r0q CAR6a3a8CzkcoaU+9l05AojsuOmAd/D2xzX5/zGwjzja/A4dtjMrU8zbLCJGwU1MRvDk 91RD7S8rFgFohCOLQilOLl7zYXfB3AE/oWEy3tfWcKksn/CV8OL3DpucyTLTXK+GfwnK 25CEJEZD++FYF9Mk+VQHn54qlJXfRRwfAvNtRZg+lDPNvO6Wt+PDJ14yZgyyxT3ehJ/B gnvQ== X-Gm-Message-State: APjAAAUM9rsHNi15jHAhRkEAuOk84fs9Fwdmaku89U7N6S0zANhCIrcU cnMSTFjpgvRJbPjPK7vgHbtZRYIvr/AS99xKgn0= X-Google-Smtp-Source: APXvYqyk5C/PwLT6UEzVSyEEYhemv2HS6u5RnBiiFdCfKLY390l7vw1eXUwca00p0/YYoskjrsifttozUf750SkghYw= X-Received: by 2002:a81:c8c:: with SMTP id 134mr21811554ywm.205.1571227760997; Wed, 16 Oct 2019 05:09:20 -0700 (PDT) In-Reply-To: <8336fsgbof.fsf@gnu.org> X-Mailman-Approved-At: Wed, 16 Oct 2019 09:46:22 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169451 Archived-At: --0000000000008e39c3059505f8ba Content-Type: text/plain; charset="UTF-8" > Are you saying that _all_ the faces will have to be modified to make > them extended? IOW, are you saying that this feature is wrong with > most or all of the faces? I don't know about /all/ faces, but I have experienced a lot of visual changes when using `doom-one' theme provided by `doom-themes' package paired with at least these packages: magit, ediff, solaire-mode, org-mode. > The assumption behind this feature was that the absolute majority of > faces don't need to be extended. If you say this is wrong, can you > show enough examples to back up that? I understand this, and maybe package maintainers should adopt the change but since Emacs doesn't ignore unknown attributes, this may result in a lot of extra code in order to support both pre-27 Emacs, and 27+ Emacs to make different versions look consistently. On Wed, Oct 16, 2019 at 2:41 PM Eli Zaretskii wrote: > > From: Andrey Orst > > Date: Wed, 16 Oct 2019 14:17:27 +0300 > > Cc: Eli Zaretskii , 37774@debbugs.gnu.org > > > > > So you are saying that you don't like the new appearance? The Subject > > > says "broke visuals", which sounds like a much more serious problem. > > > > Well, "broke" may be wrong term, here, but lot of themes and packages > crafted > > in a way to display things like that, and now all of those things > displayed accordingly > > to a new setting, which in turn means that: > > > > a) package maintainers should update *all* their packages to look like > before the change, and > > Are you saying that _all_ the faces will have to be modified to make > them extended? IOW, are you saying that this feature is wrong with > most or all of the faces? > > The assumption behind this feature was that the absolute majority of > faces don't need to be extended. If you say this is wrong, can you > show enough examples to back up that? > > > b) maybe Emacs could treat `nil` here as "do not affect", and specify > symbols to set this to different > > settings, like `:extend t` or `:extend 'EOL`, and `:extend 'noextend` > to disable. Though, I do not > > know how code was changed, so maybe there's no way to treat `nil` as > "do not affect". > > Let's first find out how many faces would need to be modified to adapt > to this feature, and only after that discuss the details of the > solution(s). > -- Best regards, Andrey Orst --0000000000008e39c3059505f8ba Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Are you saying that _all_ the faces = will have to be modified to make
> them extended?=C2=A0 IOW, are you = saying that this feature is wrong with
> most or all of the faces?

I don't know about /all/ faces, but I have experie= nced a lot of visual changes
when using `doom-one' theme prov= ided by `doom-themes' package paired
with at least these pack= ages: magit, ediff, solaire-mode, org-mode.

> T= he assumption behind this feature was that the absolute majority of
&g= t; faces don't need to be extended.=C2=A0 If you say this is wrong, can= you
> show enough examples to back up that?

I und= erstand this, and maybe package maintainers should adopt the change
but since Emacs doesn't ignore unknown attributes, this may result i= n a lot of
extra code in order to support both pre-27 Emacs, and = 27+ Emacs to make
different versions look consistently.

On W= ed, Oct 16, 2019 at 2:41 PM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Andrey Orst <andreyorst@gmail.com>
> Date: Wed, 16 Oct 2019 14:17:27 +0300
> Cc: Eli Zaretskii <eliz@gnu.org>, 37774@debbugs.gnu.org
>
> > So you are saying that you don't like the new appearance?=C2= =A0 The Subject
> > says "broke visuals", which sounds like a much more ser= ious problem.
>
> Well, "broke" may be wrong term, here, but lot of themes and= packages crafted
> in a way to display things like that, and now all of those things disp= layed accordingly
> to a new setting, which in turn means that:
>
> a) package maintainers should update *all* their packages to look like= before the change, and

Are you saying that _all_ the faces will have to be modified to make
them extended?=C2=A0 IOW, are you saying that this feature is wrong with most or all of the faces?

The assumption behind this feature was that the absolute majority of
faces don't need to be extended.=C2=A0 If you say this is wrong, can yo= u
show enough examples to back up that?

> b) maybe Emacs could treat `nil` here as "do not affect", an= d specify symbols to set this to different
>=C2=A0 =C2=A0 settings, like `:extend t` or `:extend 'EOL`, and `:e= xtend 'noextend` to disable. Though, I do not
>=C2=A0 =C2=A0 know how code was changed, so maybe there's no way to= treat `nil` as "do not affect".

Let's first find out how many faces would need to be modified to adapt<= br> to this feature, and only after that discuss the details of the
solution(s).


--
Best regards,
Andrey Orst
--0000000000008e39c3059505f8ba--