From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andrey Orst Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 16 Oct 2019 11:12:44 +0300 Message-ID: References: <83bluhf7nz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000001cc7ec059502abf9" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="184464"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Ergus , 37774@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 15:47:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKje3-000ls1-8d for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 15:47:19 +0200 Original-Received: from localhost ([::1]:42882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKje1-0002xp-Mi for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 09:47:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59706) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKjdo-0002sE-Sq for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 09:47:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKjdn-0002pD-K3 for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 09:47:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36629) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKjdn-0002p1-Gv for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 09:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKjdm-0000VN-DJ for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 09:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrey Orst Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 13:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.15712335851869 (code B ref 37774); Wed, 16 Oct 2019 13:47:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 16 Oct 2019 13:46:25 +0000 Original-Received: from localhost ([127.0.0.1]:45440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKjdA-0000U3-OF for submit@debbugs.gnu.org; Wed, 16 Oct 2019 09:46:25 -0400 Original-Received: from mail-yw1-f41.google.com ([209.85.161.41]:33079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKeQY-0007GK-Fy for 37774@debbugs.gnu.org; Wed, 16 Oct 2019 04:13:06 -0400 Original-Received: by mail-yw1-f41.google.com with SMTP id w140so8356683ywd.0 for <37774@debbugs.gnu.org>; Wed, 16 Oct 2019 01:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lroGHDTn3vcioDUa1ng514KTwMSRtrxFWmRgWnzpado=; b=iuxKlqf4pYiNDr41VKjsilDatcUCh/jF08LnoVBRakEkRo3NY2B9YA1NwqoynRUH6d R089DYYqHg3FPYz9ZoX4vFkl7uMtXO6SEIiAakkl6Xl10I1b29BnuSKXGKkcUwqBy38H JZ32mIpSUxMcW9JuSldXx8n26u5Imwl2Tw/pX/zrkJoooaQ9gZQl9qJqn9JBIoGO/6jg b+DVMiYon9M6R157ozF4luW/9z96IR8xAGio9UniTchN1PsZddT63JitN1PdDLwrbO94 xyGt7Z33ogBvscf0qp1y/dEekuWVV0q8n1m3a0wxEWPhsOPqmRu0YUTeNT/cI/Rqhs0E AQWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lroGHDTn3vcioDUa1ng514KTwMSRtrxFWmRgWnzpado=; b=Vsl35CwP0xPswx0vCyMtpeSIal3REu9NQpSWebz4DZugKSAMLOEweGHG71z9cwoVlO PkP5SjzGt4zOvoDSgZSdg4y/ugFHTsBXeFqGJ/MEb4kWBxw/DMsHERCYJwRaMNDZJdNu NWUAqbd4QBatkZ6awDzJte/sDKhMoajBOai8cMMNCdCZ76qaGnpVv8ybkWhmyOdcxdyq bz1as7IHStiffA6JHge/u7gJh0JHdltjCnJ7X1HsNbvwMK+UOa6z9j6WIOzELJM3REKD h1dNiB7F0ZLrW48H27LxSETdKwCMQfI5rBAkToRPRmZkGRLebVM0irpBWdfD1g+S1xjh doNA== X-Gm-Message-State: APjAAAWcU4/pc0it+kIyCURHytVq7L+M+vt5OdXLnx1nLKwukYxkOyZ6 xwcpc1hIYkp54YF7W3hsKUJV0EIjwgXZbPc6UWA= X-Google-Smtp-Source: APXvYqwd+oVSHw4iLAuVY7Jl+DeIhRC+NInLMYhrvx+fBjQntynSkLPIQ6ElrSQH5oQMkT6qVYCoboPx97x6kSFarAQ= X-Received: by 2002:a81:c8c:: with SMTP id 134mr21159242ywm.205.1571213576815; Wed, 16 Oct 2019 01:12:56 -0700 (PDT) In-Reply-To: <83bluhf7nz.fsf@gnu.org> X-Mailman-Approved-At: Wed, 16 Oct 2019 09:46:22 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169449 Archived-At: --0000000000001cc7ec059502abf9 Content-Type: text/plain; charset="UTF-8" these faces are forming visual interface, e.g. hunks in Magit are rectangular regions with background color for entire width of the window that can be folded. Code blocks in org mode are, ahem, blocks. Now those blocks doesn't have anything like block visually. On Wed, Oct 16, 2019, 10:53 Eli Zaretskii wrote: > > From: Andrey Orst > > Date: Wed, 16 Oct 2019 10:00:38 +0300 > > > > Somewhat last checkout from master brought the change of face > > attributes, adding new `:extend` attribute, which make all themes, and > > packages like Magit display weirdly. By this I mean that before the > > change, some faces were set up to extend highlighting beyond EOL, but > > now all of those faces are not doing this. I've first reported this to > > the theme package I'm using: > > https://github.com/hlissner/emacs-doom-themes/issues/342 but I think > > that this should be handled by emacs itself, because if not it will > > result in the duplicated or extra code in themes fro different Emacs > > versions. This reddit post has some screenshots of what I mean: > > > https://www.reddit.com/r/emacs/comments/diahh1/emacs_27_update_changed_how_highlighted_lines/ > > The screenshots you posted don't clearly explain the problem. Some of > them seem actually identical before and after the change, and with > others I don't think I see the problem. > > So please explain what exactly is incorrect or "weird" in the visual > appearance after the change. Specifically, why the faces in question > need to be extended past EOL? > > Thanks. > --0000000000001cc7ec059502abf9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
these faces are forming visual interface, e.g. hunks= in Magit are rectangular regions with background color for entire width of= the window that can be folded. Code blocks in org mode are, ahem, blocks. = Now those blocks doesn't have anything like block visually.

On Wed, Oct 16= , 2019, 10:53 Eli Zaretskii <eliz@gnu.or= g> wrote:
> From: Andrey = Orst <andreyorst@gmail.com>
> Date: Wed, 16 Oct 2019 10:00:38 +0300
>
> Somewhat last checkout from master brought the change of face
> attributes, adding new `:extend` attribute, which make all themes, and=
> packages like Magit display weirdly.=C2=A0 By this I mean that before = the
> change, some faces were set up to extend highlighting beyond EOL, but<= br> > now all of those faces are not doing this.=C2=A0 I've first report= ed this to
> the theme package I'm using:
> https://github.com/hlissner/= emacs-doom-themes/issues/342 but I think
> that this should be handled by emacs itself, because if not it will > result in the duplicated or extra code in themes fro different Emacs > versions.=C2=A0 This reddit post has some screenshots of what I mean:<= br> > https://www.reddit.com/r/emacs/comments/diahh1/emacs_27_update_cha= nged_how_highlighted_lines/

The screenshots you posted don't clearly explain the problem.=C2=A0 Som= e of
them seem actually identical before and after the change, and with
others I don't think I see the problem.

So please explain what exactly is incorrect or "weird" in the vis= ual
appearance after the change.=C2=A0 Specifically, why the faces in question<= br> need to be extended past EOL?

Thanks.
--0000000000001cc7ec059502abf9--