From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andrey Orst Newsgroups: gmane.emacs.bugs Subject: bug#40653: 28.0.50; (fset 'yes-or-no-p 'y-or-n-p) has no effect in native-comp branch Date: Thu, 16 Apr 2020 12:58:23 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000d6783205a36579ef" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="91420"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40653@debbugs.gnu.org, luknax@sdf.org, Stefan Monnier To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 16 11:59:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jP1Ie-000NfC-HX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Apr 2020 11:59:12 +0200 Original-Received: from localhost ([::1]:60192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jP1Id-0002vh-E6 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Apr 2020 05:59:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59156) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jP1IV-0002uH-6g for bug-gnu-emacs@gnu.org; Thu, 16 Apr 2020 05:59:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jP1IU-0006r5-5m for bug-gnu-emacs@gnu.org; Thu, 16 Apr 2020 05:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54263) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jP1IU-0006qw-1i for bug-gnu-emacs@gnu.org; Thu, 16 Apr 2020 05:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jP1IU-0004tn-1S for bug-gnu-emacs@gnu.org; Thu, 16 Apr 2020 05:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrey Orst Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Apr 2020 09:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40653 X-GNU-PR-Package: emacs Original-Received: via spool by 40653-submit@debbugs.gnu.org id=B40653.158703112318807 (code B ref 40653); Thu, 16 Apr 2020 09:59:01 +0000 Original-Received: (at 40653) by debbugs.gnu.org; 16 Apr 2020 09:58:43 +0000 Original-Received: from localhost ([127.0.0.1]:37576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jP1IA-0004tG-Ku for submit@debbugs.gnu.org; Thu, 16 Apr 2020 05:58:42 -0400 Original-Received: from mail-yb1-f176.google.com ([209.85.219.176]:39317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jP1I8-0004t3-BK for 40653@debbugs.gnu.org; Thu, 16 Apr 2020 05:58:40 -0400 Original-Received: by mail-yb1-f176.google.com with SMTP id h205so1712962ybg.6 for <40653@debbugs.gnu.org>; Thu, 16 Apr 2020 02:58:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pgZQHToGPzNKoGDuf72EVB7Air8ItRi26AjFZul7Wpc=; b=t516KLGj2UVmoSjJRBGg8bdO5xVmehr8rKSKobeHaxrzUytIqQoLf4pWBzBKTXN4RQ Hmb3kHfFQ3cVEFrpgFmEN2OmbaZsgtVq6FG1WqLwMFwPJ5V93ZgbdzUAsfTkFo71gdwT LAn3WlJfhm/D6lfQlwhI6OAYez/rwNyRccSmAxHotedUi4ErHasLYHPLwNvXw+hozpQn cpUVc6wzF/CtLewgdvQTFLRtzpFfeO+zu0HMdhcaUHS8sWAqGvb+LUBjSiMGLoMhXpJM lcxw+cSS1sBsTbkAGhbVRdZqmzIeCNPxTjgJHh+kHg7Ai0aRf3JdCXuIup+FZr4XQZU9 Exjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pgZQHToGPzNKoGDuf72EVB7Air8ItRi26AjFZul7Wpc=; b=rgETX6/8icxjQVT1pOSj2iMsnLX70HM/S8oHLBkA0qUKjCHOMeqJOB8UqWcIUXgaBh 1y+SsPbEEkjneKTxzKy4bZwxrbL995+6XmFJ8obAGNSvcIu6lMTvxWZDETa/SnU0ENb9 JiZxYZO05oJtkcBuQrcNh/bcotocH4oSd/RnIH/ql5RIAi3Lbyv+4H+GbSPCH2rf6sWP ddWAo/VAq+dYBUfG9/gQMAKeFgvnxslp3XcrfE1dF9kFzLASXoglDjONw+z2hQXSkN0+ Q9/+ExSF0z0lLCwJGaiErg24jz9bFCrdTzVp9+x5eAyYXH80KhbQroeySQ23Nq4xZLkv votQ== X-Gm-Message-State: AGi0PuYknOxNm0DbAnyb2FfsN1+hf2SFzFSChxTJ+EvQCXCq7XkzaVK8 Kp/aoZPpRuK++5GnqAGqF/TkwsWsvFAfv0UKADc= X-Google-Smtp-Source: APiQypKcn5UquPHGqXrJh6bjvHOJAi/kOY3AwWEE4rhFeVtYsvg1yereJwk0jIeQfyE/I9DVeOjqhjyeNMkYhD6mVqI= X-Received: by 2002:a25:8312:: with SMTP id s18mr15312243ybk.30.1587031114674; Thu, 16 Apr 2020 02:58:34 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178441 Archived-At: --000000000000d6783205a36579ef Content-Type: text/plain; charset="UTF-8" > > The issue is that here we are shadowing with an alias a primitive C > subr. > > Compiling speed 2 the assumption is that these are not redefined or > advised (the manual warns about doing that). Function calls to C > primitives at speed 2 are hardcoded for performance reasons in the > generated code. We have a customize listing exceptions for that > `comp-never-optimize-functions'. > You should solve the issue adding `yes-or-no-p' to this customize and > recompiling. > Ah I see now. This makes sense, although also makes it harder to configure. On the other hand customizing `comp-never-optimize-functions' will solve > the issue only for external packages because you likely already have > compiled the whole Emacs with the default setting... > IIUC I may need to modify the source code of the `comp.el` file, because it gets used when doing `make`? -- Best regards, Andrey Orst --000000000000d6783205a36579ef Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
The issue is that here we are shadowing with an alias a primitive C
subr.

Compiling speed 2 the assumption is that these are not redefined or
advised (the manual warns about doing that).=C2=A0 Function calls to C
primitives at speed 2 are hardcoded for performance reasons in the
generated code.
=C2=A0
=C2=A0We have a customize listing exceptions for that
`comp-never-optimize-functions'.
=C2=A0=C2=A0
You should solve the issue adding `yes-or-no-p' to this customize and recompiling.

=C2=A0Ah I see now. This m= akes sense, although also makes it harder to configure.

On the other hand custo= mizing `comp-never-optimize-functions' will solve
the issue only for external packages because you likely already have
compiled the whole Emacs with the default setting...
=

IIUC I may need to modify the source code of the `= comp.el` file, because it gets used when doing `make`?=C2=A0

=
--
Bes= t regards,
Andrey Orst
--000000000000d6783205a36579ef--