From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Xue Fuqiao Newsgroups: gmane.emacs.bugs Subject: bug#13777: [patch] Add toolbars for Edebug and debugger-mode Date: Wed, 8 May 2013 17:39:55 +0800 Message-ID: References: <20130221184913.101bd49379994f15f3156829@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1368006072 692 80.91.229.3 (8 May 2013 09:41:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 8 May 2013 09:41:12 +0000 (UTC) Cc: 13777@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 08 11:41:11 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ua0ry-0003Vw-Hz for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 May 2013 11:41:06 +0200 Original-Received: from localhost ([::1]:49455 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ua0ry-00016Y-21 for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 May 2013 05:41:06 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ua0rr-00016M-LF for bug-gnu-emacs@gnu.org; Wed, 08 May 2013 05:41:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ua0rn-0004no-Md for bug-gnu-emacs@gnu.org; Wed, 08 May 2013 05:40:59 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57732) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ua0rn-0004nk-DO for bug-gnu-emacs@gnu.org; Wed, 08 May 2013 05:40:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Ua0ss-0000zN-4X for bug-gnu-emacs@gnu.org; Wed, 08 May 2013 05:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Xue Fuqiao Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2013 09:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13777 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13777-submit@debbugs.gnu.org id=B13777.13680060733671 (code B ref 13777); Wed, 08 May 2013 09:42:02 +0000 Original-Received: (at 13777) by debbugs.gnu.org; 8 May 2013 09:41:13 +0000 Original-Received: from localhost ([127.0.0.1]:33608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ua0s0-0000wq-OT for submit@debbugs.gnu.org; Wed, 08 May 2013 05:41:12 -0400 Original-Received: from mail-ie0-f180.google.com ([209.85.223.180]:45892) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ua0rv-0000wM-AA for 13777@debbugs.gnu.org; Wed, 08 May 2013 05:41:07 -0400 Original-Received: by mail-ie0-f180.google.com with SMTP id ar20so2734710iec.39 for <13777@debbugs.gnu.org>; Wed, 08 May 2013 02:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=msSP5LTGt4YC4j3GCYvPRfnDYXnmv02E+NTlw/A1Utk=; b=DKWyoVVr1uftTqcinPOQEpC3+eTUjgBwn2tyccri2/itwgvitsfTFwhmZIuBMDmg0g tPyEfgCM1jAyYu88abHB5XAQ0k6+8BM1OtKlreReJSHJ6bw0KayU4wzo0VlPfj3NL/Al DK1G9E7vfufD2UMR8DWywW1LCLYfHO7VAkw2YmP5fYU8EWBp4nokt4OXF2p+l/RWOYmh 4KqT050OQeCxPbZ4i0c69p0BsS35Vfx4GXOMlgToze64IpswkkQ4wJkNY5QXsNkkphmI cXM7QLTCVXBdAz9yK27iPlPerE1xj+/SV4mpwWuBCImL/QvWLiWwtaPz8vX/KgNBSGLu 4WAg== X-Received: by 10.50.114.166 with SMTP id jh6mr5157184igb.78.1368005995283; Wed, 08 May 2013 02:39:55 -0700 (PDT) Original-Received: by 10.43.18.10 with HTTP; Wed, 8 May 2013 02:39:55 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74078 Archived-At: On Wed, May 8, 2013 at 3:50 PM, Glenn Morris wrote: >> + (defvar edebug-tool-bar-map >> + (let ((map (make-sparse-keymap))) >> + (dolist (x '((edebug-set-breakpoint . "gud/break") >> + (edebug-unset-breakpoint . "gud/remove") >> + (edebug-go-mode . "gud/go") >> + (edebug-stop . "gud/stop") >> + (edebug-continue-mode . "gud/cont") >> + (edebug-next-mode . "gud/next") >> + (edebug-step-mode . "gud/step")) >> + map) >> + (tool-bar-local-item-from-menu >> + (car x) (cdr x) map edebug-mode-map)))) > > Looks alright but: > > i) I think this needs to be moved after the easy-menu-define call. > > ii) You need to find a way to restore the normal tool-bar after edebug > exits (for whatever reason). Agreed. >> + (defvar debugger-tool-bar-map >> + (let ((map (make-sparse-keymap))) >> + (dolist (x '((debugger-continue . "gud/cont") >> + (debugger-step-through . "gud/step")) >> + map) >> + (tool-bar-local-item-from-menu >> + (car x) (cdr x) map debugger-mode-map)))) > > Looks ok, but it's a very sparse tool-bar. Is there nothing more that > can go in it? There are some candidates, such as `backtrace', `cancel-debug-on-entry'. But I haven't found suitable icons for them yet. > It looks a bit silly with just 2 items... Maybe keep some of the > standard ones? Sounds like a good compromise. -- Best regards, Xue Fuqiao. http://www.gnu.org/software/emacs/