> On Dec 8, 2024, at 4:17 AM, john muhl wrote: > > JD Smith > writes: > >>> On Dec 7, 2024, at 8:02 AM, Eli Zaretskii wrote: >>> >>>> From: JD Smith >>>> Date: Sat, 30 Nov 2024 13:58:52 -0500 >>>> Cc: Eli Zaretskii , >>>> Adam Porter , >>>> jonas@bernoul.li, >>>> Paul Eggert >>>> >>>> I was recently reminded of the need for a more capable seconds-to-string. >>>> >>>> Anyone have any additional comments on this proposed patch? If not, >>>> I'd suggest someone with access >>>> merges. >>> >>> A few minor nits below, and then we can install: >> >> Thanks. Updated patch below. > > Thanks for working on this. I gave a quick try and noticed some > amounts aren’t pluralized how I expect; e.g. > > (seconds-to-string 36541462 'expanded nil 1) > ;; "1 year 1.9 month" ... > According to the Chicago Manual of Style all fractional values are > plural, even 1.0, 2.0 &c. Thanks for this, a case I hadn't tested. Corrected in the attached.