From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Federico Tedin Newsgroups: gmane.emacs.bugs Subject: bug#34001: 26.1.90; :distant-foreground face property fails to work in most cases Date: Fri, 1 Mar 2019 09:44:30 -0300 Message-ID: References: <87a7k1l88w.fsf@gmail.com> <83o96vhtsl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000004ba246058307c532" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="157366"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34001-done@debbugs.gnu.org, tinakellyrussell@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 01 13:46:34 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzhYe-000epA-IZ for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Mar 2019 13:46:32 +0100 Original-Received: from localhost ([127.0.0.1]:36993 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzhYd-00018P-DN for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Mar 2019 07:46:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzhXE-000062-0j for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2019 07:45:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gzhXC-0000XJ-VG for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2019 07:45:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42338) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gzhXC-0000Wu-Rm for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2019 07:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gzhXC-000290-Hn for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2019 07:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Federico Tedin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Mar 2019 12:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34001 X-GNU-PR-Package: emacs Original-Received: via spool by 34001-done@debbugs.gnu.org id=D34001.15514442898207 (code D ref 34001); Fri, 01 Mar 2019 12:45:02 +0000 Original-Received: (at 34001-done) by debbugs.gnu.org; 1 Mar 2019 12:44:49 +0000 Original-Received: from localhost ([127.0.0.1]:55882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gzhWz-00028J-ED for submit@debbugs.gnu.org; Fri, 01 Mar 2019 07:44:49 -0500 Original-Received: from mail-qk1-f172.google.com ([209.85.222.172]:40172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gzhWx-000283-Ak for 34001-done@debbugs.gnu.org; Fri, 01 Mar 2019 07:44:47 -0500 Original-Received: by mail-qk1-f172.google.com with SMTP id h28so14152824qkk.7 for <34001-done@debbugs.gnu.org>; Fri, 01 Mar 2019 04:44:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o13bh/9zETm7hG9ifVkamlmSnBJWYLPAWiBbf/CVTn8=; b=uEpq0vIGzPvMsbSS8dhK5Q1AhujYxsu5vz4r1fxqevsBkcRIcD/nKAoeLE9fi0dE5d NsDjprGeu6hdAzj+vaU58JHq6YjSvqcqAL7L4OzgE7yR7UTgVipqDZjJzOcOOTGRPDBd cPgW/01jIr+yBdNjeTyeZ++9k0aUGLCw/M3Dw/DqGI8cGWOyDIL2NaJWL73OOoKbPioU OVY70NGaS7PCg7RoBwKuBdAHnZ8k1bcRhgvo8yNFXUhKWWfmFmACk0T09gjtPyW3MaPk itNbpf1zxgAVRsVId79UOtTlJh5oV5V2pBEpjMhNqA2IbOBR4PRWP0lpU0iNXtts8FbM k1pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o13bh/9zETm7hG9ifVkamlmSnBJWYLPAWiBbf/CVTn8=; b=nSBq9708OKzhwUfK74V92qZ3MhvjTKhHGCgBjfpcBL5oslPy8T8nkLAK+VzFZvc3q0 zrI/nBEHfVMpdqZxvxoWRXXFbtTUfedBUoV4IssNSlnfPhBqIdW9o4Vq9EuzzNwjjHT1 MV90VqVqqgDVSLIP8JkpngzNwzFUjbl6vnEIcyJT5u7NQ/jPXsJNJY+m5k6IXlsqCwDO 3LrT4V/F8rQq24POACbdtd9Ge7Lt6RSTWx/2vrf3wu8Z5LnwfLoIoOvnoPqPH5sz7x9C 5M9v2aYAGDmxc86PjUVMmC0kP62U8xGfdqLqZPngV5haR0G9b/cnA1ujxmE8j/Tsxz8O 7jiA== X-Gm-Message-State: APjAAAXm2OQKtURWqi3yuEkE/Rq88ejdxM7VkM7wKx22os+fnRa1ivZK d9nz30lnrD2UcnjCZSxznPqSVDk8dK5mUrzWLLE= X-Google-Smtp-Source: APXvYqyBSgXvO4IDQNIN6qd1Cd2ASOCANdopvRcreUQDrKoVa+DPfEfv9t/+0/29/2x9jZ/9by24WAZfXK/PJ+Ddllc= X-Received: by 2002:a37:f513:: with SMTP id l19mr3696449qkk.313.1551444281629; Fri, 01 Mar 2019 04:44:41 -0800 (PST) In-Reply-To: <83o96vhtsl.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155926 Archived-At: --0000000000004ba246058307c532 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks Eli! I have a question regarding commit messages and documentation: should I include them in the first iteration of the patch I created, or should I wait until there=E2=80=99s been some conversation first? Until now I=E2=80= =99ve chosen the first option since I=E2=80=99m not always sure the patch I created is correct/applicable/etc. On Fri, 1 Mar 2019 at 05:40 Eli Zaretskii wrote: > > From: Federico Tedin > > Date: Tue, 15 Jan 2019 22:08:15 -0300 > > > > I've created a patch that introduces a new variable > > `face-near-same-color-threshold', with a default value of 30000 (as was > > defined in NEAR_SAME_COLOR_THRESHOLD in xfaces.c). Changing this > > variable's value will make certain color combinations be considered as > > 'same', which will lead to :distant-foreground being used. For example: > > Sorry for the long delay, I've now pushed your change to the master > branch. > > Please in the future provide a ChangeLog-style commit log message for > your changes, and also accompany them with the pertinent updates for > the documentation. I did that for this change. > > Thanks again for working on this. > --0000000000004ba246058307c532 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks Eli!

<= div dir=3D"auto">I have a question regarding commit messages and documentat= ion: should I include them in the first iteration of the patch I created, o= r should I wait until there=E2=80=99s been some conversation first?=C2=A0 U= ntil now I=E2=80=99ve chosen the first option since I=E2=80=99m not always = sure the patch I created is correct/applicable/etc.

On Fri, 1 Mar 2019 = at 05:40 Eli Zaretskii <eliz@gnu.org= > wrote:
> From: Federico Ted= in <federic= otedin@gmail.com>
> Date: Tue, 15 Jan 2019 22:08:15 -0300
>
> I've created a patch that introduces a new variable
> `face-near-same-color-threshold', with a default value of 30000 (a= s was
> defined in NEAR_SAME_COLOR_THRESHOLD in xfaces.c). Changing this
> variable's value will make certain color combinations be considere= d as
> 'same', which will lead to :distant-foreground being used. For= example:

Sorry for the long delay, I've now pushed your change to the master
branch.

Please in the future provide a ChangeLog-style commit log message for
your changes, and also accompany them with the pertinent updates for
the documentation.=C2=A0 I did that for this change.

Thanks again for working on this.
--0000000000004ba246058307c532--